Changeset 6271 in vbox for trunk

Timestamp:

Jan 8, 2008 8:45:43 AM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

27116

Message:

serial: fixed error handling; be a little bit more verbose on errors

File:

• trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp

@@ -740 +740 @@
 ioctl_error:
             PDMDrvHlpVMSetRuntimeError(pDrvIns, false, "DrvHostSerialFail",
-                                       N_("Ioctl failed for serial host device '%s' (error %d)"),
-                                       pData->pszDevicePath, errno);
+                                       N_("Ioctl failed for serial host device '%s' (%Vrc). The device will not work properly"),
+                                       pData->pszDevicePath, RTErrConvertFromErrno(errno));
             break;
         }
@@ -765 +765 @@
 /**
  * Unblock the monitor thread so it can respond to a state change.
+ * We need to execute this code exactly once during initialization.
+ * But we don't want to block --- therefore this dedicated thread.
  *
  * @returns a VBox status code.
@@ -773 +775 @@
 {
     PDRVHOSTSERIAL pData = PDMINS2DATA(pDrvIns, PDRVHOSTSERIAL);
-    int rc = VINF_SUCCESS;
+    int rc;
 
     /*
@@ -794 +796 @@
      */
     rc = ioctl(pData->DeviceFile, TIOCMBIC, TIOCM_LOOP);
-    if (rc < 0)
-        goto ioctl_error;
+    if (rc >= 0)
+        return VINF_SUCCESS;
 
 ioctl_error:
     PDMDrvHlpVMSetRuntimeError(pDrvIns, false, "DrvHostSerialFail",
-                                N_("Ioctl failed for serial host device '%s' (error %d)"),
-                                pData->pszDevicePath, errno);
-
+                                N_("Ioctl failed for serial host device '%s' (%Vrc). The device will not work properly"),
+                                pData->pszDevicePath, RTErrConvertFromErrno(errno));
     return VINF_SUCCESS;
 }