Changeset 62717 in vbox for trunk/src/VBox/HostDrivers

Timestamp:

Jul 29, 2016 10:03:37 PM (8 years ago)

Author:

vboxsync

Message:

HostDrivers: warnings

Location:

trunk/src/VBox/HostDrivers/VBoxUSB

Files:

• VBoxUSBFilterMgr.cpp (modified) (3 diffs)
• win/cmn/VBoxDrvTool.cpp (modified) (1 diff)
• win/mon/VBoxUsbHook.cpp (modified) (3 diffs)

trunk/src/VBox/HostDrivers/VBoxUSB/VBoxUSBFilterMgr.cpp

@@ -327 +327 @@
     {
         void *pv = RTHandleTableFree(g_hHndTableFilters, pCur->uHnd);
-        Assert(pv == pCur);
+        Assert(pv == pCur); NOREF(pv);
         vboxUSBFilterFree(pCur);
         return VINF_SUCCESS;
@@ -417 +417 @@
         PVBOXUSBFILTER pNext = pToFree->pNext;
         void *pv = RTHandleTableFree(g_hHndTableFilters, pToFree->uHnd);
-        Assert(pv == pToFree);
+        Assert(pv == pToFree); NOREF(pv);
         vboxUSBFilterFree(pToFree);
         pToFree = pNext;
@@ -503 +503 @@
                     {
                         void *pv = RTHandleTableFree(g_hHndTableFilters, pCur->uHnd);
-                        Assert(pv == pCur);
+                        Assert(pv == pCur); NOREF(pv);
                         vboxUSBFilterFree(pCur);
                     }

trunk/src/VBox/HostDrivers/VBoxUSB/win/cmn/VBoxDrvTool.cpp

@@ -80 +80 @@
     RtlInitUnicodeString(&RtlStr, pName);
     NTSTATUS Status = ZwQueryValueKey(hKey,
-                &RtlStr,
-                KeyValuePartialInformation,
-                &Buf.Info,
-                sizeof(Buf),
-                &cbBuf);
+                                      &RtlStr,
+                                      KeyValuePartialInformation,
+                                      &Buf.Info,
+                                      sizeof(Buf),
+                                      &cbBuf);
     if (Status == STATUS_SUCCESS)
     {

trunk/src/VBox/HostDrivers/VBoxUSB/win/mon/VBoxUsbHook.cpp

@@ -3 +3 @@
  * Driver Dispatch Table Hooking API
  */
+
 /*
  * Copyright (C) 2011-2016 Oracle Corporation
@@ -14 +15 @@
  * hope that it will be useful, but WITHOUT ANY WARRANTY of any kind.
  */
+
+
+/*********************************************************************************************************************************
+*   Header Files                                                                                                                 *
+*********************************************************************************************************************************/
 #include "VBoxUsbMon.h"
 
+
+/*********************************************************************************************************************************
+*   Defined Constants And Macros                                                                                                 *
+*********************************************************************************************************************************/
 #define VBOXUSBHOOK_MEMTAG 'HUBV'
+
 
 NTSTATUS VBoxUsbHookInstall(PVBOXUSBHOOK_ENTRY pHook)
@@ -132 +143 @@
 }
 
-NTSTATUS VBoxUsbHookRequestMoreProcessingRequired(PVBOXUSBHOOK_ENTRY pHook, PDEVICE_OBJECT pDevObj, PIRP pIrp, PVBOXUSBHOOK_REQUEST pRequest)
+NTSTATUS VBoxUsbHookRequestMoreProcessingRequired(PVBOXUSBHOOK_ENTRY pHook, PDEVICE_OBJECT pDevObj, PIRP pIrp,
+                                                  PVBOXUSBHOOK_REQUEST pRequest)
 {
+    RT_NOREF3(pHook, pDevObj, pIrp);
     Assert(!pRequest->bCompletionStopped);
     pRequest->bCompletionStopped = TRUE;