Changeset 62723 in vbox for trunk/src/VBox/Runtime/testcase

Timestamp:

Jul 30, 2016 12:02:01 AM (8 years ago)

Author:

vboxsync

Message:

RTDirCreateUniqueNumbered: Changed the implementation to count from zero and only do 20 sequential tries before switching to random numbers. Also, don't bother retrying more than 10000 times. Corrected the cchDigits parameter (nobody counts in signed int!).

Location:

trunk/src/VBox/Runtime/testcase

Files:

• tstRTDirCreateUniqueNumbered.cpp (modified) (2 diffs)
• tstStrToNum.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/testcase/tstRTDirCreateUniqueNumbered.cpp

@@ -59 +59 @@
     /* The test loop. */
     size_t i;
-    for (i = 0; i < cTimes; i++)
+    for (i = 0; i < cTimes + 1; i++)
     {
         char szName[RTPATH_MAX];
@@ -118 +118 @@
      * Create some test directories.
      */
-    tst1(1, 1, 0  );
+    tst1(1, 1, '\0');
     tst1(2, 1, '-');
-    tst1(3, 2, 0  );
+    tst1(3, 2, '\0');
     tst1(4, 2, '-');
 

trunk/src/VBox/Runtime/testcase/tstStrToNum.cpp

@@ -189 +189 @@
         { "4564678",                0,  VINF_SUCCESS,          4564678 },
         { "4564678",               10,  VINF_SUCCESS,          4564678 },
-        { "-1234567890123456789",   0,  VWRN_NUMBER_TOO_BIG,   (int32_t)-1234567890123456789LL },
-        { "-1234567890123456789",  10,  VWRN_NUMBER_TOO_BIG,   (int32_t)-1234567890123456789LL },
-        { "1234567890123456789",    0,  VWRN_NUMBER_TOO_BIG,   (int32_t)1234567890123456789LL },
-        { "1234567890123456789",   10,  VWRN_NUMBER_TOO_BIG,   (int32_t)1234567890123456789LL },
+        { "-1234567890123456789",   0,  VWRN_NUMBER_TOO_BIG,   (int32_t)((uint64_t)INT64_C(-1234567890123456789) & UINT32_MAX) },
+        { "-1234567890123456789",  10,  VWRN_NUMBER_TOO_BIG,   (int32_t)((uint64_t)INT64_C(-1234567890123456789) & UINT32_MAX) },
+        { "1234567890123456789",    0,  VWRN_NUMBER_TOO_BIG,   (int32_t)(INT64_C(1234567890123456789)            & UINT32_MAX) },
+        { "1234567890123456789",   10,  VWRN_NUMBER_TOO_BIG,   (int32_t)(INT64_C(1234567890123456789)            & UINT32_MAX) },
         { "0x",                     0,  VWRN_TRAILING_CHARS,    0 },
         { "0x1",                    0,  VINF_SUCCESS,           1 },