Changeset 62734 in vbox for trunk/src/VBox/Storage

Timestamp:

Jul 30, 2016 11:55:29 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109312

Message:

Storage: warnings.

File:

• trunk/src/VBox/Storage/testcase/tstVDIo.cpp (modified) (23 diffs)

trunk/src/VBox/Storage/testcase/tstVDIo.cpp

@@ -509 +509 @@
 static DECLCALLBACK(int) vdScriptCallbackPrint(PVDSCRIPTARG paScriptArgs, void *pvUser)
 {
+    NOREF(pvUser);
     RTPrintf(paScriptArgs[0].psz);
     return VINF_SUCCESS;
@@ -515 +516 @@
 static DECLCALLBACK(void) tstVDError(void *pvUser, int rc, RT_SRC_POS_DECL, const char *pszFormat, va_list va)
 {
+    NOREF(pvUser);
     RTPrintf("tstVDIo: Error %Rrc at %s:%u (%s): ", rc, RT_SRC_POS_ARGS);
     RTPrintfV(pszFormat, va);
@@ -522 +524 @@
 static DECLCALLBACK(int) tstVDMessage(void *pvUser, const char *pszFormat, va_list va)
 {
+    NOREF(pvUser);
     RTPrintf("tstVDIo: ");
     RTPrintfV(pszFormat, va);
@@ -554 +557 @@
     bool fIgnoreFlush = false;
     bool fHonorSame = false;
-    PVDIOBACKEND pIoBackend = NULL;
 
     pcszDisk = paScriptArgs[0].psz;
@@ -710 +712 @@
     uint64_t cbIo = 0;
     uint64_t cbBlkSize = 0;
-    bool fDataProviderRnd = false;
-    bool fPrintStats = false;
     uint64_t offStart = 0;
     uint64_t offEnd = 0;
@@ -1643 +1643 @@
 static DECLCALLBACK(int) vdScriptHandlerIoRngDestroy(PVDSCRIPTARG paScriptArgs, void *pvUser)
 {
+    RT_NOREF1(paScriptArgs);
     PVDTESTGLOB pGlob = (PVDTESTGLOB)pvUser;
 
@@ -1767 +1768 @@
 static DECLCALLBACK(int) vdScriptHandlerSleep(PVDSCRIPTARG paScriptArgs, void *pvUser)
 {
-    int rc = VINF_SUCCESS;
+    RT_NOREF1(pvUser);
     uint64_t cMillies = paScriptArgs[0].u64;
 
-    rc = RTThreadSleep(cMillies);
+    int rc = RTThreadSleep(cMillies);
     return rc;
 }
@@ -1999 +2000 @@
 static DECLCALLBACK(int) vdScriptHandlerPrintMsg(PVDSCRIPTARG paScriptArgs, void *pvUser)
 {
+    RT_NOREF1(pvUser);
     RTPrintf("%s\n", paScriptArgs[0].psz);
     return VINF_SUCCESS;
@@ -2194 +2196 @@
 static DECLCALLBACK(int) tstVDIoFileClose(void *pvUser, void *pStorage)
 {
+    RT_NOREF1(pvUser);
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
 
@@ -2242 +2245 @@
 static DECLCALLBACK(int) tstVDIoFileMove(void *pvUser, const char *pcszSrc, const char *pcszDst, unsigned fMove)
 {
+    RT_NOREF1(fMove);
     int rc = VINF_SUCCESS;
     PVDTESTGLOB pGlob = (PVDTESTGLOB)pvUser;
@@ -2276 +2280 @@
 static DECLCALLBACK(int) tstVDIoFileGetFreeSpace(void *pvUser, const char *pcszFilename, int64_t *pcbFreeSpace)
 {
+    RT_NOREF2(pvUser, pcszFilename);
     AssertPtrReturn(pcbFreeSpace, VERR_INVALID_POINTER);
 
@@ -2284 +2289 @@
 static DECLCALLBACK(int) tstVDIoFileGetModificationTime(void *pvUser, const char *pcszFilename, PRTTIMESPEC pModificationTime)
 {
+    RT_NOREF2(pvUser, pcszFilename);
     AssertPtrReturn(pModificationTime, VERR_INVALID_POINTER);
 
@@ -2292 +2298 @@
 static DECLCALLBACK(int) tstVDIoFileGetSize(void *pvUser, void *pStorage, uint64_t *pcbSize)
 {
+    RT_NOREF1(pvUser);
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
 
@@ -2299 +2306 @@
 static DECLCALLBACK(int) tstVDIoFileSetSize(void *pvUser, void *pStorage, uint64_t cbSize)
 {
+    RT_NOREF1(pvUser);
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
 
@@ -2306 +2314 @@
 static DECLCALLBACK(int) tstVDIoFileSetAllocationSize(void *pvUser, void *pStorage, uint64_t cbSize, uint32_t fFlags)
 {
+    RT_NOREF4(pvUser, pStorage, cbSize, fFlags);
     return VERR_NOT_SUPPORTED;
 }
@@ -2312 +2321 @@
                                               const void *pvBuffer, size_t cbBuffer, size_t *pcbWritten)
 {
+    RT_NOREF1(pvUser);
     int rc = VINF_SUCCESS;
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
@@ -2336 +2346 @@
                                              void *pvBuffer, size_t cbBuffer, size_t *pcbRead)
 {
+    RT_NOREF1(pvUser);
     int rc = VINF_SUCCESS;
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
@@ -2359 +2370 @@
 static DECLCALLBACK(int) tstVDIoFileFlushSync(void *pvUser, void *pStorage)
 {
+    RT_NOREF1(pvUser);
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
     int rc = VDIoBackendTransfer(pIoStorage->pFile->pIoStorage, VDIOTXDIR_FLUSH, 0,
@@ -2371 +2383 @@
                                               void **ppTask)
 {
-    int rc = VINF_SUCCESS;
-    PVDTESTGLOB pGlob = (PVDTESTGLOB)pvUser;
+    RT_NOREF2(pvUser, ppTask);
+    int rc = VINF_SUCCESS;
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
     RTSGBUF SgBuf;
@@ -2393 +2405 @@
                                                void **ppTask)
 {
-    int rc = VINF_SUCCESS;
-    PVDTESTGLOB pGlob = (PVDTESTGLOB)pvUser;
+    RT_NOREF2(pvUser, ppTask);
+    int rc = VINF_SUCCESS;
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
     RTSGBUF SgBuf;
@@ -2413 +2425 @@
                                                void **ppTask)
 {
-    int rc = VINF_SUCCESS;
-    PVDTESTGLOB pGlob = (PVDTESTGLOB)pvUser;
+    RT_NOREF2(pvUser, ppTask);
+    int rc = VINF_SUCCESS;
     PVDSTORAGE pIoStorage = (PVDSTORAGE)pStorage;
 
@@ -2450 +2462 @@
                            : pIoTest->offEnd - pIoTest->offStart;
 
-        pIoTest->u.Rnd.cBlocks = cbRange / cbBlkSize + ((cbRange % cbBlkSize) ? 1 : 0);
+        pIoTest->u.Rnd.cBlocks = (uint32_t)(cbRange / cbBlkSize + (cbRange % cbBlkSize ? 1 : 0));
         pIoTest->u.Rnd.cBlocksLeft = pIoTest->u.Rnd.cBlocks;
         pIoTest->u.Rnd.pbMapAccessed = (uint8_t *)RTMemAllocZ(pIoTest->u.Rnd.cBlocks / 8
@@ -2590 +2602 @@
 static DECLCALLBACK(void) tstVDIoTestReqComplete(void *pvUser1, void *pvUser2, int rcReq)
 {
+    RT_NOREF1(rcReq);
     PVDIOREQ pIoReq = (PVDIOREQ)pvUser1;
     RTSEMEVENT hEventSem = (RTSEMEVENT)pvUser2;