Changeset 62774 in vbox for trunk/src/VBox/Main/src-helper-apps

Timestamp:

Jul 31, 2016 5:44:26 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109361

Message:

Main: warnings

File:

• trunk/src/VBox/Main/src-helper-apps/VBoxExtPackHelperApp.cpp (modified) (7 diffs)

trunk/src/VBox/Main/src-helper-apps/VBoxExtPackHelperApp.cpp

@@ -48 +48 @@
 #ifdef RT_OS_WINDOWS
 # define _WIN32_WINNT 0x0501
+# include <iprt/win/windows.h>          /* ShellExecuteEx, ++ */
 # include <Objbase.h>                   /* CoInitializeEx */
-# include <iprt/win/windows.h>                   /* ShellExecuteEx, ++ */
 # ifdef DEBUG
 #  include <Sddl.h>
@@ -296 +296 @@
 #else
      /** @todo TrustedInstaller? */
+     RT_NOREF1(pszDir);
 #endif
 
@@ -339 +340 @@
 static RTEXITCODE ValidateUnpackedExtPack(const char *pszDir, const char *pszTarball, const char *pszExtPackName)
 {
+    RT_NOREF2(pszTarball, pszExtPackName);
     RTMsgInfo("Validating unpacked extension pack...");
 
@@ -490 +492 @@
                                 const char *pszTarball)
 {
+    RT_NOREF1(pszTarball);
     RTMsgInfo("Unpacking extension pack into '%s'...", pszDirDst);
 
@@ -653 +656 @@
                              const char *pszName, const char *pszMangledName, bool fReplace)
 {
+    RT_NOREF1(pszCertDir);
+
     /*
      * Do some basic validation of the tarball file.
@@ -1233 +1238 @@
                                          int iCmd, const char *pszDisplayInfoHack)
 {
+    RT_NOREF1(cMyArgs);
     RTEXITCODE rcExit = RTEXITCODE_FAILURE;
 #ifdef RT_OS_WINDOWS
@@ -1320 +1326 @@
                         if (GetExitCodeProcess(Info.hProcess, &dwExitCode))
                         {
-                            if (dwExitCode >= 0 && dwExitCode < 128)
+                            if (dwExitCode < 128)
                                 rcExit = (RTEXITCODE)dwExitCode;
                             else