Changeset 62782 in vbox for trunk/src/VBox/HostServices/SharedOpenGL

Timestamp:

Jul 31, 2016 10:50:29 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109369

Message:

HostServices,GuestHost: warnings

Location:

trunk/src/VBox/HostServices/SharedOpenGL

Files:

• crserver/crservice.cpp (modified) (3 diffs)
• crserverlib/server_clip.c (modified) (1 diff)
• crserverlib/server_main.c (modified) (3 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/crserver/crservice.cpp

@@ -1 +1 @@
 /* $Id$ */
-
 /** @file
- * VBox crOpenGL: Host service entry points.
+ * VBox crOpenGL - Host service entry points.
  */
 
@@ -33 +32 @@
 #include <VBox/log.h>
 #include <VBox/com/array.h>
+#if 0
 #include <VBox/com/ErrorInfo.h>
 #include <VBox/com/VirtualBox.h>
@@ -1595 +1595 @@
 }
 #endif
+#endif

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_clip.c

@@ -11 +11 @@
 
 #include <math.h>
+
 #include "cr_server.h"
 #include "cr_mem.h"

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_main.c

@@ -2568 +2568 @@
     int i;
 
-    if (sCount>CR_MAX_GUEST_MONITORS)
+    if (sCount > CR_MAX_GUEST_MONITORS)
         return VERR_INVALID_PARAMETER;
 
     /*Shouldn't happen yet, but to be safe in future*/
-    for (i=0; i<cr_server.screenCount; ++i)
+    for (i = 0; i < cr_server.screenCount; /*++i - unreachable code*/)
     {
         if (MAPPED(SCREEN(i)))
@@ -3573 +3573 @@
             return -1;
     }
-
-    WARN(("internal error"));
-    return -1;
+    /* not reached */
 }
 
@@ -3916 +3914 @@
 
 
-static DECLCALLBACK(bool) crVBoxServerHasData()
+static DECLCALLBACK(bool) crVBoxServerHasData(void)
 {
     HCR_FRAMEBUFFER hFb = CrPMgrFbGetFirstEnabled();