Changeset 62787 in vbox for trunk/src/VBox

Timestamp:

Aug 1, 2016 7:01:38 AM (8 years ago)

Author:

vboxsync

Message:

HostServices: warnings

File:

• trunk/src/VBox/HostServices/SharedFolders/service.cpp (modified) (10 diffs)

trunk/src/VBox/HostServices/SharedFolders/service.cpp

@@ +1 @@
+/* $Id$ */
 /** @file
- * Shared Folders: Host service entry points.
+ * Shared Folders - Host service entry points.
  */
 
@@ -32 +33 @@
 
 
-/* Shared Folders Host Service.
+/** @page pg_shfl_svc   Shared Folders Host Service
  *
  * Shared Folders map a host file system to guest logical filesystem.
@@ -84 +85 @@
 static DECLCALLBACK(int) svcConnect (void *, uint32_t u32ClientID, void *pvClient)
 {
+    RT_NOREF2(u32ClientID, pvClient);
     int rc = VINF_SUCCESS;
-
-    NOREF(u32ClientID);
-    NOREF(pvClient);
 
     Log(("SharedFolders host service: connected, u32ClientID = %u\n", u32ClientID));
@@ -96 +95 @@
 static DECLCALLBACK(int) svcDisconnect (void *, uint32_t u32ClientID, void *pvClient)
 {
+    RT_NOREF1(u32ClientID);
     int rc = VINF_SUCCESS;
     SHFLCLIENTDATA *pClient = (SHFLCLIENTDATA *)pvClient;
@@ -114 +114 @@
 {
 #ifndef UNITTEST  /* Read this as not yet tested */
+    RT_NOREF1(u32ClientID);
     SHFLCLIENTDATA *pClient = (SHFLCLIENTDATA *)pvClient;
 
@@ -169 +170 @@
     }
 
+#else
+    RT_NOREF3(u32ClientID, pvClient, pSSM);
 #endif
     return VINF_SUCCESS;
@@ -176 +179 @@
 {
 #ifndef UNITTEST  /* Read this as not yet tested */
+    RT_NOREF1(u32ClientID);
     uint32_t        nrMappings;
     SHFLCLIENTDATA *pClient = (SHFLCLIENTDATA *)pvClient;
@@ -286 +290 @@
     }
     Log(("SharedFolders host service: successfully loaded state\n"));
+#else
+    RT_NOREF3(u32ClientID, pvClient, pSSM);
 #endif
     return VINF_SUCCESS;
@@ -292 +298 @@
 static DECLCALLBACK(void) svcCall (void *, VBOXHGCMCALLHANDLE callHandle, uint32_t u32ClientID, void *pvClient, uint32_t u32Function, uint32_t cParms, VBOXHGCMSVCPARM paParms[])
 {
+    RT_NOREF1(u32ClientID);
     int rc = VINF_SUCCESS;
 
@@ -300 +307 @@
     bool fAsynchronousProcessing = false;
 
-#ifdef DEBUG
-    uint32_t i;
-
-    for (i = 0; i < cParms; i++)
+#ifdef LOG_ENABLED
+    for (uint32_t i = 0; i < cParms; i++)
     {
         /** @todo parameters other than 32 bit */