Changeset 62796 in vbox for trunk/src/VBox

Timestamp:

Aug 1, 2016 9:09:20 AM (8 years ago)

Author:

vboxsync

Message:

RTDirCreateUniqueNumbered: Don't depend on uint64_t wrap around.

File:

• trunk/src/VBox/Runtime/generic/RTDirCreateUniqueNumbered-generic.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/generic/RTDirCreateUniqueNumbered-generic.cpp

@@ -111 +111 @@
 
         Assert(cbLeft > cchDigits);
-        uint64_t iSeq = UINT64_MAX;
         for (uint32_t iTry = 0; iTry <= cMaxTries; iTry++)
         {
             /* Try sequentially first for a little bit, then switch to random numbers. */
+            uint64_t iSeq;
             if (iTry > 20)
                 iSeq = RTRandU64Ex(0, uEndSeq);
             else
             {
-                iSeq++;
-                if (iSeq < UINT64_MAX)
+                iSeq = iTry;
+                if (uEndSeq < UINT64_MAX)
                     iSeq %= uEndSeq + 1;
             }