Changeset 62827 in vbox for trunk/src/VBox

Timestamp:

Aug 1, 2016 3:44:42 PM (8 years ago)

Author:

vboxsync

Message:

ExtPacks/dtrace: warnings

Location:

trunk/src/VBox/ExtPacks/VBoxDTrace

Files:

• include/VBoxDTraceTypes.h (modified) (1 diff)
• onnv/cmd/dtrace/dtrace.c (modified) (11 diffs)
• onnv/lib/libdtrace/common/dt_aggregate.c (modified) (9 diffs)
• onnv/lib/libdtrace/common/dt_as.c (modified) (2 diffs)
• onnv/lib/libdtrace/common/dt_cc.c (modified) (10 diffs)
• onnv/lib/libdtrace/common/dtrace.h (modified) (1 diff)

trunk/src/VBox/ExtPacks/VBoxDTrace/include/VBoxDTraceTypes.h

@@ -144 +144 @@
 #define VBDTUNASS(a_Value)      = a_Value
 #define VBDTGCC(a_Value)        = a_Value
+#define VBDTMSC(a_Value)        = a_Value
 
 /*

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/cmd/dtrace/dtrace.c

@@ -618 +618 @@
         dtrace_probedesc_t *pdp = &edp->dted_probe;
         dtrace_probeinfo_t p;
+        RT_NOREF1(pgp);
 
         if (edp == *last)
@@ -744 +745 @@
 {
         dtrace_probeinfo_t p;
+        RT_NOREF1(arg);
 
         oprintf("%5d %10s %17s %33s %s\n", pdp->dtpd_id,
@@ -760 +762 @@
 {
         dtrace_ecbdesc_t *edp = stp->dtsd_ecbdesc;
+        RT_NOREF1(pgp);
 
         if (edp == *last)
@@ -869 +872 @@
                 break;
         }
-#endif /* !VBOX */
+#else
+        RT_NOREF3(P, msg, arg);
+#endif /* VBOX */
 }
 
@@ -876 +881 @@
 errhandler(const dtrace_errdata_t *data, void *arg)
 {
+        RT_NOREF1(arg);
         error(data->dteda_msg);
         return (DTRACE_HANDLE_OK);
@@ -884 +890 @@
 drophandler(const dtrace_dropdata_t *data, void *arg)
 {
+        RT_NOREF1(arg);
         error(data->dtdda_msg);
         return (DTRACE_HANDLE_OK);
@@ -892 +899 @@
 setopthandler(const dtrace_setoptdata_t *data, void *arg)
 {
+        RT_NOREF1(arg);
         if (strcmp(data->dtsda_option, "quiet") == 0)
                 g_quiet = data->dtsda_newval != DTRACEOPT_UNSET;
@@ -955 +963 @@
             { NULL }
         };
+        RT_NOREF1(arg);
 
         if (bufdata->dtbda_probe != NULL) {
@@ -1054 +1063 @@
         dtrace_actkind_t act;
         uintptr_t addr;
+        RT_NOREF1(arg);
 
         if (rec == NULL) {
@@ -1084 +1094 @@
         processorid_t cpu = data->dtpda_cpu;
         static int heading;
+        RT_NOREF1(arg);
 
         if (g_impatient) {
@@ -1311 +1322 @@
         while ((c = RTGetOpt(&GetState, &ValueUnion))) {
                 {
-                        const char *optarg = ValueUnion.psz;
+                        /* const char *optarg = ValueUnion.psz; - unused */
 #endif
                         switch (c) {

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dt_aggregate.c

@@ -92 +92 @@
 dt_aggregate_min(int64_t *existing, int64_t *new, size_t size)
 {
+        RT_NOREF1(size);
         if (*new < *existing)
                 *existing = *new;
@@ -100 +101 @@
 dt_aggregate_max(int64_t *existing, int64_t *new, size_t size)
 {
+        RT_NOREF1(size);
         if (*new > *existing)
                 *existing = *new;
@@ -141 +143 @@
         uint16_t levels = DTRACE_LQUANTIZE_LEVELS(arg);
         int i;
+        RT_NOREF1(size);
 
         for (i = 0; i <= levels + 1; i++)
@@ -222 +225 @@
         int nbuckets = DTRACE_QUANTIZE_NBUCKETS, i;
         long double ltotal = 0, rtotal = 0;
-        int64_t lzero, rzero;
+        int64_t lzero VBDTMSC(0), rzero VBDTMSC(0);
 
         for (i = 0; i < nbuckets; i++) {
@@ -278 +281 @@
         dt_proc_unlock(dtp, P);
         dt_proc_release(dtp, P);
+#else
+        RT_NOREF2(dtp, data);
 #endif
 }
@@ -303 +308 @@
         dt_proc_unlock(dtp, P);
         dt_proc_release(dtp, P);
+#else
+        RT_NOREF2(dtp, data);
 #endif
 }
@@ -575 +582 @@
                                 }
 
-                                if (j == cpu) {
+                                if ((unsigned)j == cpu) {
                                         bcopy(&addr[rec->dtrd_offset],
                                             percpu[j], rec->dtrd_size);
@@ -816 +823 @@
         caddr_t ldata = lh->dtahe_data.dtada_data;
         caddr_t rdata = rh->dtahe_data.dtada_data;
-        dtrace_recdesc_t *lrec, *rrec;
+        dtrace_recdesc_t *lrec VBDTMSC(NULL), *rrec VBDTMSC(NULL);
         int64_t *laddr, *raddr;
         int rval, i;
@@ -1377 +1384 @@
 {
         dt_aggregate_t *agp = &dtp->dt_aggregate;
-        dt_ahashent_t *h, **sorted = NULL, ***bundle, **nbundle;
+        dt_ahashent_t *h, **sorted = NULL, ***bundle VBDTMSC(NULL), **nbundle;
         const dtrace_aggdata_t **data;
         dt_ahashent_t *zaggdata = NULL;

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dt_as.c

@@ -83 +83 @@
 {
         size_t *np = data;
+        RT_NOREF1(dhp);
 
         if (idp->di_flags & (DT_IDFLG_DIFR | DT_IDFLG_DIFW))
@@ -98 +99 @@
         ssize_t stroff;
         dt_node_t dn;
+        RT_NOREF1(dhp);
 
         if (!(idp->di_flags & (DT_IDFLG_DIFR | DT_IDFLG_DIFW)))

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dt_cc.c

@@ -139 +139 @@
 dt_idreset(dt_idhash_t *dhp, dt_ident_t *idp, void *ignored)
 {
+        RT_NOREF2(dhp, ignored);
         idp->di_flags &= ~(DT_IDFLG_REF | DT_IDFLG_MOD |
             DT_IDFLG_DIFR | DT_IDFLG_DIFW);
@@ -148 +149 @@
 dt_idpragma(dt_idhash_t *dhp, dt_ident_t *idp, void *ignored)
 {
+        RT_NOREF2(dhp, ignored);
         yylineno = idp->di_lineno;
         xyerror(D_PRAGMA_UNUSED, "unused #pragma %s\n", (char *)idp->di_iarg);
@@ -858 +860 @@
     dt_node_t *dnp, dtrace_actkind_t kind)
 {
+        RT_NOREF1(dtp);
         assert(kind == DTRACEACT_SYM || kind == DTRACEACT_MOD ||
             kind == DTRACEACT_USYM || kind == DTRACEACT_UMOD ||
@@ -881 +884 @@
 {
         dtrace_actdesc_t *ap = dt_stmt_action(dtp, sdp);
+        RT_NOREF1(dnp);
 
         /*
@@ -897 +901 @@
 {
         dtrace_actdesc_t *ap = dt_stmt_action(dtp, sdp);
+        RT_NOREF1(dnp);
 
         ap->dtad_kind = DTRACEACT_STOP;
@@ -907 +912 @@
 {
         dtrace_actdesc_t *ap = dt_stmt_action(dtp, sdp);
+        RT_NOREF1(dnp);
 
         ap->dtad_kind = DTRACEACT_BREAKPOINT;
@@ -917 +923 @@
 {
         dtrace_actdesc_t *ap = dt_stmt_action(dtp, sdp);
+        RT_NOREF1(dnp);
 
         ap->dtad_kind = DTRACEACT_PANIC;
@@ -1095 +1102 @@
         dt_node_t *anp, *incr = NULL;
         dtrace_actdesc_t *ap;
-        uint_t n = 1, argmax;
+        uint_t n = 1, argmax VBDTMSC(0);
         uint64_t arg = 0;
 
@@ -1730 +1737 @@
         (void) fclose(ofp);
         return (NULL);
+
 #else  /* VBOX */
+        RT_NOREF1(ifp);
         (void) dt_set_errno(dtp, EDT_CPPERR);
         return (NULL);
@@ -1991 +2000 @@
                 struct FakeDirEntry {
                         const char *d_name;
-                } FakeDirEntry = { DirEntry.szName }, *dp = &FakeDirEntry;
+                } FakeDirEntry, *dp = &FakeDirEntry;
+                FakeDirEntry.d_name = DirEntry.szName;
 #endif
                 if ((p = strrchr(dp->d_name, '.')) == NULL || strcmp(p, ".d"))

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dtrace.h

@@ -154 +154 @@
         void *dtsd_aggdata;                     /* aggregation data */
         void *dtsd_fmtdata;                     /* type-specific output data */
-        void (*dtsd_callback)();                /* callback function for EPID */
+        void (*dtsd_callback)(void);            /* callback function for EPID */
         void *dtsd_data;                        /* callback data pointer */
         dtrace_attribute_t dtsd_descattr;       /* probedesc attributes */