Changeset 62840 in vbox for trunk/src/VBox

Timestamp:

Aug 1, 2016 5:15:19 PM (8 years ago)

Author:

vboxsync

Message:

Debugger: warnings

Location:

trunk/src/VBox/Debugger

Files:

• DBGPlugInCommonELFTmpl.cpp.h (modified) (1 diff)
• DBGPlugInLinux.cpp (modified) (13 diffs)
• DBGPlugInOS2.cpp (modified) (6 diffs)
• DBGPlugInSolaris.cpp (modified) (7 diffs)
• DBGPlugInWinNt.cpp (modified) (5 diffs)

trunk/src/VBox/Debugger/DBGPlugInCommonELFTmpl.cpp.h

@@ -251 +251 @@
     {
         /* Add the segments and fill in the translation table. */
-        RTGCPTR uRvaNext = 0;
         for (unsigned i = 0; i < cSegs; i++)
             if (paShdrs[i].sh_flags & SHF_ALLOC)

trunk/src/VBox/Debugger/DBGPlugInLinux.cpp

@@ -372 +372 @@
         bool fRet = false;
         DISSTATE DisState;
-        unsigned idxAddressesUsed = 0;
+        unsigned cAddressesUsed = 0;
         struct { size_t cb; RTGCPTR GCPtrOrigSrc; } aAddresses[5];
         RT_ZERO(DisState);
@@ -420 +420 @@
                             {
                                 RTGCPTR GCPtrLogBuf = 0;
-                                size_t cbLogBuf = 0;
+                                uint32_t cbLogBuf = 0;
 
                                 /*
@@ -427 +427 @@
                                  * For the log size look for the biggest non kernel address.
                                  */
-                                for (unsigned i = 0; i < idxAddressesUsed; i++)
+                                for (unsigned i = 0; i < cAddressesUsed; i++)
                                 {
                                     DBGFADDRESS AddrVal;
@@ -514 +514 @@
                                         AssertMsgFailedBreakStmt(("Invalid displacement\n"), rc = VERR_INVALID_STATE);
 
-                                    if (idxAddressesUsed < RT_ELEMENTS(aAddresses))
+                                    if (cAddressesUsed < RT_ELEMENTS(aAddresses))
                                     {
                                         /* movsxd reads always 32bits. */
                                         if (DisState.pCurInstr->uOpcode == OP_MOVSXD)
-                                            aAddresses[idxAddressesUsed].cb = sizeof(uint32_t);
+                                            aAddresses[cAddressesUsed].cb = sizeof(uint32_t);
                                         else
-                                            aAddresses[idxAddressesUsed].cb = DisState.Param2.cb;
-                                        aAddresses[idxAddressesUsed].GCPtrOrigSrc = GCPtrVal;
-                                        idxAddressesUsed++;
+                                            aAddresses[cAddressesUsed].cb = DisState.Param2.cb;
+                                        aAddresses[cAddressesUsed].GCPtrOrigSrc = GCPtrVal;
+                                        cAddressesUsed++;
                                     }
                                     else
@@ -564 +564 @@
     int rc = VINF_SUCCESS;
 
-    struct { void *pvVar; size_t cbHost, cbGuest; const char *pszSymbol; } aSymbols[] =
+    struct { void *pvVar; uint32_t cbHost, cbGuest; const char *pszSymbol; } aSymbols[] =
     {
         { pGCPtrLogBuf, sizeof(RTGCPTR),  pThis->f64Bit ? sizeof(uint64_t) : sizeof(uint32_t), "log_buf_addr_get" },
@@ -574 +574 @@
         Assert(aSymbols[i].cbHost >= aSymbols[i].cbGuest);
         rc = dbgDiggerLinuxDisassembleSimpleGetter(pThis, pUVM, hMod, aSymbols[i].pszSymbol,
-                                                   aSymbols[i].pvVar,  aSymbols[i].cbGuest);
+                                                   aSymbols[i].pvVar, aSymbols[i].cbGuest);
     }
 
@@ -622 +622 @@
                                              char *pszBuf, size_t cbBuf, size_t *pcbActual)
 {
+    RT_NOREF2(fFlags, cMessages);
     int rc = VINF_SUCCESS;
     RTGCPTR  GCPtrLogBuf;
@@ -735 +736 @@
                                                char *pszBuf, size_t cbBuf, size_t *pcbActual)
 {
+    RT_NOREF1(fFlags);
     int rc = VINF_SUCCESS;
     RTGCPTR  GCPtrLogBuf;
@@ -1048 +1050 @@
 static DECLCALLBACK(void *) dbgDiggerLinuxQueryInterface(PUVM pUVM, void *pvData, DBGFOSINTERFACE enmIf)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERLINUX pThis = (PDBGDIGGERLINUX)pvData;
     switch (enmIf)
@@ -1093 +1096 @@
 static DECLCALLBACK(void)  dbgDiggerLinuxTerm(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERLINUX pThis = (PDBGDIGGERLINUX)pvData;
     Assert(pThis->fValid);
@@ -1729 +1733 @@
  * @param   cbNeedle            Size of the needle in bytes.
  */
-static int dbgDiggerLinuxFindSymbolTableFromNeedle(PDBGDIGGERLINUX pThis, PUVM pUVM, uint8_t const *pabNeedle, size_t cbNeedle)
+static int dbgDiggerLinuxFindSymbolTableFromNeedle(PDBGDIGGERLINUX pThis, PUVM pUVM, uint8_t const *pabNeedle, uint8_t cbNeedle)
 {
     int rc = VINF_SUCCESS;
@@ -2275 +2279 @@
 static DECLCALLBACK(void)  dbgDiggerLinuxDestruct(PUVM pUVM, void *pvData)
 {
-
+    RT_NOREF2(pUVM, pvData);
 }
 
@@ -2284 +2288 @@
 static DECLCALLBACK(int)  dbgDiggerLinuxConstruct(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERLINUX pThis = (PDBGDIGGERLINUX)pvData;
     pThis->IDmesg.u32Magic = DBGFOSIDMESG_MAGIC;

trunk/src/VBox/Debugger/DBGPlugInOS2.cpp

@@ -110 +110 @@
                                      uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF7(pThis, pUVM, pszName, pImageAddr, cbImage, pbBuf, cbBuf);
     LogFlow(("DigOS2: %RGp %#x %s\n", pImageAddr->FlatPtr, cbImage, pszName));
 
@@ -121 +122 @@
 static DECLCALLBACK(void *) dbgDiggerOS2QueryInterface(PUVM pUVM, void *pvData, DBGFOSINTERFACE enmIf)
 {
+    RT_NOREF3(pUVM, pvData, enmIf);
     return NULL;
 }
@@ -130 +132 @@
 static DECLCALLBACK(int)  dbgDiggerOS2QueryVersion(PUVM pUVM, void *pvData, char *pszVersion, size_t cchVersion)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGEROS2 pThis = (PDBGDIGGEROS2)pvData;
     Assert(pThis->fValid);
@@ -174 +177 @@
 static DECLCALLBACK(void)  dbgDiggerOS2Term(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGEROS2 pThis = (PDBGDIGGEROS2)pvData;
     Assert(pThis->fValid);
@@ -321 +325 @@
 static DECLCALLBACK(void)  dbgDiggerOS2Destruct(PUVM pUVM, void *pvData)
 {
-
+    RT_NOREF2(pUVM, pvData);
 }
 
@@ -330 +334 @@
 static DECLCALLBACK(int)  dbgDiggerOS2Construct(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGEROS2 pThis = (PDBGDIGGEROS2)pvData;
     pThis->fValid = false;

trunk/src/VBox/Debugger/DBGPlugInSolaris.cpp

@@ -359 +359 @@
 static DECLCALLBACK(void *) dbgDiggerSolarisQueryInterface(PUVM pUVM, void *pvData, DBGFOSINTERFACE enmIf)
 {
+    RT_NOREF3(pUVM, pvData, enmIf);
     return NULL;
 }
@@ -374 +375 @@
      * It's all in the utsname symbol...
      */
+    SOL_utsname_t UtsName;
+    RT_ZERO(UtsName);                   /* Make MSC happy. */
     DBGFADDRESS Addr;
-    SOL_utsname_t UtsName;
     RTDBGSYMBOL SymUtsName;
     int rc = DBGFR3AsSymbolByName(pUVM, DBGF_AS_KERNEL, "utsname", &SymUtsName, NULL);
@@ -429 +431 @@
 static void dbgDiggerSolarisProcessModCtl32(PUVM pUVM, PDBGDIGGERSOLARIS pThis, SOL_modctl_t const *pModCtl)
 {
+    RT_NOREF1(pThis);
+
     /* skip it if it's not loaded and installed */
     AssertCompile2MemberOffsets(SOL_modctl_t, v11_32.mod_loaded,    v9_32.mod_loaded);
@@ -576 +580 @@
 static void dbgDiggerSolarisProcessModCtl64(PUVM pUVM, PDBGDIGGERSOLARIS pThis, SOL_modctl_t const *pModCtl)
 {
+    RT_NOREF1(pThis);
+
     /* skip it if it's not loaded and installed */
     AssertCompile2MemberOffsets(SOL_modctl_t, v11_64.mod_loaded,    v9_64.mod_loaded);
@@ -718 +724 @@
 static DECLCALLBACK(void)  dbgDiggerSolarisTerm(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERSOLARIS pThis = (PDBGDIGGERSOLARIS)pvData;
     Assert(pThis->fValid);
@@ -1087 +1094 @@
 static DECLCALLBACK(void)  dbgDiggerSolarisDestruct(PUVM pUVM, void *pvData)
 {
+    RT_NOREF2(pUVM, pvData);
 
 }
@@ -1096 +1104 @@
 static DECLCALLBACK(int)  dbgDiggerSolarisConstruct(PUVM pUVM, void *pvData)
 {
+    RT_NOREF2(pUVM, pvData);
     return VINF_SUCCESS;
 }

trunk/src/VBox/Debugger/DBGPlugInWinNt.cpp

@@ -723 +723 @@
 static DECLCALLBACK(void *) dbgDiggerWinNtQueryInterface(PUVM pUVM, void *pvData, DBGFOSINTERFACE enmIf)
 {
+    RT_NOREF3(pUVM, pvData, enmIf);
     return NULL;
 }
@@ -732 +733 @@
 static DECLCALLBACK(int)  dbgDiggerWinNtQueryVersion(PUVM pUVM, void *pvData, char *pszVersion, size_t cchVersion)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERWINNT pThis = (PDBGDIGGERWINNT)pvData;
     Assert(pThis->fValid);
@@ -753 +755 @@
 static DECLCALLBACK(void)  dbgDiggerWinNtTerm(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERWINNT pThis = (PDBGDIGGERWINNT)pvData;
     Assert(pThis->fValid);
@@ -1146 +1149 @@
 static DECLCALLBACK(void)  dbgDiggerWinNtDestruct(PUVM pUVM, void *pvData)
 {
-
+    RT_NOREF2(pUVM, pvData);
 }
 
@@ -1155 +1158 @@
 static DECLCALLBACK(int)  dbgDiggerWinNtConstruct(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERWINNT pThis = (PDBGDIGGERWINNT)pvData;
     pThis->fValid = false;