Changeset 62882 in vbox for trunk/src

Timestamp:

Aug 2, 2016 3:31:02 PM (9 years ago)

Author:

vboxsync

Message:

Additions/common: gcc warnings.

Location:

trunk/src/VBox/Additions/common

Files:

• VBoxGuestLib/VBoxGuestR3LibAdditions.cpp (modified) (1 diff)
• VBoxGuestLib/VBoxGuestR3LibDaemonize.cpp (modified) (1 diff)
• VBoxService/VBoxServiceAutoMount.cpp (modified) (1 diff)
• VBoxService/VBoxServiceControl.cpp (modified) (1 diff)
• VBoxService/VBoxServiceControlProcess.cpp (modified) (6 diffs)
• pam/pam_vbox.cpp (modified) (10 diffs)

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibAdditions.cpp

@@ -317 +317 @@
     /** @todo implement me */
     rc = VERR_NOT_IMPLEMENTED;
+    RT_NOREF1(ppszPath);
 #endif
     return rc;

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibDaemonize.cpp

@@ -200 +200 @@
 
     if (!fNoChDir)
-        chdir("/");
+    {
+        int rcShutUpGcc = chdir("/");
+        RT_NOREF_PV(rcShutUpGcc);
+    }
 
     /*

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceAutoMount.cpp

@@ -322 +322 @@
         unsigned long fFlags = MS_NODEV;
 
-        const char *szOptions = { "rw" };
+        /*const char *szOptions = { "rw" }; - ??? */
         struct vbsf_mount_info_new mntinf;
 

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControl.cpp

@@ -78 +78 @@
 /** The guest control service client ID. */
 static uint32_t             g_uControlSvcClientID = 0;
+#if 0 /** @todo process limit */
 /** How many started guest processes are kept into memory for supplying
  *  information to the host. Default is 256 processes. If 0 is specified,
  *  the maximum number of processes is unlimited. */
 static uint32_t             g_uControlProcsMaxKept = 256;
+#endif
 /** List of guest control session threads (VBOXSERVICECTRLSESSIONTHREAD).
  *  A guest session thread represents a forked guest session process

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlProcess.cpp

@@ -50 +50 @@
 static int                  vgsvcGstCtrlProcessAssignPID(PVBOXSERVICECTRLPROCESS pThread, uint32_t uPID);
 static int                  vgsvcGstCtrlProcessLock(PVBOXSERVICECTRLPROCESS pProcess);
-static int                  vgsvcGstCtrlProcessRequest(PVBOXSERVICECTRLPROCESS pProcess, const PVBGLR3GUESTCTRLCMDCTX pHostCtx,
-                                                       PFNRT pfnFunction, unsigned cArgs, ...);
 static int                  vgsvcGstCtrlProcessSetupPipe(const char *pszHowTo, int fd, PRTHANDLE ph, PRTHANDLE *pph,
                                                          PRTPIPE phPipe);
@@ -304 +302 @@
 
 
+#ifdef DEBUG
 /**
  * Names a poll handle ID.
@@ -330 +329 @@
     }
 }
+#endif /* DEBUG */
 
 
@@ -847 +847 @@
 
 
+#if 0 /* unused */
 /**
  * Initializes a pipe's handle and pipe object.
@@ -865 +866 @@
     return VINF_SUCCESS;
 }
+#endif
 
 
@@ -1215 +1217 @@
                                             PRTPROCESS phProcess)
 {
+#ifndef RT_OS_WINDOWS
+    RT_NOREF1(pszDomain);
+#endif
     AssertPtrReturn(pszExec, VERR_INVALID_PARAMETER);
     AssertPtrReturn(papszArgs, VERR_INVALID_PARAMETER);

trunk/src/VBox/Additions/common/pam/pam_vbox.cpp

@@ -120 +120 @@
 static void pam_vbox_error(pam_handle_t *hPAM, const char *pszFormat, ...)
 {
+    RT_NOREF1(hPAM);
     va_list va;
     char *buf;
@@ -141 +142 @@
 static void pam_vbox_log(pam_handle_t *hPAM, const char *pszFormat, ...)
 {
+    RT_NOREF1(hPAM);
     if (g_verbosity)
     {
@@ -305 +307 @@
 static void pam_vbox_shutdown(pam_handle_t *hPAM)
 {
+    RT_NOREF1(hPAM);
     VbglR3Term();
 }
@@ -552 +555 @@
  *
  * @return  IPRT status code.
- * @param   ThreadSelf              Thread struct to this thread.
+ * @param   hThreadSelf             Thread handle.
  * @param   pvUser                  Pointer to a PAMVBOXTHREAD structure providing
  *                                  required data used / set by the thread.
  */
-static DECLCALLBACK(int) pam_vbox_wait_thread(RTTHREAD ThreadSelf, void *pvUser)
-{
+static DECLCALLBACK(int) pam_vbox_wait_thread(RTTHREAD hThreadSelf, void *pvUser)
+{
+    RT_NOREF1(hThreadSelf);
     PPAMVBOXTHREAD pUserData = (PPAMVBOXTHREAD)pvUser;
     AssertPtr(pUserData);
@@ -677 +681 @@
 static int pam_vbox_wait_for_creds(pam_handle_t *hPAM, uint32_t uClientID, uint32_t uTimeoutMS)
 {
+    RT_NOREF1(uClientID);
     PAMVBOXTHREAD threadData;
     threadData.hPAM = hPAM;
@@ -702 +707 @@
 
 
-DECLEXPORT(int) pam_sm_authenticate(pam_handle_t *hPAM, int iFlags,
-                                    int argc, const char **argv)
-{
+DECLEXPORT(int) pam_sm_authenticate(pam_handle_t *hPAM, int iFlags, int argc, const char **argv)
+{
+    RT_NOREF1(iFlags);
+
     /* Parse arguments. */
     for (int i = 0; i < argc; i++)
@@ -848 +854 @@
 DECLEXPORT(int) pam_sm_acct_mgmt(pam_handle_t *hPAM, int iFlags, int argc, const char **argv)
 {
+    RT_NOREF3(iFlags, argc, argv);
     pam_vbox_log(hPAM, "pam_vbox_acct_mgmt called\n");
     return PAM_SUCCESS;
@@ -855 +862 @@
 DECLEXPORT(int) pam_sm_open_session(pam_handle_t *hPAM, int iFlags, int argc, const char **argv)
 {
+    RT_NOREF3(iFlags, argc, argv);
     pam_vbox_log(hPAM, "pam_vbox_open_session called\n");
     RTPrintf("This session was provided by VirtualBox Guest Additions. Have a lot of fun!\n");
@@ -863 +871 @@
 DECLEXPORT(int) pam_sm_close_session(pam_handle_t *hPAM, int iFlags, int argc, const char **argv)
 {
+    RT_NOREF3(iFlags, argc, argv);
     pam_vbox_log(hPAM, "pam_vbox_close_session called\n");
     return PAM_SUCCESS;
@@ -870 +879 @@
 DECLEXPORT(int) pam_sm_chauthtok(pam_handle_t *hPAM, int iFlags, int argc, const char **argv)
 {
+    RT_NOREF3(iFlags, argc, argv);
     pam_vbox_log(hPAM, "pam_vbox_sm_chauthtok called\n");
     return PAM_SUCCESS;