Changeset 62889 in vbox for trunk

Timestamp:

Aug 2, 2016 10:34:46 PM (8 years ago)

Author:

vboxsync

Message:

Devices: warnings

Location:

trunk/src/VBox/Devices

Files:

• Bus/DevPCI.cpp (modified) (1 diff)
• Bus/DevPciIch9.cpp (modified) (1 diff)
• Graphics/DevVGA.cpp (modified) (2 diffs)
• Input/DevPS2.cpp (modified) (1 diff)
• PC/DevPit-i8254.cpp (modified) (6 diffs)
• Storage/DevATA.cpp (modified) (14 diffs)

trunk/src/VBox/Devices/Bus/DevPCI.cpp

@@ -1290 +1290 @@
     SSMR3PutS32(pSSM, pThis->acpi_irq);
 
-    SSMR3PutU32(pSSM, ~0);        /* separator */
+    SSMR3PutU32(pSSM, UINT32_MAX);      /* separator */
 
     /*

trunk/src/VBox/Devices/Bus/DevPciIch9.cpp

@@ -1147 +1147 @@
         SSMR3PutU32(pSSM, pThis->uaPciApicIrqLevels[i]);
 
-    SSMR3PutU32(pSSM, ~0);        /* separator */
+    SSMR3PutU32(pSSM, UINT32_MAX);  /* separator */
 
     return ich9pciR3CommonSaveExec(&pThis->aPciBus, pSSM);

trunk/src/VBox/Devices/Graphics/DevVGA.cpp

@@ -1870 +1870 @@
          chars */
         if (pThis->cursor_offset < CH_ATTR_SIZE)
-            pThis->last_ch_attr[pThis->cursor_offset] = ~0;
+            pThis->last_ch_attr[pThis->cursor_offset] = UINT32_MAX;
         if (cursor_offset < CH_ATTR_SIZE)
-            pThis->last_ch_attr[cursor_offset] = ~0;
+            pThis->last_ch_attr[cursor_offset] = UINT32_MAX;
         pThis->cursor_offset = cursor_offset;
         pThis->cursor_start = pThis->cr[0xa];
@@ -4595 +4595 @@
             return VERR_PDM_NO_SUCH_LUN;
     }
-
-    return VERR_PDM_LUN_NOT_FOUND;
 }
 

trunk/src/VBox/Devices/Input/DevPS2.cpp

@@ -518 +518 @@
 
     /* terminator */
-    SSMR3PutU32(pSSM, ~0);
+    SSMR3PutU32(pSSM, UINT32_MAX);
 }
 

trunk/src/VBox/Devices/PC/DevPit-i8254.cpp

@@ -586 +586 @@
     int64_t expire_time;
     int irq_level;
-    PTMTIMER pTimer = pChan->CTX_SUFF(pPit)->channels[0].CTX_SUFF(pTimer);
-    Assert(TMTimerIsLockOwner(pTimer));
+    Assert(TMTimerIsLockOwner(pChan->CTX_SUFF(pPit)->channels[0].CTX_SUFF(pTimer)));
 
     if (!pChan->CTX_SUFF(pTimer))
@@ -822 +821 @@
          */
         PPITCHANNEL pChan = &pThis->channels[Port];
-        uint8_t const write_state = pChan->write_state;
         DEVPIT_LOCK_BOTH_RETURN(pThis, VINF_IOM_R3_IOPORT_WRITE);
         switch (pChan->write_state)
@@ -900 +898 @@
 PDMBOTHCBDECL(int) pitIOPortSpeakerWrite(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT Port, uint32_t u32, unsigned cb)
 {
-    NOREF(pvUser);
+    RT_NOREF2(pvUser, Port);
     if (cb == 1)
     {
@@ -995 +993 @@
 static DECLCALLBACK(int) pitLiveExec(PPDMDEVINS pDevIns, PSSMHANDLE pSSM, uint32_t uPass)
 {
+    RT_NOREF1(uPass);
     PPITSTATE pThis = PDMINS_2_DATA(pDevIns, PPITSTATE);
     SSMR3PutIOPort(pSSM, pThis->IOPortBaseCfg);
@@ -1164 +1163 @@
 static DECLCALLBACK(void) pitInfo(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
+    RT_NOREF1(pszArgs);
     PPITSTATE   pThis = PDMINS_2_DATA(pDevIns, PPITSTATE);
     unsigned    i;
@@ -1236 +1236 @@
 static DECLCALLBACK(void) pitRelocate(PPDMDEVINS pDevIns, RTGCINTPTR offDelta)
 {
+    RT_NOREF1(offDelta);
     PPITSTATE pThis = PDMINS_2_DATA(pDevIns, PPITSTATE);
     LogFlow(("pitRelocate: \n"));

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -2509 +2509 @@
 static uint32_t atapiR3GetConfigurationFillFeatureListProfiles(ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 3*4)
         return 0;
@@ -2527 +2528 @@
 static uint32_t atapiR3GetConfigurationFillFeatureCore(ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 12)
         return 0;
@@ -2542 +2544 @@
 static uint32_t atapiR3GetConfigurationFillFeatureMorphing(ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 8)
         return 0;
@@ -2556 +2559 @@
 static uint32_t atapiR3GetConfigurationFillFeatureRemovableMedium(ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 8)
         return 0;
@@ -2571 +2575 @@
 static uint32_t atapiR3GetConfigurationFillFeatureRandomReadable (ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 12)
         return 0;
@@ -2587 +2592 @@
 static uint32_t atapiR3GetConfigurationFillFeatureCDRead(ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 8)
         return 0;
@@ -2601 +2607 @@
 static uint32_t atapiR3GetConfigurationFillFeaturePowerManagement(ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 4)
         return 0;
@@ -2613 +2620 @@
 static uint32_t atapiR3GetConfigurationFillFeatureTimeout(ATADevState *s, uint8_t *pbBuf, size_t cbBuf)
 {
+    RT_NOREF1(s);
     if (cbBuf < 8)
         return 0;
@@ -5268 +5276 @@
             cbBuffer = pCtl->cbRedoDMABuffer;
             fLastDesc = pCtl->fRedoDMALastDesc;
+            DMADesc.pBuffer = DMADesc.cbBuffer = 0; /* Shut up MSC. */
         }
         else
@@ -5432 +5441 @@
  * which is what's there now.
  */
-static DECLCALLBACK(int) ataR3AsyncIOThread(RTTHREAD ThreadSelf, void *pvUser)
-{
+static DECLCALLBACK(int) ataR3AsyncIOThread(RTTHREAD hThreadSelf, void *pvUser)
+{
+    RT_NOREF1(hThreadSelf);
     const ATARequest *pReq;
     uint64_t        u64TS = 0; /* shut up gcc */
@@ -6110 +6120 @@
                                               RTGCPHYS GCPhysAddress, uint32_t cb, PCIADDRESSSPACE enmType)
 {
+    RT_NOREF1(cb);
     PCIATAState *pThis = PCIDEV_2_PCIATASTATE(pPciDev);
     int         rc = VINF_SUCCESS;
@@ -6678 +6689 @@
 static DECLCALLBACK(int) ataR3SaveLoadPrep(PPDMDEVINS pDevIns, PSSMHANDLE pSSM)
 {
-    PCIATAState    *pThis = PDMINS_2_DATA(pDevIns, PCIATAState *);
+    RT_NOREF1(pSSM);
+    PCIATAState *pThis = PDMINS_2_DATA(pDevIns, PCIATAState *);
 
     /* sanity - the suspend notification will wait on the async stuff. */
@@ -6693 +6705 @@
 static DECLCALLBACK(int) ataR3LiveExec(PPDMDEVINS pDevIns, PSSMHANDLE pSSM, uint32_t uPass)
 {
-    PCIATAState    *pThis = PDMINS_2_DATA(pDevIns, PCIATAState *);
+    RT_NOREF1(uPass);
+    PCIATAState *pThis = PDMINS_2_DATA(pDevIns, PCIATAState *);
 
     SSMR3PutU8(pSSM, pThis->u8Type);
@@ -6789 +6802 @@
     }
 
-    return SSMR3PutU32(pSSM, ~0); /* sanity/terminator */
+    return SSMR3PutU32(pSSM, UINT32_MAX); /* sanity/terminator */
 }