Changeset 62890 in vbox for trunk/src/VBox/Devices/PC

Timestamp:

Aug 2, 2016 11:51:30 PM (8 years ago)

Author:

vboxsync

Message:

Devices: warnings

Location:

trunk/src/VBox/Devices/PC

Files:

• ACPI/VBoxAcpi.cpp (modified) (2 diffs)
• DevACPI.cpp (modified) (2 diffs)
• DevFwCommon.cpp (modified) (1 diff)
• DevPIC.cpp (modified) (2 diffs)
• DevPcArch.cpp (modified) (2 diffs)
• DevPcBios.cpp (modified) (7 diffs)
• DevPit-i8254.cpp (modified) (1 diff)
• DevRTC.cpp (modified) (9 diffs)

trunk/src/VBox/Devices/PC/ACPI/VBoxAcpi.cpp

@@ -391 +391 @@
 
 /** No docs, lazy coder. */
-int acpiCleanupDsdt(PPDMDEVINS pDevIns,  void *pvPtr)
+int acpiCleanupDsdt(PPDMDEVINS pDevIns, void *pvPtr)
 {
 #ifdef VBOX_WITH_DYNAMIC_DSDT
     return cleanupDynamicDsdt(pDevIns, pvPtr);
 #else
+    RT_NOREF1(pDevIns);
     if (pvPtr)
         RTMemFree(pvPtr);
@@ -458 +459 @@
 int acpiCleanupSsdt(PPDMDEVINS pDevIns, void *pvPtr)
 {
+    RT_NOREF1(pDevIns);
     if (pvPtr)
         RTMemFree(pvPtr);

trunk/src/VBox/Devices/PC/DevACPI.cpp

@@ -2159 +2159 @@
 PDMBOTHCBDECL(int) acpiR3SMBusRead(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT Port, uint32_t *pu32, unsigned cb)
 {
+    RT_NOREF1(pDevIns);
     ACPIState *pThis = (ACPIState *)pvUser;
     DEVACPI_LOCK_R3(pThis);
@@ -3431 +3432 @@
 static DECLCALLBACK(void) acpiR3MemSetup(PPDMDEVINS pDevIns, PDMDEVMEMSETUPCTX enmCtx)
 {
+    RT_NOREF1(enmCtx);
     ACPIState *pThis = PDMINS_2_DATA(pDevIns, ACPIState *);
     acpiR3PlantTables(pThis);

trunk/src/VBox/Devices/PC/DevFwCommon.cpp

@@ -1014 +1014 @@
 void FwCommonPlantMpsTable(PPDMDEVINS pDevIns, uint8_t *pTable, unsigned cbMax, uint16_t cCpus)
 {
+    RT_NOREF1(cbMax);
+
     /* configuration table */
     PMPSCFGTBLHEADER pCfgTab      = (MPSCFGTBLHEADER*)pTable;

trunk/src/VBox/Devices/PC/DevPIC.cpp

@@ -883 +883 @@
 static DECLCALLBACK(void) picRelocate(PPDMDEVINS pDevIns, RTGCINTPTR offDelta)
 {
+    RT_NOREF1(offDelta);
     PDEVPIC         pThis = PDMINS_2_DATA(pDevIns, PDEVPIC);
     unsigned        i;
@@ -898 +899 @@
 static DECLCALLBACK(int)  picConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
 {
+    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
+    RT_NOREF1(iInstance);
     PDEVPIC         pThis = PDMINS_2_DATA(pDevIns, PDEVPIC);
     int             rc;

trunk/src/VBox/Devices/PC/DevPcArch.cpp

@@ -146 +146 @@
 pcarchIOPortPS2SysControlPortARead(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT Port, uint32_t *pu32, unsigned cb)
 {
+    RT_NOREF1(pvUser);
     if (cb == 1)
     {
@@ -189 +190 @@
 static DECLCALLBACK(int)  pcarchConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
 {
+    RT_NOREF1(iInstance);
+    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
     PDEVPCARCH  pThis = PDMINS_2_DATA(pDevIns, PDEVPCARCH);
     int         rc;

trunk/src/VBox/Devices/PC/DevPcBios.cpp

@@ -227 +227 @@
 static DECLCALLBACK(int) pcbiosIOPortRead(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT Port, uint32_t *pu32, unsigned cb)
 {
+    RT_NOREF5(pDevIns, pvUser, Port, pu32, cb);
     return VERR_IOM_IOPORT_UNUSED;
 }
@@ -236 +237 @@
 static DECLCALLBACK(int) pcbiosIOPortWrite(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT Port, uint32_t u32, unsigned cb)
 {
+    RT_NOREF1(pvUser);
+
     /*
      * Bochs BIOS char printing.
@@ -337 +340 @@
 static DECLCALLBACK(bool) pcbiosFw_IsHardReset(PPDMDEVINS pDevIns, uint32_t fFlags)
 {
+    RT_NOREF1(fFlags);
     PDEVPCBIOS pThis = PDMINS_2_DATA(pDevIns, PDEVPCBIOS);
     if (pThis->fCheckShutdownStatusForSoftReset)
@@ -466 +470 @@
 static int setLogicalDiskGeometry(PPDMIBASE pBase, PPDMIMEDIA pHardDisk, PPDMMEDIAGEOMETRY pLCHSGeometry)
 {
+    RT_NOREF1(pBase);
+
     PDMMEDIAGEOMETRY LCHSGeometry;
-    int rc = VINF_SUCCESS;
-
-    rc = pHardDisk->pfnBiosGetLCHSGeometry(pHardDisk, &LCHSGeometry);
+    int rc = pHardDisk->pfnBiosGetLCHSGeometry(pHardDisk, &LCHSGeometry);
     if (   rc == VERR_PDM_GEOMETRY_NOT_SET
         || LCHSGeometry.cCylinders == 0
@@ -927 +931 @@
 static DECLCALLBACK(void) pcbiosMemSetup(PPDMDEVINS pDevIns, PDMDEVMEMSETUPCTX enmCtx)
 {
-    PDEVPCBIOS  pThis = PDMINS_2_DATA(pDevIns, PDEVPCBIOS);
+    RT_NOREF1(enmCtx);
+    PDEVPCBIOS pThis = PDMINS_2_DATA(pDevIns, PDEVPCBIOS);
     LogFlow(("pcbiosMemSetup:\n"));
 
@@ -1075 +1080 @@
 static DECLCALLBACK(int)  pcbiosConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
 {
+    RT_NOREF1(iInstance);
     PDEVPCBIOS  pThis = PDMINS_2_DATA(pDevIns, PDEVPCBIOS);
     int         rc;
@@ -1564 +1570 @@
         const uint8_t  *pu8LanBootBinary = NULL;
         uint64_t        cbLanBootBinary;
-        uint64_t        cbFileLanBoot;
+        uint64_t        cbFileLanBoot = 0;
 
         /*

trunk/src/VBox/Devices/PC/DevPit-i8254.cpp

@@ -1143 +1143 @@
 static DECLCALLBACK(void) pitTimer(PPDMDEVINS pDevIns, PTMTIMER pTimer, void *pvUser)
 {
+    RT_NOREF1(pDevIns);
     PPITCHANNEL pChan = (PPITCHANNEL)pvUser;
     STAM_PROFILE_ADV_START(&pChan->CTX_SUFF(pPit)->StatPITHandler, a);

trunk/src/VBox/Devices/PC/DevRTC.cpp

@@ -478 +478 @@
 static DECLCALLBACK(void) rtcCmosBankInfo(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
+    RT_NOREF1(pszArgs);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
 
@@ -502 +503 @@
 static DECLCALLBACK(void) rtcCmosBank2Info(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
+    RT_NOREF1(pszArgs);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
 
@@ -524 +526 @@
 static DECLCALLBACK(void) rtcCmosClockInfo(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
+    RT_NOREF1(pszArgs);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
     uint8_t u8Sec   = from_bcd(pThis, pThis->cmos_data[RTC_SECONDS]);
@@ -551 +554 @@
 static DECLCALLBACK(void) rtcTimerPeriodic(PPDMDEVINS pDevIns, PTMTIMER pTimer, void *pvUser)
 {
+    RT_NOREF2(pTimer, pvUser);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
     Assert(TMTimerIsLockOwner(pThis->CTX_SUFF(pPeriodicTimer)));
@@ -632 +636 @@
 static DECLCALLBACK(void) rtcTimerSecond(PPDMDEVINS pDevIns, PTMTIMER pTimer, void *pvUser)
 {
+    RT_NOREF2(pTimer, pvUser);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
     Assert(TMTimerIsLockOwner(pThis->CTX_SUFF(pPeriodicTimer)));
@@ -692 +697 @@
 static DECLCALLBACK(void) rtcTimerSecond2(PPDMDEVINS pDevIns, PTMTIMER pTimer, void *pvUser)
 {
+    RT_NOREF2(pTimer, pvUser);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
     Assert(TMTimerIsLockOwner(pThis->CTX_SUFF(pPeriodicTimer)));
@@ -739 +745 @@
 static DECLCALLBACK(int) rtcLiveExec(PPDMDEVINS pDevIns, PSSMHANDLE pSSM, uint32_t uPass)
 {
+    RT_NOREF1(uPass);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
 
@@ -1038 +1045 @@
 static DECLCALLBACK(void) rtcRelocate(PPDMDEVINS pDevIns, RTGCINTPTR offDelta)
 {
+    RT_NOREF1(offDelta);
     PRTCSTATE pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
 
@@ -1065 +1073 @@
 static DECLCALLBACK(int)  rtcConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
 {
+    RT_NOREF1(iInstance);
+    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
     PRTCSTATE   pThis = PDMINS_2_DATA(pDevIns, PRTCSTATE);
     int         rc;