VirtualBox

Changeset 62903 in vbox for trunk/src/VBox/Devices/PC


Ignore:
Timestamp:
Aug 3, 2016 11:03:45 AM (9 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
109504
Message:

Devices: warnings

Location:
trunk/src/VBox/Devices/PC
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Devices/PC/DevDMA.cpp

    r62509 r62903  
    209209#define GET_MODE_XTYP(c)(((c) & 0x0c) >> 2)
    210210
     211
    211212/* Perform a master clear (reset) on a DMA controller. */
    212213static void dmaClear(DMAControl *dc)
     
    217218    dc->u8ModeCtr = 0;
    218219    dc->fHiByte   = false;
    219     dc->u8Mask    = ~0;
    220 }
    221 
    222 /* Read the byte pointer and flip it. */
    223 static inline bool dmaReadBytePtr(DMAControl *dc)
     220    dc->u8Mask    = UINT8_MAX;
     221}
     222
     223
     224/** Read the byte pointer and flip it. */
     225DECLINLINE(bool) dmaReadBytePtr(DMAControl *dc)
    224226{
    225227    bool    bHighByte;
     
    230232}
    231233
     234
    232235/* DMA address registers writes and reads. */
    233236
     237/**
     238 * @callback_method_impl{FNIOMIOPORTOUT, Ports 0-7 & 0xc0-0xcf}
     239 */
    234240static DECLCALLBACK(int) dmaWriteAddr(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t u32, unsigned cb)
    235241{
     242    RT_NOREF(pDevIns);
    236243    if (cb == 1)
    237244    {
     
    276283}
    277284
     285
     286/**
     287 * @callback_method_impl{FNIOMIOPORTIN, Ports 0-7 & 0xc0-0xcf}
     288 */
    278289static DECLCALLBACK(int) dmaReadAddr(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t *pu32, unsigned cb)
    279290{
     291    RT_NOREF(pDevIns);
    280292    if (cb == 1)
    281293    {
     
    301313        return VINF_SUCCESS;
    302314    }
    303     else
    304         return VERR_IOM_IOPORT_UNUSED;
     315    return VERR_IOM_IOPORT_UNUSED;
    305316}
    306317
    307318/* DMA control registers writes and reads. */
    308319
    309 static DECLCALLBACK(int) dmaWriteCtl(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port,
    310                                      uint32_t u32, unsigned cb)
    311 {
     320/**
     321 * @callback_method_impl{FNIOMIOPORTOUT, Ports 0x8-0xf & 0xd0-0xdf}
     322 */
     323static DECLCALLBACK(int) dmaWriteCtl(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t u32, unsigned cb)
     324{
     325    RT_NOREF(pDevIns);
    312326    if (cb == 1)
    313327    {
     
    387401}
    388402
     403
     404/**
     405 * @callback_method_impl{FNIOMIOPORTIN, Ports 0x8-0xf & 0xd0-0xdf}
     406 */
    389407static DECLCALLBACK(int) dmaReadCtl(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t *pu32, unsigned cb)
    390408{
     409    RT_NOREF(pDevIns);
    391410    if (cb == 1)
    392411    {
     
    438457}
    439458
    440 /** DMA page registers. There are 16 R/W page registers for compatibility with
    441  * the IBM PC/AT; only some of those registers are used for DMA. The page register
    442  * accessible via port 80h may be read to insert small delays or used as a scratch
    443  * register by a BIOS.
     459/**
     460 */
     461
     462/**
     463 * @callback_method_impl{FNIOMIOPORTIN,
     464 *          DMA page registers - Ports 0x80-0x87 & 0x88-0x8f}
     465 *
     466 * There are 16 R/W page registers for compatibility with the IBM PC/AT; only
     467 * some of those registers are used for DMA. The page register accessible via
     468 * port 80h may be read to insert small delays or used as a scratch register by
     469 * a BIOS.
    444470 */
    445471static DECLCALLBACK(int) dmaReadPage(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t *pu32, unsigned cb)
    446472{
     473    RT_NOREF(pDevIns);
    447474    DMAControl  *dc = (DMAControl *)pvUser;
    448475    int         reg;
     
    469496}
    470497
     498
     499/**
     500 * @callback_method_impl{FNIOMIOPORTOUT,
     501 *      DMA page registers - Ports 0x80-0x87 & 0x88-0x8f}
     502 */
    471503static DECLCALLBACK(int) dmaWritePage(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t u32, unsigned cb)
    472504{
     505    RT_NOREF(pDevIns);
    473506    DMAControl  *dc = (DMAControl *)pvUser;
    474507    int         reg;
     
    502535}
    503536
    504 /**
    505  * EISA style high page registers, for extending the DMA addresses to cover
    506  * the entire 32-bit address space.
     537
     538/**
     539 * @callback_method_impl{FNIOMIOPORTIN,
     540 *      EISA style high page registers, for extending the DMA addresses to cover
     541 *      the entire 32-bit address space.  Ports 0x480-0x487 & 0x488-0x48f}
    507542 */
    508543static DECLCALLBACK(int) dmaReadHiPage(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t *pu32, unsigned cb)
    509544{
     545    RT_NOREF(pDevIns);
    510546    if (cb == 1)
    511547    {
     
    522558}
    523559
     560
     561/**
     562 * @callback_method_impl{FNIOMIOPORTOUT, Ports 0x480-0x487 & 0x488-0x48f}
     563 */
    524564static DECLCALLBACK(int) dmaWriteHiPage(PPDMDEVINS pDevIns, void *pvUser, RTIOPORT port, uint32_t u32, unsigned cb)
    525565{
     566    RT_NOREF(pDevIns);
    526567    if (cb == 1)
    527568    {
     
    938979static DECLCALLBACK(int) dmaConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    939980{
    940     DMAState    *pThis = PDMINS_2_DATA(pDevIns, DMAState *);
    941     bool        bHighPage = false;
    942     PDMDMACREG  reg;
    943     int         rc;
    944 
     981    RT_NOREF(iInstance);
     982    DMAState *pThis = PDMINS_2_DATA(pDevIns, DMAState *);
     983
     984    /*
     985     * Initialize data.
     986     */
    945987    pThis->pDevIns = pDevIns;
    946988
     
    951993        return VERR_PDM_DEVINS_UNKNOWN_CFG_VALUES;
    952994
     995    bool        bHighPage = false;
    953996#if 0
    954997    rc = CFGMR3QueryBool(pCfg, "HighPageEnable", &bHighPage);
     
    9601003    dmaReset(pDevIns);
    9611004
    962     reg.u32Version        = PDM_DMACREG_VERSION;
    963     reg.pfnRun            = dmaRun;
    964     reg.pfnRegister       = dmaRegister;
    965     reg.pfnReadMemory     = dmaReadMemory;
    966     reg.pfnWriteMemory    = dmaWriteMemory;
    967     reg.pfnSetDREQ        = dmaSetDREQ;
    968     reg.pfnGetChannelMode = dmaGetChannelMode;
    969 
    970     rc = PDMDevHlpDMACRegister(pDevIns, &reg, &pThis->pHlp);
     1005    PDMDMACREG Reg;
     1006    Reg.u32Version        = PDM_DMACREG_VERSION;
     1007    Reg.pfnRun            = dmaRun;
     1008    Reg.pfnRegister       = dmaRegister;
     1009    Reg.pfnReadMemory     = dmaReadMemory;
     1010    Reg.pfnWriteMemory    = dmaWriteMemory;
     1011    Reg.pfnSetDREQ        = dmaSetDREQ;
     1012    Reg.pfnGetChannelMode = dmaGetChannelMode;
     1013
     1014    int rc = PDMDevHlpDMACRegister(pDevIns, &Reg, &pThis->pHlp);
    9711015    if (RT_FAILURE (rc))
    9721016        return rc;
  • trunk/src/VBox/Devices/PC/DevHPET.cpp

    r62509 r62903  
    13081308static DECLCALLBACK(int) hpetR3Construct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    13091309{
     1310    RT_NOREF(iInstance);
    13101311    PDMDEV_CHECK_VERSIONS_RETURN(pDevIns);
    13111312    HPET   *pThis = PDMINS_2_DATA(pDevIns, HPET *);
  • trunk/src/VBox/Devices/PC/DevIoApic.cpp

    r62610 r62903  
    843843
    844844#ifdef IN_RING3
     845
    845846/** @interface_method_impl{DBGFREGDESC,pfnGet} */
    846847static DECLCALLBACK(int) ioapicDbgReg_GetIndex(void *pvUser, PCDBGFREGDESC pDesc, PDBGFREGVAL pValue)
    847848{
     849    RT_NOREF(pDesc);
    848850    pValue->u32 = ioapicGetIndex(PDMINS_2_DATA((PPDMDEVINS)pvUser, PCIOAPIC));
    849851    return VINF_SUCCESS;
    850852}
    851853
     854
    852855/** @interface_method_impl{DBGFREGDESC,pfnSet} */
    853856static DECLCALLBACK(int) ioapicDbgReg_SetIndex(void *pvUser, PCDBGFREGDESC pDesc, PCDBGFREGVAL pValue, PCDBGFREGVAL pfMask)
    854857{
     858    RT_NOREF(pDesc, pfMask);
    855859    ioapicSetIndex(PDMINS_2_DATA((PPDMDEVINS)pvUser, PIOAPIC), pValue->u8);
    856860    return VINF_SUCCESS;
    857861}
    858862
     863
    859864/** @interface_method_impl{DBGFREGDESC,pfnGet} */
    860865static DECLCALLBACK(int) ioapicDbgReg_GetData(void *pvUser, PCDBGFREGDESC pDesc, PDBGFREGVAL pValue)
    861866{
     867    RT_NOREF(pDesc);
    862868    pValue->u32 = ioapicGetData((PDMINS_2_DATA((PPDMDEVINS)pvUser, PCIOAPIC)));
    863869    return VINF_SUCCESS;
    864870}
    865871
     872
    866873/** @interface_method_impl{DBGFREGDESC,pfnSet} */
    867874static DECLCALLBACK(int) ioapicDbgReg_SetData(void *pvUser, PCDBGFREGDESC pDesc, PCDBGFREGVAL pValue, PCDBGFREGVAL pfMask)
    868875{
     876    RT_NOREF(pDesc, pfMask);
    869877     return ioapicSetData(PDMINS_2_DATA((PPDMDEVINS)pvUser, PIOAPIC), pValue->u32);
    870878}
     879
    871880
    872881/** @interface_method_impl{DBGFREGDESC,pfnGet} */
    873882static DECLCALLBACK(int) ioapicDbgReg_GetVersion(void *pvUser, PCDBGFREGDESC pDesc, PDBGFREGVAL pValue)
    874883{
     884    RT_NOREF(pvUser, pDesc);
    875885    pValue->u32 = ioapicGetVersion();
    876886    return VINF_SUCCESS;
    877887}
    878888
     889
    879890/** @interface_method_impl{DBGFREGDESC,pfnGet} */
    880891static DECLCALLBACK(int) ioapicDbgReg_GetArb(void *pvUser, PCDBGFREGDESC pDesc, PDBGFREGVAL pValue)
    881892{
    882 #if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_82093AA
     893    RT_NOREF(pvUser, pDesc);
     894# if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_82093AA
    883895    pValue->u32 = ioapicGetArb(PDMINS_2_DATA((PPDMDEVINS)pvUser, PCIOAPIC));
    884 #else
     896# else
    885897    pValue->u32 = UINT32_C(0xffffffff);
    886 #endif
     898# endif
    887899    return VINF_SUCCESS;
    888900}
     901
    889902
    890903/** @interface_method_impl{DBGFREGDESC,pfnGet} */
     
    897910}
    898911
     912
    899913/** @interface_method_impl{DBGFREGDESC,pfnSet} */
    900914static DECLCALLBACK(int) ioapicDbgReg_SetRte(void *pvUser, PCDBGFREGDESC pDesc, PCDBGFREGVAL pValue, PCDBGFREGVAL pfMask)
    901915{
     916    RT_NOREF(pfMask);
    902917    PIOAPIC pThis = PDMINS_2_DATA((PPDMDEVINS)pvUser, PIOAPIC);
    903918    /* No locks, no checks, just do it. */
     
    906921    return VINF_SUCCESS;
    907922}
     923
    908924
    909925/** IOREDTBLn sub fields. */
     
    918934    { "trigger_mode", 15,  1,  0,  0, NULL, NULL },
    919935    { "mask",         16,  1,  0,  0, NULL, NULL },
    920 #if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_ICH9
     936# if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_ICH9
    921937    { "ext_dest_id",  48,  8,  0,  DBGFREGSUBFIELD_FLAGS_READ_ONLY, NULL, NULL },
    922 #endif
     938# endif
    923939    { "dest",         56,  8,  0,  0, NULL, NULL },
    924940    DBGFREGSUBFIELD_TERMINATOR()
    925941};
    926942
     943
    927944/** Register descriptors for DBGF. */
    928945static DBGFREGDESC const g_aRegDesc[] =
     
    931948    { "data",       DBGFREG_END, DBGFREGVALTYPE_U32, 0,  0, ioapicDbgReg_GetData,  ioapicDbgReg_SetData,     NULL, NULL },
    932949    { "version",    DBGFREG_END, DBGFREGVALTYPE_U32, DBGFREG_FLAGS_READ_ONLY, 0, ioapicDbgReg_GetVersion, NULL, NULL, NULL },
    933 #if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_82093AA
     950# if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_82093AA
    934951    { "arb",        DBGFREG_END, DBGFREGVALTYPE_U32, DBGFREG_FLAGS_READ_ONLY, 0, ioapicDbgReg_GetArb,     NULL, NULL, NULL },
    935 #endif
     952# endif
    936953    { "rte0",       DBGFREG_END, DBGFREGVALTYPE_U64, 0,  0, ioapicDbgReg_GetRte, ioapicDbgReg_SetRte, NULL, &g_aRteSubs[0] },
    937954    { "rte1",       DBGFREG_END, DBGFREGVALTYPE_U64, 0,  1, ioapicDbgReg_GetRte, ioapicDbgReg_SetRte, NULL, &g_aRteSubs[0] },
     
    967984static DECLCALLBACK(void) ioapicR3DbgInfo(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
    968985{
     986    RT_NOREF(pszArgs);
    969987    PCIOAPIC pThis = PDMINS_2_DATA(pDevIns, PIOAPIC);
    970988    LogFlow(("IOAPIC: ioapicR3DbgInfo: pThis=%p pszArgs=%s\n", pThis, pszArgs));
     
    9821000    pHlp->pfnPrintf(pHlp, "    Max. Redirection Entry  = %u\n",      IOAPIC_VER_GET_MRE(uVer));
    9831001
    984 #if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_82093AA
     1002# if IOAPIC_HARDWARE_VERSION == IOAPIC_HARDWARE_VERSION_82093AA
    9851003    uint32_t const uArb = ioapicGetArb();
    9861004    pHlp->pfnPrintf(pHlp, "  Arbitration             = %#RX32\n", uArb);
    9871005    pHlp->pfnPrintf(pHlp, "    Arbitration ID          = %#x\n",     IOAPIC_ARB_GET_ID(uArb));
    988 #endif
     1006# endif
    9891007
    9901008    pHlp->pfnPrintf(pHlp, "  Current index           = %#x\n",     ioapicGetIndex(pThis));
     
    11161134static DECLCALLBACK(void) ioapicR3Relocate(PPDMDEVINS pDevIns, RTGCINTPTR offDelta)
    11171135{
     1136    RT_NOREF(offDelta);
    11181137    PIOAPIC pThis = PDMINS_2_DATA(pDevIns, PIOAPIC);
    11191138    LogFlow(("IOAPIC: ioapicR3Relocate: pThis=%p offDelta=%RGi\n", pThis, offDelta));
     
    11331152    PDMDEV_CHECK_VERSIONS_RETURN_QUIET(pDevIns);
    11341153
    1135 #ifndef IOAPIC_WITH_PDM_CRITSECT
     1154# ifndef IOAPIC_WITH_PDM_CRITSECT
    11361155    /*
    11371156     * Destroy the RTE critical section.
     
    11391158    if (PDMCritSectIsInitialized(&pThis->CritSect))
    11401159        PDMR3CritSectDelete(&pThis->CritSect);
    1141 #endif
     1160# else
     1161    RT_NOREF_PV(pThis);
     1162# endif
    11421163
    11431164    return VINF_SUCCESS;
     
    11501171static DECLCALLBACK(int) ioapicR3Construct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
    11511172{
     1173    RT_NOREF(iInstance);
    11521174    PIOAPIC pThis = PDMINS_2_DATA(pDevIns, PIOAPIC);
    11531175    LogFlow(("IOAPIC: ioapicR3Construct: pThis=%p iInstance=%d\n", pThis, iInstance));
     
    11881210    AssertRCReturn(rc, rc);
    11891211
    1190 #ifndef IOAPIC_WITH_PDM_CRITSECT
     1212# ifndef IOAPIC_WITH_PDM_CRITSECT
    11911213    /*
    11921214     * Setup the critical section to protect concurrent writes to the RTEs.
     
    11951217    if (RT_FAILURE(rc))
    11961218        return PDMDevHlpVMSetError(pDevIns, rc, RT_SRC_POS, N_("IOAPIC: Failed to create critical section. rc=%Rrc"), rc);
    1197 #endif
     1219# endif
    11981220
    11991221    /*
     
    12731295    AssertRCReturn(rc, rc);
    12741296
    1275 #ifdef VBOX_WITH_STATISTICS
     1297# ifdef VBOX_WITH_STATISTICS
    12761298    /*
    12771299     * Statistics.
     
    12961318    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatLevelIrqSent, STAMTYPE_COUNTER, "/Devices/IOAPIC/LevelIntr/Sent", STAMUNIT_OCCURENCES, "Number of level-triggered interrupts sent to the local APIC(s).");
    12971319    PDMDevHlpSTAMRegister(pDevIns, &pThis->StatEoiReceived,  STAMTYPE_COUNTER, "/Devices/IOAPIC/LevelIntr/Recv", STAMUNIT_OCCURENCES, "Number of EOIs received for level-triggered interrupts from the local APIC(s).");
    1298 #endif
     1320# endif
    12991321
    13001322    /*
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette