Changeset 62906 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Aug 3, 2016 11:20:21 AM (8 years ago)

Author:

vboxsync

Message:

Devices: warnings

Location:

trunk/src/VBox/Devices/Network

Files:

• DrvDedicatedNic.cpp (modified) (6 diffs)
• DrvIntNet.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Network/DrvDedicatedNic.cpp

@@ -302 +302 @@
 
 #else  /* IN_RING3 */
+    NOREF(fOnWorkerThread);
+
     /*
      * Call ring-0 to start the transfer.
@@ -399 +401 @@
 {
     LogFlow(("drvR3DedicatedNicPowerOff\n"));
-    PDRVDEDICATEDNIC pThis = PDMINS_2_DATA(pDrvIns, PDRVDEDICATEDNIC);
-
     int rc = PDMDrvHlpCallR0(pDrvIns, DRVDEDICATEDNICR0OP_SUSPEND, 0);
     AssertRC(rc);
@@ -412 +412 @@
 {
     LogFlow(("drvR3DedicatedNicPowerResume\n"));
-    PDRVDEDICATEDNIC pThis = PDMINS_2_DATA(pDrvIns, PDRVDEDICATEDNIC);
-
     int rc = PDMDrvHlpCallR0(pDrvIns, DRVDEDICATEDNICR0OP_RESUME, 0);
     AssertRC(rc);
@@ -425 +423 @@
 {
     LogFlow(("drvR3DedicatedNicPowerSuspend\n"));
-    PDRVDEDICATEDNIC pThis = PDMINS_2_DATA(pDrvIns, PDRVDEDICATEDNIC);
-
     int rc = PDMDrvHlpCallR0(pDrvIns, DRVDEDICATEDNICR0OP_SUSPEND, 0);
     AssertRC(rc);
@@ -438 +434 @@
 {
     LogFlow(("drvR3DedicatedNicPowerOn\n"));
-    PDRVDEDICATEDNIC pThis = PDMINS_2_DATA(pDrvIns, PDRVDEDICATEDNIC);
-
     int rc = PDMDrvHlpCallR0(pDrvIns, DRVDEDICATEDNICR0OP_RESUME, 0);
     AssertRC(rc);
@@ -467 +461 @@
 static DECLCALLBACK(int) drvR3DedicatedNicConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(pCfg, fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVDEDICATEDNIC pThis = PDMINS_2_DATA(pDrvIns, PDRVDEDICATEDNIC);
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
     /*

trunk/src/VBox/Devices/Network/DrvIntNet.cpp

@@ -642 +642 @@
 static DECLCALLBACK(int) drvR3IntNetXmitWakeUp(PPDMDRVINS pDrvIns, PPDMTHREAD pThread)
 {
+    RT_NOREF(pThread);
     PDRVINTNET pThis = PDMINS_2_DATA(pDrvIns, PDRVINTNET);
     return SUPSemEventSignal(pThis->pSupDrvSession, pThis->hXmitEvt);
@@ -872 +873 @@
  *
  * @returns VINF_SUCCESS (ignored).
- * @param   ThreadSelf      Thread handle.
+ * @param   hThreadSelf     Thread handle.
  * @param   pvUser          Pointer to a DRVINTNET structure.
  */
-static DECLCALLBACK(int) drvR3IntNetRecvThread(RTTHREAD ThreadSelf, void *pvUser)
-{
+static DECLCALLBACK(int) drvR3IntNetRecvThread(RTTHREAD hThreadSelf, void *pvUser)
+{
+    RT_NOREF(hThreadSelf);
     PDRVINTNET pThis = (PDRVINTNET)pvUser;
     LogFlow(("drvR3IntNetRecvThread: pThis=%p\n", pThis));
@@ -934 +936 @@
 #if 0
     PDMIBASERC_RETURN_INTERFACE(pThis->pDrvInsR3, pszIID, PDMINETWORKUP, &pThis->INetworkUpRC);
+#else
+    RT_NOREF(pThis, pszIID);
 #endif
     return NIL_RTRCPTR;
@@ -1149 +1153 @@
 {
     /* nothing to do here yet */
+    RT_NOREF(pDrvIns, offDelta);
 }
 
@@ -1186 +1191 @@
         AbortWaitReq.fNoMoreWaits = true;
         int rc = PDMDrvHlpSUPCallVMMR0Ex(pDrvIns, VMMR0_DO_INTNET_IF_ABORT_WAIT, &AbortWaitReq, sizeof(AbortWaitReq));
-        AssertMsg(RT_SUCCESS(rc) || rc == VERR_SEM_DESTROYED, ("%Rrc\n", rc));
+        AssertMsg(RT_SUCCESS(rc) || rc == VERR_SEM_DESTROYED, ("%Rrc\n", rc)); RT_NOREF_PV(rc);
     }
 
@@ -1347 +1352 @@
 static DECLCALLBACK(int) drvR3IntNetConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVINTNET pThis = PDMINS_2_DATA(pDrvIns, PDRVINTNET);
     bool f;
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
     /*