Changeset 62908 in vbox for trunk

Timestamp:

Aug 3, 2016 11:33:27 AM (8 years ago)

Author:

vboxsync

Message:

Devices: warnings

Location:

trunk/src/VBox/Devices

Files:

• PC/DrvACPI.cpp (modified) (9 diffs)
• PC/DrvAcpiCpu.cpp (modified) (1 diff)
• Serial/DrvChar.cpp (modified) (7 diffs)
• Serial/DrvNamedPipe.cpp (modified) (2 diffs)
• Serial/DrvRawFile.cpp (modified) (1 diff)
• Serial/DrvTCP.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/PC/DrvACPI.cpp

@@ -127 +127 @@
 {
 #if defined(RT_OS_WINDOWS)
+    RT_NOREF(pInterface);
     SYSTEM_POWER_STATUS powerStatus;
     if (GetSystemPowerStatus(&powerStatus))
@@ -163 +164 @@
 
 #elif defined (RT_OS_DARWIN)
+    RT_NOREF(pInterface);
     *pPowerSource = PDM_ACPI_POWER_SOURCE_UNKNOWN;
 
@@ -204 +206 @@
 
 #elif defined(RT_OS_FREEBSD)
+    RT_NOREF(pInterface);
     int fAcLine = 0;
     size_t cbParameter = sizeof(fAcLine);
@@ -224 +227 @@
     }
 #else /* !RT_OS_FREEBSD either - what could this be? */
+    RT_NOREF(pInterface);
     *pPowerSource = PDM_ACPI_POWER_SOURCE_OUTLET;
 
@@ -239 +243 @@
 {
     /* default return values for all architectures */
-    *pfPresent              = false;   /* no battery present */
+    *pfPresent              = false;        /* no battery present */
     *penmBatteryState       = PDM_ACPI_BAT_STATE_CHARGED;
     *penmRemainingCapacity  = PDM_ACPI_BAT_CAPACITY_UNKNOWN;
-    *pu32PresentRate        = ~0;      /* present rate is unknown */
+    *pu32PresentRate        = UINT32_MAX;   /* present rate is unknown */
 
 #if defined(RT_OS_WINDOWS)
+    RT_NOREF(pInterface);
     SYSTEM_POWER_STATUS powerStatus;
     if (GetSystemPowerStatus(&powerStatus))
@@ -280 +285 @@
 
 #elif defined(RT_OS_DARWIN)
+    RT_NOREF(pInterface);
     CFTypeRef pBlob = IOPSCopyPowerSourcesInfo();
     CFArrayRef pSources = IOPSCopyPowerSourcesList(pBlob);
@@ -384 +390 @@
 
 #elif defined(RT_OS_FREEBSD)
+    RT_NOREF(pInterface);
     /* We try to use /dev/acpi first and if that fails use the sysctls. */
     bool fSuccess = true;
@@ -947 +954 @@
 static DECLCALLBACK(void) drvACPIDestruct(PPDMDRVINS pDrvIns)
 {
-    PDRVACPI pThis = PDMINS_2_DATA(pDrvIns, PDRVACPI);
-
     LogFlow(("drvACPIDestruct\n"));
     PDMDRV_CHECK_VERSIONS_RETURN_VOID(pDrvIns);
 
 #ifdef RT_OS_LINUX
+    PDRVACPI pThis = PDMINS_2_DATA(pDrvIns, PDRVACPI);
     if (pThis->hPollerSleepEvent != NIL_RTSEMEVENT)
     {
@@ -969 +975 @@
 static DECLCALLBACK(int) drvACPIConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVACPI pThis = PDMINS_2_DATA(pDrvIns, PDRVACPI);
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     int rc = VINF_SUCCESS;
 

trunk/src/VBox/Devices/PC/DrvAcpiCpu.cpp

@@ -48 +48 @@
 static DECLCALLBACK(int) drvACPICpuConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
     PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 

trunk/src/VBox/Devices/Serial/DrvChar.cpp

@@ -103 +103 @@
 /* -=-=-=-=- ICharConnector -=-=-=-=- */
 
-/** @copydoc PDMICHARCONNECTOR::pfnWrite */
+/**
+ * @interface_method_impl{PDMICHARCONNECTOR,pfnWrite}
+ */
 static DECLCALLBACK(int) drvCharWrite(PPDMICHARCONNECTOR pInterface, const void *pvBuf, size_t cbWrite)
 {
@@ -123 +125 @@
 }
 
-/** @copydoc PDMICHARCONNECTOR::pfnSetParameters */
-static DECLCALLBACK(int) drvCharSetParameters(PPDMICHARCONNECTOR pInterface, unsigned Bps, char chParity, unsigned cDataBits, unsigned cStopBits)
-{
+
+/**
+ * @interface_method_impl{PDMICHARCONNECTOR,pfnSetParameters}
+ */
+static DECLCALLBACK(int) drvCharSetParameters(PPDMICHARCONNECTOR pInterface, unsigned Bps, char chParity,
+                                              unsigned cDataBits,  unsigned cStopBits)
+{
+    RT_NOREF(pInterface, Bps, chParity, cDataBits, cStopBits);
     /*PDRVCHAR pThis = PDMICHAR_2_DRVCHAR(pInterface); - unused*/
 
@@ -139 +146 @@
  *
  * @returns 0 on success.
- * @param   ThreadSelf  Thread handle to this thread.
+ * @param   hThreadSelf Thread handle to this thread.
  * @param   pvUser      User argument.
  */
-static DECLCALLBACK(int) drvCharSendLoop(RTTHREAD ThreadSelf, void *pvUser)
-{
+static DECLCALLBACK(int) drvCharSendLoop(RTTHREAD hThreadSelf, void *pvUser)
+{
+    RT_NOREF(hThreadSelf);
     PDRVCHAR pThis = (PDRVCHAR)pvUser;
 
@@ -189 +197 @@
 }
 
+
 /* -=-=-=-=- receive thread -=-=-=-=- */
 
@@ -195 +204 @@
  *
  * @returns 0 on success.
- * @param   ThreadSelf  Thread handle to this thread.
+ * @param   hThreadSelf Thread handle to this thread.
  * @param   pvUser      User argument.
  */
-static DECLCALLBACK(int) drvCharReceiveLoop(RTTHREAD ThreadSelf, void *pvUser)
-{
+static DECLCALLBACK(int) drvCharReceiveLoop(RTTHREAD hThreadSelf, void *pvUser)
+{
+    RT_NOREF(hThreadSelf);
     PDRVCHAR    pThis = (PDRVCHAR)pvUser;
     char        abBuffer[256];
@@ -254 +264 @@
 }
 
-/**
- * Set the modem lines.
- *
- * @returns VBox status code
- * @param pInterface        Pointer to the interface structure.
- * @param RequestToSend     Set to true if this control line should be made active.
- * @param DataTerminalReady Set to true if this control line should be made active.
- */
-static DECLCALLBACK(int) drvCharSetModemLines(PPDMICHARCONNECTOR pInterface, bool RequestToSend, bool DataTerminalReady)
+
+/**
+ * @callback_method_impl{PDMICHARCONNECTOR,pfnSetModemLines}
+ */
+static DECLCALLBACK(int) drvCharSetModemLines(PPDMICHARCONNECTOR pInterface, bool fRequestToSend, bool fDataTerminalReady)
 {
     /* Nothing to do here. */
-    return VINF_SUCCESS;
-}
-
-/**
- * Sets the TD line into break condition.
- *
- * @returns VBox status code.
- * @param   pInterface  Pointer to the interface structure containing the called function pointer.
- * @param   fBreak      Set to true to let the device send a break false to put into normal operation.
- * @thread  Any thread.
+    RT_NOREF(pInterface, fRequestToSend, fDataTerminalReady);
+    return VINF_SUCCESS;
+}
+
+
+/**
+ * @callback_method_impl{PDMICHARCONNECTOR,pfnSetBreak}
  */
 static DECLCALLBACK(int) drvCharSetBreak(PPDMICHARCONNECTOR pInterface, bool fBreak)
 {
     /* Nothing to do here. */
-    return VINF_SUCCESS;
-}
+    RT_NOREF(pInterface, fBreak);
+    return VINF_SUCCESS;
+}
+
 
 /* -=-=-=-=- driver interface -=-=-=-=- */
@@ -345 +350 @@
 static DECLCALLBACK(int) drvCharConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(pCfg);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVCHAR pThis = PDMINS_2_DATA(pDrvIns, PDRVCHAR);
     LogFlow(("%s: iInstance=%d\n", __FUNCTION__, pDrvIns->iInstance));
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
     /*

trunk/src/VBox/Devices/Serial/DrvNamedPipe.cpp

@@ -297 +297 @@
  *
  * @returns 0 on success.
- * @param   ThreadSelf  Thread handle to this thread.
+ * @param   hThreadSelf Thread handle to this thread.
  * @param   pvUser      User argument.
  */
-static DECLCALLBACK(int) drvNamedPipeListenLoop(RTTHREAD ThreadSelf, void *pvUser)
-{
+static DECLCALLBACK(int) drvNamedPipeListenLoop(RTTHREAD hThreadSelf, void *pvUser)
+{
+    RT_NOREF(hThreadSelf);
     PDRVNAMEDPIPE   pThis = (PDRVNAMEDPIPE)pvUser;
     int             rc = VINF_SUCCESS;
@@ -523 +524 @@
 static DECLCALLBACK(int) drvNamedPipeConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVNAMEDPIPE pThis = PDMINS_2_DATA(pDrvIns, PDRVNAMEDPIPE);
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
     /*

trunk/src/VBox/Devices/Serial/DrvRawFile.cpp

@@ -155 +155 @@
 static DECLCALLBACK(int) drvRawFileConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVRAWFILE pThis = PDMINS_2_DATA(pDrvIns, PDRVRAWFILE);
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
     /*

trunk/src/VBox/Devices/Serial/DrvTCP.cpp

@@ -197 +197 @@
  * Receive thread loop.
  *
- * @returns 0 on success.
- * @param   ThreadSelf  Thread handle to this thread.
+ * @returns VINF_SUCCESS
+ * @param   hThreadSelf Thread handle to this thread.
  * @param   pvUser      User argument.
  */
-static DECLCALLBACK(int) drvTCPListenLoop(RTTHREAD ThreadSelf, void *pvUser)
-{
+static DECLCALLBACK(int) drvTCPListenLoop(RTTHREAD hThreadSelf, void *pvUser)
+{
+    RT_NOREF(hThreadSelf);
     PDRVTCP pThis = (PDRVTCP)pvUser;
-    int     rc = VINF_SUCCESS;
+    int     rc;
 
     while (RT_LIKELY(!pThis->fShutdown))
@@ -347 +348 @@
 static DECLCALLBACK(int) drvTCPConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVTCP pThis = PDMINS_2_DATA(pDrvIns, PDRVTCP);
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
 #ifdef RT_OS_WINDOWS