Changeset 62919 in vbox for trunk/src/VBox/GuestHost/DragAndDrop

Timestamp:

Aug 3, 2016 2:16:14 PM (8 years ago)

Author:

vboxsync

Message:

Please use 'static const' on data that is constant, don't make the compiler recreated on the stack for each call.

File:

• trunk/src/VBox/GuestHost/DragAndDrop/DnDPath.cpp (modified) (1 diff)

trunk/src/VBox/GuestHost/DragAndDrop/DnDPath.cpp

@@ -39 +39 @@
 #ifdef RT_OS_WINDOWS
     RT_NOREF1(cbPath);
-    /* Filter out characters not allowed on Windows platforms, put in by
-       RTTimeSpecToString(). */
-    /** @todo Use something like RTPathSanitize() when available. Later. */
-    static const RTUNICP s_aCpSet[] =
+    /* Replace out characters not allowed on Windows platforms, put in by RTTimeSpecToString(). */
+    /** @todo Use something like RTPathSanitize() if available later some time. */
+    static const RTUNICP s_uszValidRangePairs[] =
     {
-        ' ', ' ', '(', ')', '-', '.', '0', '9', 'A', 'Z', 'a', 'z', '_', '_',
-        0xa0, 0xd7af, '\0'
+        ' ', ' ',
+        '(', ')',
+        '-', '.',
+        '0', '9',
+        'A', 'Z',
+        'a', 'z',
+        '_', '_',
+        0xa0, 0xd7af,
+        '\0'
     };
-    ssize_t cReplaced = RTStrPurgeComplementSet(pszPath, s_aCpSet, '_' /* Replacement */);
+    ssize_t cReplaced = RTStrPurgeComplementSet(pszPath, s_uszValidRangePairs, '_' /* chReplacement */);
     if (cReplaced < 0)
         rc = VERR_INVALID_UTF8_ENCODING;