Changeset 62953 in vbox for trunk/src/VBox/Devices/USB/usbip

Timestamp:

Aug 4, 2016 7:30:48 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109556

Message:

Devices: warnings

File:

• trunk/src/VBox/Devices/USB/usbip/USBProxyDevice-usbip.cpp (modified) (14 diffs)

trunk/src/VBox/Devices/USB/usbip/USBProxyDevice-usbip.cpp

@@ -590 +590 @@
             return VERR_INVALID_STATE;
     }
-
-    LogFlowFunc(("i32Status=%d\n", i32Status));
-    return VERR_INVALID_STATE;
+    /* not reached */
 }
 
@@ -614 +612 @@
             return VUSBSTATUS_DNR;
     }
-
-    return VUSBSTATUS_DNR;
+    /* not reached */
 }
 
@@ -1316 +1313 @@
     char bRead = 0;
     size_t cbRead = 0;
-
     int rc = RTPipeRead(pProxyDevUsbIp->hPipeR, &bRead, 1, &cbRead);
-    Assert(RT_SUCCESS(rc) && cbRead == 1);
+    Assert(RT_SUCCESS(rc) && cbRead == 1); NOREF(rc);
 
     return bRead;
@@ -1327 +1323 @@
  */
 
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnOpen}
+ */
 static DECLCALLBACK(int) usbProxyUsbIpOpen(PUSBPROXYDEV pProxyDev, const char *pszAddress, void *pvBackend)
 {
+    RT_NOREF(pvBackend);
     LogFlowFunc(("pProxyDev=%p pszAddress=%s, pvBackend=%p\n", pProxyDev, pszAddress, pvBackend));
 
@@ -1387 +1387 @@
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnClose}
+ */
 static DECLCALLBACK(void) usbProxyUsbIpClose(PUSBPROXYDEV pProxyDev)
 {
@@ -1438 +1442 @@
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnReset}
+ */
 static DECLCALLBACK(int) usbProxyUsbIpReset(PUSBPROXYDEV pProxyDev, bool fResetOnLinux)
 {
@@ -1464 +1472 @@
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnSetConfig}
+ */
 static DECLCALLBACK(int) usbProxyUsbIpSetConfig(PUSBPROXYDEV pProxyDev, int iCfg)
 {
@@ -1479 +1491 @@
 }
 
-static DECLCALLBACK(int) usbProxyUsbIpClaimInterface(PUSBPROXYDEV pProxyDev, int ifnum)
-{
-    LogFlowFunc(("pProxyDev=%s ifnum=%#x\n", pProxyDev->pUsbIns->pszName, ifnum));
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnClaimInterface}
+ */
+static DECLCALLBACK(int) usbProxyUsbIpClaimInterface(PUSBPROXYDEV pProxyDev, int iIf)
+{
+    RT_NOREF(pProxyDev, iIf);
+    LogFlowFunc(("pProxyDev=%s iIf=%#x\n", pProxyDev->pUsbIns->pszName, iIf));
     return VINF_SUCCESS;
 }
 
-static DECLCALLBACK(int) usbProxyUsbIpReleaseInterface(PUSBPROXYDEV pProxyDev, int ifnum)
-{
-    LogFlowFunc(("pProxyDev=%s ifnum=%#x\n", pProxyDev->pUsbIns->pszName, ifnum));
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnReleaseInterface}
+ */
+static DECLCALLBACK(int) usbProxyUsbIpReleaseInterface(PUSBPROXYDEV pProxyDev, int iIf)
+{
+    RT_NOREF(pProxyDev, iIf);
+    LogFlowFunc(("pProxyDev=%s iIf=%#x\n", pProxyDev->pUsbIns->pszName, iIf));
     return VINF_SUCCESS;
 }
 
-static DECLCALLBACK(int) usbProxyUsbIpSetInterface(PUSBPROXYDEV pProxyDev, int ifnum, int setting)
-{
-    LogFlowFunc(("pProxyDev=%p ifnum=%#x setting=%#x\n", pProxyDev, ifnum, setting));
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnSetInterface}
+ */
+static DECLCALLBACK(int) usbProxyUsbIpSetInterface(PUSBPROXYDEV pProxyDev, int iIf, int setting)
+{
+    LogFlowFunc(("pProxyDev=%p iIf=%#x setting=%#x\n", pProxyDev, iIf, setting));
 
     PUSBPROXYDEVUSBIP pProxyDevUsbIp = USBPROXYDEV_2_DATA(pProxyDev, PUSBPROXYDEVUSBIP);
@@ -1501 +1527 @@
     Setup.bRequest      = 0x0b; /* SET_INTERFACE */
     Setup.wValue        = setting;
-    Setup.wIndex        = ifnum;
+    Setup.wIndex        = iIf;
     Setup.wLength       = 0;
     return usbProxyUsbIpCtrlUrbExchangeSync(pProxyDevUsbIp, &Setup);
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnClearHaltedEndpoint}
+ */
 static DECLCALLBACK(int) usbProxyUsbIpClearHaltedEp(PUSBPROXYDEV pProxyDev, unsigned int iEp)
 {
@@ -1521 +1551 @@
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnUrbQueue}
+ */
 static DECLCALLBACK(int) usbProxyUsbIpUrbQueue(PUSBPROXYDEV pProxyDev, PVUSBURB pUrb)
 {
@@ -1544 +1578 @@
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnUrbReap}
+ */
 static DECLCALLBACK(PVUSBURB) usbProxyUsbIpUrbReap(PUSBPROXYDEV pProxyDev, RTMSINTERVAL cMillies)
 {
@@ -1605 +1643 @@
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnUrbCancel}
+ */
 static DECLCALLBACK(int) usbProxyUsbIpUrbCancel(PUSBPROXYDEV pProxyDev, PVUSBURB pUrb)
 {
@@ -1634 +1676 @@
 }
 
+
+/**
+ * @interface_method_impl{USBPROXYBACK,pfnWakeup}
+ */
 static DECLCALLBACK(int) usbProxyUsbIpWakeup(PUSBPROXYDEV pProxyDev)
 {
@@ -1641 +1687 @@
     return usbProxyReaperKick(pProxyDevUsbIp, USBIP_REAPER_WAKEUP_REASON_EXTERNAL);
 }
+
 
 /**