Changeset 62961 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Aug 4, 2016 8:14:22 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109564

Message:

Devices: warnings

File:

• trunk/src/VBox/Devices/Network/DevINIP.cpp (modified) (8 diffs)

trunk/src/VBox/Devices/Network/DevINIP.cpp

@@ -181 +181 @@
 static err_t devINIPOutputRaw(struct netif *netif, struct pbuf *p)
 {
+    NOREF(netif);
     int rc = VINF_SUCCESS;
 
@@ -322 +323 @@
 static DECLCALLBACK(int) devINIPNetworkDown_WaitInputAvail(PPDMINETWORKDOWN pInterface, RTMSINTERVAL cMillies)
 {
+    RT_NOREF(pInterface, cMillies);
     LogFlow(("%s: pInterface=%p\n", __FUNCTION__, pInterface));
     LogFlow(("%s: return VINF_SUCCESS\n", __FUNCTION__));
@@ -337 +339 @@
 static DECLCALLBACK(int) devINIPNetworkDown_Input(PPDMINETWORKDOWN pInterface, const void *pvBuf, size_t cb)
 {
+    RT_NOREF(pInterface);
     const uint8_t *pbBuf = (const uint8_t *)pvBuf;
     size_t len = cb;
     const struct eth_hdr *ethhdr;
     struct pbuf *p, *q;
-    int rc = VINF_SUCCESS;
 
     LogFlow(("%s: pInterface=%p pvBuf=%p cb=%lu\n", __FUNCTION__, pInterface, pvBuf, cb));
@@ -350 +352 @@
     if (!g_pDevINIPData)
     {
-        LogFlow(("%s: return %Rrc (no global)\n", __FUNCTION__, rc));
+        LogFlow(("%s: return %Rrc (no global)\n", __FUNCTION__, VINF_SUCCESS));
         return VINF_SUCCESS;
     }
@@ -359 +361 @@
 
     /* We allocate a pbuf chain of pbufs from the pool. */
-    p = lwip_pbuf_alloc(PBUF_RAW, len, PBUF_POOL);
+    Assert((u16_t)len == len);
+    p = lwip_pbuf_alloc(PBUF_RAW, (u16_t)len, PBUF_POOL);
     if (p != NULL)
     {
@@ -384 +387 @@
     }
 
-    LogFlow(("%s: return %Rrc\n", __FUNCTION__, rc));
-    return rc;
+    LogFlow(("%s: return %Rrc\n", __FUNCTION__, VINF_SUCCESS));
+    return VINF_SUCCESS;
 }
 
@@ -605 +608 @@
 static DECLCALLBACK(int) devINIPConstruct(PPDMDEVINS pDevIns, int iInstance, PCFGMNODE pCfg)
 {
+    RT_NOREF(iInstance);
     PDEVINTNETIP pThis = PDMINS_2_DATA(pDevIns, PDEVINTNETIP);
-    int rc = VINF_SUCCESS;
-    err_t errRc = ERR_OK;
 
     LogFlow(("%s: pDevIns=%p iInstance=%d pCfg=%p\n", __FUNCTION__,
@@ -646 +648 @@
      * Get the configuration settings.
      */
-    rc = CFGMR3QueryBytes(pCfg, "MAC", &pThis->MAC, sizeof(pThis->MAC));
+    int rc = CFGMR3QueryBytes(pCfg, "MAC", &pThis->MAC, sizeof(pThis->MAC));
     if (rc == VERR_CFGM_NOT_BYTES)
     {