Changeset 62985 in vbox for trunk/src/VBox

Timestamp:

Aug 4, 2016 1:04:30 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109592

Message:

Devices: warnings

File:

• trunk/src/VBox/Devices/Network/DrvNAT.cpp (modified) (12 diffs)

trunk/src/VBox/Devices/Network/DrvNAT.cpp

@@ -913 +913 @@
 static DECLCALLBACK(int) drvNATAsyncIoWakeup(PPDMDRVINS pDrvIns, PPDMTHREAD pThread)
 {
+    RT_NOREF(pThread);
     PDRVNAT pThis = PDMINS_2_DATA(pDrvIns, PDRVNAT);
 
@@ -948 +949 @@
 static DECLCALLBACK(int) drvNATHostResWakeup(PPDMDRVINS pDrvIns, PPDMTHREAD pThread)
 {
+    RT_NOREF(pThread);
     PDRVNAT pThis = PDMINS_2_DATA(pDrvIns, PDRVNAT);
     Assert(pThis != NULL);
@@ -966 +968 @@
 int slirp_can_output(void *pvUser)
 {
+    RT_NOREF(pvUser);
     return 1;
 }
@@ -980 +983 @@
     PDRVNAT pThis = (PDRVNAT)pvUser;
     Assert(pThis);
-
-    PRTREQ pReq = NULL;
 
     /* don't queue new requests when the NAT thread is about to stop */
@@ -1016 +1017 @@
     LogFlow(("slirp_output BEGIN %p %d\n", pu8Buf, cb));
     Log6(("slirp_output: pu8Buf=%p cb=%#x (pThis=%p)\n%.*Rhxd\n", pu8Buf, cb, pThis, cb, pu8Buf));
-
-    PRTREQ pReq = NULL;
 
     /* don't queue new requests when the NAT thread is about to stop */
@@ -1184 +1183 @@
         pThis->pIAboveConfig->pfnGetMac(pThis->pIAboveConfig, &Mac);
     }
+#else
+    RT_NOREF(pThis);
 #endif
 }
@@ -1193 +1194 @@
  * (usually done during guest boot).
  */
-static DECLCALLBACK(int) drvNATLoadDone(PPDMDRVINS pDrvIns, PSSMHANDLE pSSMHandle)
-{
+static DECLCALLBACK(int) drvNATLoadDone(PPDMDRVINS pDrvIns, PSSMHANDLE pSSM)
+{
+    RT_NOREF(pSSM);
     PDRVNAT pThis = PDMINS_2_DATA(pDrvIns, PDRVNAT);
     drvNATSetMac(pThis);
@@ -1314 +1316 @@
 static int drvNATConstructDNSMappings(unsigned iInstance, PDRVNAT pThis, PCFGMNODE pMappingsCfg)
 {
+    RT_NOREF(iInstance);
     int rc = VINF_SUCCESS;
     LogFlowFunc(("ENTER: iInstance:%d\n", iInstance));
@@ -1339 +1342 @@
         }
         struct in_addr HostIP;
+        RT_ZERO(HostIP);
         GETIP_DEF(rc, pThis, pNode, HostIP, INADDR_ANY);
         if (rc == VERR_CFGM_VALUE_NOT_FOUND)
@@ -1361 +1365 @@
 static int drvNATConstructRedir(unsigned iInstance, PDRVNAT pThis, PCFGMNODE pCfg, PRTNETADDRIPV4 pNetwork)
 {
+    RT_NOREF(pNetwork); /** @todo figure why pNetwork isn't used */
+
     /*
      * Enumerate redirections.
@@ -1415 +1421 @@
         /* host address ("BindIP" name is rather unfortunate given "HostPort" to go with it) */
         struct in_addr BindIP;
+        RT_ZERO(BindIP);
         GETIP_DEF(rc, pThis, pNode, BindIP, INADDR_ANY);
 
         /* guest address */
         struct in_addr GuestIP;
+        RT_ZERO(GuestIP);
         GETIP_DEF(rc, pThis, pNode, GuestIP, INADDR_ANY);
 
@@ -1502 +1510 @@
 static DECLCALLBACK(int) drvNATConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVNAT pThis = PDMINS_2_DATA(pDrvIns, PDRVNAT);
     LogFlow(("drvNATConstruct:\n"));
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
     /*