Changeset 62991 in vbox

Timestamp:

Aug 4, 2016 3:04:22 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109600

Message:

Devices: warnings

File:

• trunk/src/VBox/Devices/Audio/DevIchHdaCodec.cpp (modified) (11 diffs)

trunk/src/VBox/Devices/Audio/DevIchHdaCodec.cpp

@@ -242 +242 @@
 /* Input Amplifier capabilities (7.3.4.10). */
 #define CODEC_MAKE_F00_0D(mute_cap, step_size, num_steps, offset) \
-        (  (((mute_cap)  & 0x1)  << 31)                           \
-         | (((step_size) & 0xFF) << 16)                           \
-         | (((num_steps) & 0xFF) << 8)                            \
-         |  ((offset)    & 0xFF))
+        (  (((mute_cap)  & UINT32_C(0x1))  << 31) \
+         | (((step_size) & UINT32_C(0xFF)) << 16) \
+         | (((num_steps) & UINT32_C(0xFF)) << 8) \
+         |  ((offset)    & UINT32_C(0xFF)))
 
 #define CODEC_F00_0D_CAP_MUTE                              RT_BIT(7)
@@ -307 +307 @@
 /* GPIO count (7.3.4.14). */
 #define CODEC_MAKE_F00_11(wake, unsol, numgpi, numgpo, numgpio) \
-    (  (((wake) & 0x1) << 31)                                   \
-     | (((unsol) & 0x1) << 30)                                  \
-     | (((numgpi) & 0xFF) << 16)                                \
-     | (((numgpo) & 0xFF) << 8)                                 \
-     | ((numgpio) & 0xFF))
+    (  (((wake)   & UINT32_C(0x1))  << 31) \
+     | (((unsol)  & UINT32_C(0x1))  << 30) \
+     | (((numgpi) & UINT32_C(0xFF)) << 16) \
+     | (((numgpo) & UINT32_C(0xFF)) << 8) \
+     | ((numgpio) & UINT32_C(0xFF)))
 
 /* Processing States (7.3.3.4). */
@@ -319 +319 @@
 /* Power States (7.3.3.10). */
 #define CODEC_MAKE_F05(reset, stopok, error, act, set) \
-    (   (((reset)  & 0x1) << 10)                       \
-     | (((stopok) & 0x1) << 9)                         \
-     | (((error)  & 0x1) << 8)                         \
-     | (((act)    & 0xF) << 4)                         \
+    (  (((reset)  & 0x1) << 10) \
+     | (((stopok) & 0x1) << 9) \
+     | (((error)  & 0x1) << 8) \
+     | (((act)    & 0xF) << 4) \
      | ((set)     & 0xF))
 #define CODEC_F05_D3COLD                                   (4)
@@ -378 +378 @@
 #define CODEC_MAKE_F09_ANALOG(fPresent, impedance)  \
 (  (((fPresent) & 0x1) << 31)                       \
- | (((impedance) & 0x7FFFFFFF)))
-#define CODEC_F09_ANALOG_NA    0x7FFFFFFF
+ | (((impedance) & UINT32_C(0x7FFFFFFF))))
+#define CODEC_F09_ANALOG_NA    UINT32_C(0x7FFFFFFF)
 #define CODEC_MAKE_F09_DIGITAL(fPresent, fELDValid) \
-(   (((fPresent) & 0x1) << 31)                      \
-  | (((fELDValid) & 0x1) << 30))
+(   (((fPresent)  & UINT32_C(0x1)) << 31)                      \
+  | (((fELDValid) & UINT32_C(0x1)) << 30))
 
 #define CODEC_MAKE_F0C(lrswap, eapd, btl) ((((lrswap) & 1) << 2) | (((eapd) & 1) << 1) | ((btl) & 1))
@@ -871 +871 @@
 static DECLCALLBACK(void) stac9220DbgNodes(PHDACODEC pThis, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
-    for (int i = 1; i < pThis->cTotalNodes; i++)
+    RT_NOREF(pszArgs);
+    for (uint8_t i = 1; i < pThis->cTotalNodes; i++)
     {
         PCODECNODE pNode = &pThis->paNodes[i];
@@ -1601 +1602 @@
 static DECLCALLBACK(int) vrbProcUnimplemented(PHDACODEC pThis, uint32_t cmd, uint64_t *pResp)
 {
+    RT_NOREF(pThis, cmd);
     LogFlowFunc(("cmd(raw:%x: cad:%x, d:%c, nid:%x, verb:%x)\n", cmd,
                  CODEC_CAD(cmd), CODEC_DIRECT(cmd) ? 'N' : 'Y', CODEC_NID(cmd), CODEC_VERBDATA(cmd)));
@@ -2139 +2141 @@
         return VINF_SUCCESS;
 
+    uint8_t uPwrCmd = CODEC_F05_SET      (cmd);
     bool    fReset  = CODEC_F05_IS_RESET (*pu32Reg);
     bool    fStopOk = CODEC_F05_IS_STOPOK(*pu32Reg);
+#ifdef LOG_ENABLED
     bool    fError  = CODEC_F05_IS_ERROR (*pu32Reg);
     uint8_t uPwrAct = CODEC_F05_ACT      (*pu32Reg);
     uint8_t uPwrSet = CODEC_F05_SET      (*pu32Reg);
-
-    uint8_t uPwrCmd = CODEC_F05_SET      (cmd);
-
     LogFunc(("[NID0x%02x] Cmd=D%RU8, fReset=%RTbool, fStopOk=%RTbool, fError=%RTbool, uPwrAct=D%RU8, uPwrSet=D%RU8\n",
              CODEC_NID(cmd), uPwrCmd, fReset, fStopOk, fError, uPwrAct, uPwrSet));
-
     LogFunc(("AFG: Act=D%RU8, Set=D%RU8\n",
             CODEC_F05_ACT(pThis->paNodes[STAC9220_NID_AFG].afg.u32F05_param),
             CODEC_F05_SET(pThis->paNodes[STAC9220_NID_AFG].afg.u32F05_param)));
+#endif
 
     if (CODEC_NID(cmd) == STAC9220_NID_AFG)
@@ -2486 +2487 @@
 static DECLCALLBACK(int) vrbProcGetGPIOData(PHDACODEC pThis, uint32_t cmd, uint64_t *pResp)
 {
-    *pResp = 0;
-
+    RT_NOREF(pThis, cmd);
+    *pResp = 0;
     return VINF_SUCCESS;
 }
@@ -2494 +2495 @@
 static DECLCALLBACK(int) vrbProcSetGPIOData(PHDACODEC pThis, uint32_t cmd, uint64_t *pResp)
 {
-    *pResp = 0;
-
+    RT_NOREF(pThis, cmd);
+    *pResp = 0;
     return VINF_SUCCESS;
 }
@@ -2502 +2503 @@
 static DECLCALLBACK(int) vrbProcGetGPIOEnableMask(PHDACODEC pThis, uint32_t cmd, uint64_t *pResp)
 {
-    *pResp = 0;
-
+    RT_NOREF(pThis, cmd);
+    *pResp = 0;
     return VINF_SUCCESS;
 }
@@ -2510 +2511 @@
 static DECLCALLBACK(int) vrbProcSetGPIOEnableMask(PHDACODEC pThis, uint32_t cmd, uint64_t *pResp)
 {
-    *pResp = 0;
-
+    RT_NOREF(pThis, cmd);
+    *pResp = 0;
     return VINF_SUCCESS;
 }