Changeset 63061 in vbox for trunk/src/VBox/Additions/WINNT/Graphics/Video/disp

Timestamp:

Aug 5, 2016 8:39:08 PM (8 years ago)

Author:

vboxsync

Message:

GA/NT/Graphics: warnings

Location:

trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/xpdm

Files:

• VBoxDispVHWA.cpp (modified) (1 diff)
• VBoxDispVRDP.cpp (modified) (8 diffs)

trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/xpdm/VBoxDispVHWA.cpp

@@ -199 +199 @@
     VBOXPEVENT pEvent = (VBOXPEVENT)pContext;
     LONG oldState = pDev->vpAPI.VideoPortProcs.pfnSetEvent(pDev->vpAPI.pContext, pEvent);
-    Assert(!oldState);
+    Assert(!oldState); NOREF(oldState);
 }
 

trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/xpdm/VBoxDispVRDP.cpp

@@ -982 +982 @@
                        BRUSHOBJ  *pbo, POINTL *pptlBrushOrg, LINEATTRS *plineattrs, MIX mix)
 {
+    RT_NOREF(pxo,  pptlBrushOrg);
     PVBOXDISPDEV pDev = (PVBOXDISPDEV)pso->dhpdev;
 
@@ -1061 +1062 @@
         BOOL bMore;
         VRDEORDERPOLYLINE order;
-        VRDEORDERPOINT ptStart;
+        /** @todo it is not immediately obvious how we're sure ptStart isn't used uninitialized. */
+        VRDEORDERPOINT ptStart = { 0, 0 }; /* Shut up MSC */
         VRDEORDERBOUNDS bounds;
 
@@ -1073 +1075 @@
         do {
             POINTFIX *pptfx;
-            VRDEORDERPOINT pt;
+            /** @todo it is not immediately obvious how we're sure pt isn't used uninitialized. */
+            VRDEORDERPOINT pt = {0, 0}; /* Shut up MSC */
 
             bMore = PATHOBJ_bEnum (ppo, &pd);
@@ -1167 +1170 @@
 }
 
-void vrdpDrvFillPath(SURFOBJ *pso, PATHOBJ *ppo, CLIPOBJ *pco, BRUSHOBJ *pbo, POINTL *pptlBrushOrg,
-                     MIX mix, FLONG flOptions)
-{
+void vrdpDrvFillPath(SURFOBJ *pso, PATHOBJ *ppo, CLIPOBJ *pco, BRUSHOBJ *pbo, POINTL *pptlBrushOrg, MIX mix, FLONG flOptions)
+{
+    RT_NOREF(pbo, pptlBrushOrg, mix, flOptions);
     PVBOXDISPDEV pDev = (PVBOXDISPDEV)pso->dhpdev;
     vrdpReportDirtyPath(pDev, pco, ppo);
@@ -1176 +1179 @@
 void vrdpDrvPaint(SURFOBJ *pso, CLIPOBJ *pco, BRUSHOBJ *pbo, POINTL *pptlBrushOrg, MIX mix)
 {
+    RT_NOREF(pbo, pptlBrushOrg, mix);
     PVBOXDISPDEV pDev = (PVBOXDISPDEV)pso->dhpdev;
     vrdpReportDirtyClip(pDev, pco, NULL);
 }
 
-void vrdpDrvTextOut(SURFOBJ *pso, STROBJ *pstro, FONTOBJ *pfo, CLIPOBJ *pco,
-                    RECTL *prclExtra, RECTL *prclOpaque, BRUSHOBJ *pboFore,
-                    BRUSHOBJ *pboOpaque, POINTL *pptlOrg, MIX mix)
-{
+void vrdpDrvTextOut(SURFOBJ *pso, STROBJ *pstro, FONTOBJ *pfo, CLIPOBJ *pco, RECTL *prclExtra, RECTL *prclOpaque,
+                    BRUSHOBJ *pboFore, BRUSHOBJ *pboOpaque, POINTL *pptlOrg, MIX mix)
+{
+    RT_NOREF(pptlOrg,  mix);
     PVBOXDISPDEV pDev = (PVBOXDISPDEV)pso->dhpdev;
 
@@ -1324 +1328 @@
 
 void vrdpDrvBitBlt(SURFOBJ *psoTrg, SURFOBJ *psoSrc, SURFOBJ *psoMask, CLIPOBJ *pco, XLATEOBJ *pxlo,
-                   RECTL *prclTrg, POINTL *pptlSrc, POINTL *pptlMask, BRUSHOBJ *pbo, POINTL *pptlBrush,
-                   ROP4 rop4)
-{
+                   RECTL *prclTrg, POINTL *pptlSrc, POINTL *pptlMask, BRUSHOBJ *pbo, POINTL *pptlBrush, ROP4 rop4)
+{
+    RT_NOREF(psoMask, pxlo, pptlMask);
     PVBOXDISPDEV pDev = (PVBOXDISPDEV)psoTrg->dhpdev;
 
@@ -1540 +1544 @@
 
 void vrdpDrvStretchBlt(SURFOBJ *psoDest, SURFOBJ *psoSrc, SURFOBJ *psoMask, CLIPOBJ *pco, XLATEOBJ *pxlo,
-                       COLORADJUSTMENT *pca, POINTL *pptlHTOrg, RECTL *prclDest, RECTL *prclSrc,
-                       POINTL *pptlMask, ULONG iMode)
-{
+                       COLORADJUSTMENT *pca, POINTL *pptlHTOrg, RECTL *prclDest, RECTL *prclSrc, POINTL *pptlMask, ULONG iMode)
+{
+    RT_NOREF(psoSrc, psoMask, pxlo, pca, pptlHTOrg, prclSrc, pptlMask, iMode);
     PVBOXDISPDEV pDev = (PVBOXDISPDEV)psoDest->dhpdev;
     vrdpReportDirtyClip(pDev, pco, prclDest);
@@ -1553 +1557 @@
 }
 
-BOOL vrdpDrvRealizeBrush(BRUSHOBJ *pbo, SURFOBJ *psoTarget, SURFOBJ *psoPattern, SURFOBJ *psoMask,
-                        XLATEOBJ *pxlo, ULONG iHatch)
-{
+BOOL vrdpDrvRealizeBrush(BRUSHOBJ *pbo, SURFOBJ *psoTarget, SURFOBJ *psoPattern, SURFOBJ *psoMask, XLATEOBJ *pxlo, ULONG iHatch)
+{
+    RT_NOREF(psoMask, iHatch);
     BOOL bRc = FALSE;