Changeset 63065 in vbox

Timestamp:

Aug 5, 2016 9:38:38 PM (8 years ago)

Author:

vboxsync

Message:

Additions/common: warnings

Location:

trunk/src/VBox/Additions/common

Files:

• VBoxGuest/VBoxGuest-win-legacy.cpp (modified) (1 diff)
• VBoxGuest/VBoxGuest-win.cpp (modified) (3 diffs)
• VBoxGuest/VBoxGuest-win.h (modified) (1 diff)
• VBoxService/VBoxService-win.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win-legacy.cpp

@@ -56 +56 @@
  *
  * @param   pDrvObj         The driver object.
- * @param   pDevObj         Unused. NULL. Dunno why it's here, makes no sense.
  * @param   pRegPath        The driver registry path.
  */
-NTSTATUS vgdrvNt4CreateDevice(PDRIVER_OBJECT pDrvObj, PDEVICE_OBJECT pDevObj, PUNICODE_STRING pRegPath)
+NTSTATUS vgdrvNt4CreateDevice(PDRIVER_OBJECT pDrvObj, PUNICODE_STRING pRegPath)
 {
     Log(("vgdrvNt4CreateDevice: pDrvObj=%p, pDevObj=%p, pRegPath=%p\n", pDrvObj, pDevObj, pRegPath));

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp

@@ -209 +209 @@
         pDrvObj->MajorFunction[IRP_MJ_WRITE]                   = vgdrvNtNotSupportedStub;
 #ifdef TARGET_NT4
-        rc = vgdrvNt4CreateDevice(pDrvObj, NULL /* pDevObj */, pRegPath);
+        rc = vgdrvNt4CreateDevice(pDrvObj, pRegPath);
 #else
         pDrvObj->MajorFunction[IRP_MJ_PNP]                     = vgdrvNtPnP;
@@ -468 +468 @@
         IoInitializeDpcRequest(pDevExt->pDeviceObject, vgdrvNtDpcHandler);
 #ifdef TARGET_NT4
-        ULONG uInterruptVector;
-        KIRQL irqLevel;
+        ULONG uInterruptVector = UINT32_MAX;
+        KIRQL irqLevel = UINT8_MAX;
         /* Get an interrupt vector. */
         /* Only proceed if the device provides an interrupt. */
@@ -622 +622 @@
     UNICODE_STRING DosName;
     RtlInitUnicodeString(&DosName, VBOXGUEST_DEVICE_NAME_DOS);
-    NTSTATUS rc = IoDeleteSymbolicLink(&DosName);
+    IoDeleteSymbolicLink(&DosName);
 
     IoDeleteDevice(pDrvObj->DeviceObject);

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.h

@@ -148 +148 @@
 
 #ifdef TARGET_NT4
-NTSTATUS   vgdrvNt4CreateDevice(PDRIVER_OBJECT pDrvObj, PDEVICE_OBJECT pDevObj, PUNICODE_STRING pRegPath);
+NTSTATUS   vgdrvNt4CreateDevice(PDRIVER_OBJECT pDrvObj, PUNICODE_STRING pRegPath);
 #else
 NTSTATUS   vgdrvNtPnP(PDEVICE_OBJECT pDevObj, PIRP pIrp);

trunk/src/VBox/Additions/common/VBoxService/VBoxService-win.cpp

@@ -197 +197 @@
         return RTEXITCODE_FAILURE;
     }
+#else
+    RT_NOREF(hService);
 #endif
     return RTEXITCODE_SUCCESS;