Changeset 63104 in vbox for trunk/src/VBox/Additions/WINNT/VBoxTray

Timestamp:

Aug 6, 2016 4:00:44 PM (8 years ago)

Author:

vboxsync

Message:

GA/NT/VBoxTray: warnings

Location:

trunk/src/VBox/Additions/WINNT/VBoxTray

Files:

• VBoxDnDDataObject.cpp (modified) (8 diffs)
• VBoxDnDDropTarget.cpp (modified) (4 diffs)
• VBoxLA.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDnDDataObject.cpp

@@ -208 +208 @@
         LogFlowFunc(("Waiting for event ...\n"));
         int rc2 = RTSemEventWait(mSemEvent, RT_INDEFINITE_WAIT);
-        LogFlowFunc(("rc=%Rrc, mStatus=%ld\n", rc2, mStatus));
+        LogFlowFunc(("rc2=%Rrc, mStatus=%ld\n", rc2, mStatus)); NOREF(rc2);
     }
 
@@ -441 +441 @@
 STDMETHODIMP VBoxDnDDataObject::GetDataHere(LPFORMATETC pFormatEtc, LPSTGMEDIUM pMedium)
 {
+    RT_NOREF(pFormatEtc, pMedium);
     LogFlowFunc(("\n"));
     return DATA_E_FORMATETC;
@@ -458 +459 @@
 }
 
-STDMETHODIMP VBoxDnDDataObject::GetCanonicalFormatEtc(LPFORMATETC pFormatEct, LPFORMATETC pFormatEtcOut)
-{
+STDMETHODIMP VBoxDnDDataObject::GetCanonicalFormatEtc(LPFORMATETC pFormatEtc, LPFORMATETC pFormatEtcOut)
+{
+    RT_NOREF(pFormatEtc);
     LogFlowFunc(("\n"));
 
@@ -467 +469 @@
 }
 
-STDMETHODIMP VBoxDnDDataObject::SetData(LPFORMATETC pFormatEtc, LPSTGMEDIUM pMedium,  BOOL fRelease)
-{
+STDMETHODIMP VBoxDnDDataObject::SetData(LPFORMATETC pFormatEtc, LPSTGMEDIUM pMedium, BOOL fRelease)
+{
+    RT_NOREF(pFormatEtc, pMedium, fRelease);
     return E_NOTIMPL;
 }
@@ -474 +477 @@
 STDMETHODIMP VBoxDnDDataObject::EnumFormatEtc(DWORD dwDirection, IEnumFORMATETC **ppEnumFormatEtc)
 {
-    LogFlowFunc(("dwDirection=%RI32, mcFormats=%RI32, mpFormatEtc=%p\n",
-                 dwDirection, mcFormats, mpFormatEtc));
+    LogFlowFunc(("dwDirection=%RI32, mcFormats=%RI32, mpFormatEtc=%p\n", dwDirection, mcFormats, mpFormatEtc));
 
     HRESULT hr;
     if (dwDirection == DATADIR_GET)
-    {
         hr = VBoxDnDEnumFormatEtc::CreateEnumFormatEtc(mcFormats, mpFormatEtc, ppEnumFormatEtc);
-    }
     else
         hr = E_NOTIMPL;
@@ -489 +489 @@
 }
 
-STDMETHODIMP VBoxDnDDataObject::DAdvise(LPFORMATETC pFormatEtc, DWORD advf, IAdviseSink *pAdvSink, DWORD *pdwConnection)
-{
+STDMETHODIMP VBoxDnDDataObject::DAdvise(LPFORMATETC pFormatEtc, DWORD fAdvise, IAdviseSink *pAdvSink, DWORD *pdwConnection)
+{
+    RT_NOREF(pFormatEtc, fAdvise, pAdvSink, pdwConnection);
     return OLE_E_ADVISENOTSUPPORTED;
 }
@@ -496 +497 @@
 STDMETHODIMP VBoxDnDDataObject::DUnadvise(DWORD dwConnection)
 {
+    RT_NOREF(dwConnection);
     return OLE_E_ADVISENOTSUPPORTED;
 }
@@ -501 +503 @@
 STDMETHODIMP VBoxDnDDataObject::EnumDAdvise(IEnumSTATDATA **ppEnumAdvise)
 {
+    RT_NOREF(ppEnumAdvise);
     return OLE_E_ADVISENOTSUPPORTED;
 }

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDnDDropTarget.cpp

@@ -43 +43 @@
 {
     int rc = RTSemEventCreate(&hEventDrop);
-    LogFlowFunc(("rc=%Rrc\n", rc));
+    LogFlowFunc(("rc=%Rrc\n", rc)); NOREF(rc);
 }
 
@@ -129 +129 @@
  */
 
-STDMETHODIMP VBoxDnDDropTarget::DragEnter(IDataObject *pDataObject, DWORD grfKeyState,
-                                          POINTL pt, DWORD *pdwEffect)
-{
+STDMETHODIMP VBoxDnDDropTarget::DragEnter(IDataObject *pDataObject, DWORD grfKeyState, POINTL pt, DWORD *pdwEffect)
+{
+    RT_NOREF(pt);
     AssertPtrReturn(pDataObject, E_INVALIDARG);
     AssertPtrReturn(pdwEffect, E_INVALIDARG);
@@ -229 +229 @@
 STDMETHODIMP VBoxDnDDropTarget::DragOver(DWORD grfKeyState, POINTL pt, DWORD *pdwEffect)
 {
+    RT_NOREF(pt);
     AssertPtrReturn(pdwEffect, E_INVALIDARG);
 
@@ -265 +266 @@
 }
 
-STDMETHODIMP VBoxDnDDropTarget::Drop(IDataObject *pDataObject,
-                                     DWORD grfKeyState, POINTL pt, DWORD *pdwEffect)
-{
+STDMETHODIMP VBoxDnDDropTarget::Drop(IDataObject *pDataObject, DWORD grfKeyState, POINTL pt, DWORD *pdwEffect)
+{
+    RT_NOREF(pt);
     AssertPtrReturn(pDataObject, E_INVALIDARG);
     AssertPtrReturn(pdwEffect,   E_INVALIDARG);

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxLA.cpp

@@ -911 +911 @@
     int l;
 
-    char **pClientInfoMap[LA_UTCINFO_CLIENT_INFO_LAST + 1] = {
-                                                               &pCtx->activeClient.pszPropName,
-                                                               &pCtx->activeClient.pszPropIPAddr,
-                                                               &pCtx->activeClient.pszPropLocation,
-                                                               &pCtx->activeClient.pszPropOtherInfo,
-                                                             };
-
-    pCtx->activeClient.u32LastAttach = ~0;
+    char **pClientInfoMap[LA_UTCINFO_CLIENT_INFO_LAST + 1] =
+    {
+        &pCtx->activeClient.pszPropName,
+        &pCtx->activeClient.pszPropIPAddr,
+        &pCtx->activeClient.pszPropLocation,
+        &pCtx->activeClient.pszPropOtherInfo,
+    };
+
+    pCtx->activeClient.u32LastAttach = UINT32_MAX;
     pCtx->activeClient.u64LastAttachTimestamp = u64ActiveClientTS;
 
@@ -1083 +1084 @@
 
     uint64_t u64Timestamp = 0;
-    uint32_t u32Attach = ~0;
+    uint32_t u32Attach = UINT32_MAX;
 
     int rc = laGetUint32(pCtx->u32GuestPropHandle,