Changeset 63180 in vbox for trunk/src/VBox/Main/src-client

Timestamp:

Aug 8, 2016 3:47:28 PM (8 years ago)

Author:

vboxsync

Message:

GuestDnDTargetImpl.cpp,GuestDnDSourceImpl.cpp: @todo r=bird: Pointed out race condition in thread task.

Location:

trunk/src/VBox/Main/src-client

Files:

• GuestDnDSourceImpl.cpp (modified) (1 diff)
• GuestDnDTargetImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/GuestDnDSourceImpl.cpp

@@ -381 +381 @@
         /* This function delete pTask in case of exceptions,
          * so there is no need in the call of delete operator. */
+/** @todo r=bird: The code using hThreadRcv is racing the thread termination. Since the thread isn't
+ * created waitable, the handle goes away if we it terminates before our RTThreadUserWait call returns. */
         hr = pTask->createThread(&hThreadRcv);
 

trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp

@@ -653 +653 @@
         //this function delete pTask in case of exceptions, so there is no need in the call of delete operator
         //pSendCtx is deleted in the pTask destructor
+/** @todo r=bird: The code using hThreadSend is racing the thread termination. Since the thread isn't
+ * created waitable, the handle goes away if we it terminates before our RTThreadUserWait call returns. */
         hr = pTask->createThread(&rcThreadSend);