Changeset 63182 in vbox for trunk/src/VBox/Main/src-client

Timestamp:

Aug 8, 2016 4:16:42 PM (8 years ago)

Author:

vboxsync

Message:

ThreadTask: split createThread up into three methods to avoid having to pass NULL all the time when the type needs specifying. Also, explictly marked the racy variant.

Location:

trunk/src/VBox/Main/src-client

Files:

• GuestCtrlImpl.cpp (modified) (1 diff)
• GuestDnDSourceImpl.cpp (modified) (1 diff)
• GuestDnDTargetImpl.cpp (modified) (1 diff)
• GuestSessionImpl.cpp (modified) (2 diffs)
• GuestSessionImplTasks.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp

@@ -584 +584 @@
                 }
 
-                hr = pTask->createThread(NULL, RTTHREADTYPE_MAIN_HEAVY_WORKER);
+                hr = pTask->createThreadWithType(RTTHREADTYPE_MAIN_HEAVY_WORKER);
 
                 if (SUCCEEDED(hr))

trunk/src/VBox/Main/src-client/GuestDnDSourceImpl.cpp

@@ -383 +383 @@
 /** @todo r=bird: The code using hThreadRcv is racing the thread termination. Since the thread isn't
  * created waitable, the handle goes away if we it terminates before our RTThreadUserWait call returns. */
-        hr = pTask->createThread(&hThreadRcv);
+        hr = pTask->createThreadWithRaceCondition(&hThreadRcv);
 
     }

trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp

@@ -655 +655 @@
 /** @todo r=bird: The code using hThreadSend is racing the thread termination. Since the thread isn't
  * created waitable, the handle goes away if we it terminates before our RTThreadUserWait call returns. */
-        hr = pTask->createThread(&rcThreadSend);
+        hr = pTask->createThreadWithRaceCondition(&rcThreadSend);
 
     }

trunk/src/VBox/Main/src-client/GuestSessionImpl.cpp

@@ -2512 +2512 @@
         }
 
-        hr = pTask->createThread(NULL, RTTHREADTYPE_MAIN_HEAVY_WORKER);
+        hr = pTask->createThreadWithType(RTTHREADTYPE_MAIN_HEAVY_WORKER);
 
         if (SUCCEEDED(hr))
@@ -2585 +2585 @@
         }
 
-        hr = pTask->createThread(NULL, RTTHREADTYPE_MAIN_HEAVY_WORKER);
+        hr = pTask->createThreadWithType(RTTHREADTYPE_MAIN_HEAVY_WORKER);
 
         if (SUCCEEDED(hr))

trunk/src/VBox/Main/src-client/GuestSessionImplTasks.cpp

@@ -1064 +1064 @@
                 }
 
-                hr = pTask->createThread(NULL, RTTHREADTYPE_MAIN_HEAVY_WORKER);
+                hr = pTask->createThreadWithType(RTTHREADTYPE_MAIN_HEAVY_WORKER);
 
                 if (SUCCEEDED(hr))