Changeset 63183 in vbox for trunk/src

Timestamp:

Aug 8, 2016 4:37:26 PM (8 years ago)

Author:

vboxsync

Message:

ThreadTask: Dealt with totally misguided m_pThread member. Started cleaning up handler() methods.

Location:

trunk/src/VBox/Main

Files:

• include/GuestDnDSourceImpl.h (modified) (2 diffs)
• include/GuestDnDTargetImpl.h (modified) (2 diffs)
• include/ThreadTask.h (modified) (3 diffs)
• src-all/ThreadTask.cpp (modified) (6 diffs)
• src-client/GuestDnDSourceImpl.cpp (modified) (5 diffs)
• src-client/GuestDnDTargetImpl.cpp (modified) (5 diffs)

trunk/src/VBox/Main/include/GuestDnDSourceImpl.h

@@ -27 +27 @@
 #include "GuestDnDPrivate.h"
 
+class RecvDataTask;
 struct RECVDATACTX;
 typedef struct RECVDATACTX *PRECVDATACTX;
@@ -83 +84 @@
     static Utf8Str i_hostErrorToString(int hostRc);
 
-    /** @name Thread callbacks.
+    /** @name Thread task .
      * @{ */
-    static DECLCALLBACK(int) i_receiveDataThread(RTTHREAD Thread, void *pvUser);
+    static void i_receiveDataThreadTask(RecvDataTask *pTask);
     /** @}  */
 

trunk/src/VBox/Main/include/GuestDnDTargetImpl.h

@@ -27 +27 @@
 struct SENDDATACTX;
 typedef struct SENDDATACTX *PSENDDATACTX;
+class SendDataTask;
 
 class ATL_NO_VTABLE GuestDnDTarget :
@@ -71 +72 @@
     static Utf8Str i_hostErrorToString(int hostRc);
 
-    /** @name Thread callbacks.
+    /** @name Thread task workers.
      * @{ */
-    static DECLCALLBACK(int) i_sendDataThread(RTTHREAD Thread, void *pvUser);
+    static void i_sendDataThreadTask(SendDataTask *pTask);
     /** @}  */
 

trunk/src/VBox/Main/include/ThreadTask.h

@@ -20 +20 @@
 #include "VBox/com/string.h"
 
+/**
+ * The class ThreadVoidData is used as a base class for any data which we want to pass into a thread
+ */
 struct ThreadVoidData
 {
-/*
- * The class ThreadVoidData is used as a base class for any data which we want to pass into a thread
- */
 public:
-    ThreadVoidData(){};
-    virtual ~ThreadVoidData(){};
+    ThreadVoidData() { }
+    virtual ~ThreadVoidData() { }
 };
+
 
 class ThreadTask
 {
 public:
-    ThreadTask(const Utf8Str &t) : m_pThread(NULL), m_strTaskName(t)
-    { };
+    ThreadTask(const Utf8Str &t) : m_hThread(NIL_RTTHREAD), m_strTaskName(t)
+    { }
 
     virtual ~ThreadTask()
-    { };
+    { }
 
     HRESULT createThread(void);
@@ -44 +45 @@
 
     virtual void handler() = 0;
-    inline Utf8Str getTaskName() const {return m_strTaskName;};
+    inline Utf8Str getTaskName() const { return m_strTaskName; }
 
 protected:
@@ -50 +51 @@
     static DECLCALLBACK(int) taskHandlerThreadProc(RTTHREAD thread, void *pvUser);
 
-    ThreadTask():m_pThread(NULL), m_strTaskName("GenericTask"){};
+    ThreadTask() : m_hThread(NIL_RTTHREAD), m_strTaskName("GenericTask")
+    { }
 
-    PRTTHREAD m_pThread;
+    /** The worker thread handle (may be invalid if the thread has shut down). */
+    RTTHREAD m_hThread;
     Utf8Str m_strTaskName;
 };

trunk/src/VBox/Main/src-all/ThreadTask.cpp

@@ -51 +51 @@
 HRESULT ThreadTask::createThread(void)
 {
-    return createThreadInternal(RTTHREADTYPE_MAIN_WORKER, NULL /*pThread*/);
+    return createThreadInternal(RTTHREADTYPE_MAIN_WORKER, NULL /*phThread*/);
 }
 
@@ -62 +62 @@
 HRESULT ThreadTask::createThreadWithType(RTTHREADTYPE enmType)
 {
-    return createThreadInternal(enmType, NULL /*pThread*/);
+    return createThreadInternal(enmType, NULL /*phThread*/);
 }
 
@@ -72 +72 @@
  * completion and termination of the task thread!  Use with care!
  *
- * @param   pThread     Handle of the worker thread.
+ * @param   phThread    Handle of the worker thread.
  */
-HRESULT ThreadTask::createThreadWithRaceCondition(PRTTHREAD pThread)
+HRESULT ThreadTask::createThreadWithRaceCondition(PRTTHREAD phThread)
 {
-    return createThreadInternal(RTTHREADTYPE_MAIN_WORKER, pThread);
+    return createThreadInternal(RTTHREADTYPE_MAIN_WORKER, phThread);
 }
 
@@ -86 +86 @@
  * @note Always consumes @a this!
  */
-HRESULT ThreadTask::createThreadInternal(RTTHREADTYPE enmType, PRTTHREAD pThread)
+HRESULT ThreadTask::createThreadInternal(RTTHREADTYPE enmType, PRTTHREAD phThread)
 {
-    m_pThread = pThread; /** @todo this is utter non-sense! */
-    int vrc = RTThreadCreate(m_pThread,
+    int vrc = RTThreadCreate(&m_hThread,
                              taskHandlerThreadProc,
                              (void *)this,
@@ -97 +96 @@
                              this->getTaskName().c_str());
     if (RT_SUCCESS(vrc))
+    {
+        if (phThread)
+            *phThread = m_hThread;
         return S_OK;
+    }
 
     delete this;
@@ -116 +119 @@
 
     /*
-    *  handler shall catch and process all possible cases as errors and exceptions.
-    */
+     *  handler shall catch and process all possible cases as errors and exceptions.
+     */
     pTask->handler();
 
+    pTask->m_hThread = NIL_RTTHREAD; /* unnecessary, but whatever. */
     delete pTask;
     return VINF_SUCCESS;

trunk/src/VBox/Main/src-client/GuestDnDSourceImpl.cpp

@@ -86 +86 @@
     void handler()
     {
-        int vrc = GuestDnDSource::i_receiveDataThread(*m_pThread, this);
+        GuestDnDSource::i_receiveDataThreadTask(this);
     }
 
@@ -962 +962 @@
 #endif /* VBOX_WITH_DRAG_AND_DROP_GH */
 
+/**
+ * @returns VBox status code that the caller ignores. Not sure if that's
+ *          intentional or not.
+ */
 int GuestDnDSource::i_receiveData(PRECVDATACTX pCtx, RTMSINTERVAL msTimeout)
 {
@@ -1062 +1066 @@
 
 /* static */
-DECLCALLBACK(int) GuestDnDSource::i_receiveDataThread(RTTHREAD Thread, void *pvUser)
-{
-    LogFlowFunc(("pvUser=%p\n", pvUser));
-
-    RecvDataTask *pTask = (RecvDataTask *)pvUser;
-    AssertPtrReturn(pTask, VERR_INVALID_POINTER);
+DECLCALLBACK(void) GuestDnDSource::i_receiveDataThreadTask(RecvDataTask *pTask)
+{
+    LogFlowFunc(("pTask=%p\n", pTask));
+    AssertPtrReturnVoid(pTask);
 
     const ComObjPtr<GuestDnDSource> pThis(pTask->getSource());
@@ -1073 +1075 @@
 
     AutoCaller autoCaller(pThis);
-    if (FAILED(autoCaller.rc())) return VERR_COM_INVALID_OBJECT_STATE;
-
-    int rc = RTThreadUserSignal(Thread);
-    AssertRC(rc);
-
-    rc = pThis->i_receiveData(pTask->getCtx(), RT_INDEFINITE_WAIT /* msTimeout */);
+    if (FAILED(autoCaller.rc()))
+        return;
+
+    int vrc = RTThreadUserSignal(RTThreadSelf());
+    AssertRC(vrc);
+
+    vrc = pThis->i_receiveData(pTask->getCtx(), RT_INDEFINITE_WAIT /* msTimeout */);
+/** @todo
+ *
+ *  r=bird: What happens with @a vrc?
+ *
+ */
 
     AutoWriteLock alock(pThis COMMA_LOCKVAL_SRC_POS);
@@ -1085 +1093 @@
     pThis->mDataBase.m_cTransfersPending--;
 
-    LogFlowFunc(("pSource=%p returning rc=%Rrc\n", (GuestDnDSource *)pThis, rc));
-    return rc;
+    LogFlowFunc(("pSource=%p vrc=%Rrc (ignored)\n", (GuestDnDSource *)pThis, vrc));
 }
 

trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp

@@ -90 +90 @@
     void handler()
     {
-        int vrc = GuestDnDTarget::i_sendDataThread(*m_pThread, this);
-        NOREF(vrc);
+        GuestDnDTarget::i_sendDataThreadTask(this);
     }
 
@@ -558 +557 @@
 
 /* static */
-DECLCALLBACK(int) GuestDnDTarget::i_sendDataThread(RTTHREAD Thread, void *pvUser)
-{
-    LogFlowFunc(("pvUser=%p\n", pvUser));
-
-    SendDataTask *pTask = (SendDataTask *)pvUser;
-    AssertPtrReturn(pTask, VERR_INVALID_POINTER);
+void GuestDnDTarget::i_sendDataThreadTask(SendDataTask *pTask)
+{
+    LogFlowFunc(("pTask=%p\n", pTask));
+
+    AssertPtrReturnVoid(pTask);
 
     const ComObjPtr<GuestDnDTarget> pThis(pTask->getTarget());
@@ -569 +567 @@
 
     AutoCaller autoCaller(pThis);
-    if (FAILED(autoCaller.rc())) return VERR_COM_INVALID_OBJECT_STATE;
-
-    int rc = RTThreadUserSignal(Thread);
-    AssertRC(rc);
-
-    rc = pThis->i_sendData(pTask->getCtx(), RT_INDEFINITE_WAIT /* msTimeout */);
+    if (FAILED(autoCaller.rc()))
+        return;
+
+    int vrc = RTThreadUserSignal(RTThreadSelf());
+    AssertRC(vrc);
+
+    vrc = pThis->i_sendData(pTask->getCtx(), RT_INDEFINITE_WAIT /* msTimeout */);
+/** @todo
+ *
+ *  r=bird: What happens with @a vrc?
+ *
+ */
 
     AutoWriteLock alock(pThis COMMA_LOCKVAL_SRC_POS);
@@ -581 +585 @@
     pThis->mDataBase.m_cTransfersPending--;
 
-    LogFlowFunc(("pTarget=%p returning rc=%Rrc\n", (GuestDnDTarget *)pThis, rc));
-    return rc;
+    LogFlowFunc(("pTarget=%p vrc=%Rrc (ignored)\n", (GuestDnDTarget *)pThis, vrc));
 }
 
@@ -779 +782 @@
 }
 
+/**
+ * @returns VBox status code that the caller ignores. Not sure if that's
+ *          intentional or not.
+ */
 int GuestDnDTarget::i_sendData(PSENDDATACTX pCtx, RTMSINTERVAL msTimeout)
 {