Changeset 63218 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Aug 9, 2016 3:52:35 PM (8 years ago)

Author:

vboxsync

Message:

Devices: warnings (gcc)

Location:

trunk/src/VBox/Devices/Network

Files:

• DevE1000.cpp (modified) (5 diffs)
• DevPCNet.cpp (modified) (2 diffs)
• DrvTAP.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -2136 +2136 @@
 }
 
+# ifdef IN_RING3 /* currently only used in ring-3 due to stack space requirements of the caller */
 /**
  * Store a fragment of received packet at the specifed address.
@@ -2153 +2154 @@
     STAM_PROFILE_ADV_STOP(&pThis->StatReceiveStore, a);
 }
+# endif
 
 #else /* !E1K_WITH_RXD_CACHE */
@@ -2230 +2232 @@
 }
 
+#ifdef IN_RING3 /* currently only used in ring-3 due to stack space requirements of the caller */
 /**
  * Set IXSM, IPCS and TCPCS flags according to the packet type.
@@ -2249 +2252 @@
      * and do verification in software.
      */
-#if 0
+# if 0
     uint16_t uEtherType = ntohs(*(uint16_t*)(pFrame + 12));
 
@@ -2274 +2277 @@
             break;
     }
-#else
+# else
     pStatus->fIXSM = true;
     RT_NOREF_PV(pThis); RT_NOREF_PV(pFrame); RT_NOREF_PV(cb);
-#endif
+# endif
     return VINF_SUCCESS;
 }
+#endif /* IN_RING3 */
 
 /**

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -2015 +2015 @@
 
 
+#ifdef IN_RING3
 /**
  * Transmit queue consumer
@@ -2036 +2037 @@
     return true;
 }
+#endif /* IN_RING3 */
 
 

trunk/src/VBox/Devices/Network/DrvTAP.cpp

@@ -151 +151 @@
 static DECLCALLBACK(int) drvTAPNetworkUp_BeginXmit(PPDMINETWORKUP pInterface, bool fOnWorkerThread)
 {
+    RT_NOREF(fOnWorkerThread);
     PDRVTAP pThis = PDMINETWORKUP_2_DRVTAP(pInterface);
     int rc = RTCritSectTryEnter(&pThis->XmitLock);
@@ -230 +231 @@
 static DECLCALLBACK(int) drvTAPNetworkUp_SendBuf(PPDMINETWORKUP pInterface, PPDMSCATTERGATHER pSgBuf, bool fOnWorkerThread)
 {
+    RT_NOREF(fOnWorkerThread);
     PDRVTAP pThis = PDMINETWORKUP_2_DRVTAP(pInterface);
     STAM_COUNTER_INC(&pThis->StatPktSent);
@@ -301 +303 @@
 static DECLCALLBACK(void) drvTAPNetworkUp_SetPromiscuousMode(PPDMINETWORKUP pInterface, bool fPromiscuous)
 {
+    RT_NOREF(pInterface, fPromiscuous);
     LogFlow(("drvTAPNetworkUp_SetPromiscuousMode: fPromiscuous=%d\n", fPromiscuous));
     /* nothing to do */
@@ -315 +318 @@
 static DECLCALLBACK(void) drvTAPNetworkUp_NotifyLinkChanged(PPDMINETWORKUP pInterface, PDMNETWORKLINKSTATE enmLinkState)
 {
+    RT_NOREF(pInterface, enmLinkState);
     LogFlow(("drvTAPNetworkUp_NotifyLinkChanged: enmLinkState=%d\n", enmLinkState));
     /** @todo take action on link down and up. Stop the polling and such like. */
@@ -467 +471 @@
 static DECLCALLBACK(int) drvTapAsyncIoWakeup(PPDMDRVINS pDrvIns, PPDMTHREAD pThread)
 {
+    RT_NOREF(pThread);
     PDRVTAP pThis = PDMINS_2_DATA(pDrvIns, PDRVTAP);
 
@@ -843 +848 @@
 static DECLCALLBACK(int) drvTAPConstruct(PPDMDRVINS pDrvIns, PCFGMNODE pCfg, uint32_t fFlags)
 {
+    RT_NOREF(fFlags);
+    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
     PDRVTAP pThis = PDMINS_2_DATA(pDrvIns, PDRVTAP);
-    PDMDRV_CHECK_VERSIONS_RETURN(pDrvIns);
 
     /*