Changeset 63248 in vbox for trunk/src/VBox

Timestamp:

Aug 10, 2016 11:02:10 AM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

109878

Message:

Main: warnings

File:

• trunk/src/VBox/Main/src-client/GuestProcessImpl.cpp (modified) (8 diffs)

trunk/src/VBox/Main/src-client/GuestProcessImpl.cpp

@@ -135 +135 @@
                 AssertPtrReturn(mProcess, E_POINTER);
                 int rc2 = mProcess->signalWaitEvent(aType, aEvent);
-#ifdef DEBUG
+                RT_NOREF(rc2);
+#ifdef LOG_ENABLED
                 LogFlowThisFunc(("Signalling events of type=%RU32, pProcess=%p resulted in rc=%Rrc\n",
                                  aType, &mProcess, rc2));
@@ -299 +300 @@
     LogFlowThisFunc(("Returning rc=%Rrc, guestRc=%Rrc\n",
                      vrc, guestRc));
+    RT_NOREF_PV(vrc);
 }
 
@@ -790 +792 @@
 int GuestProcess::i_onProcessOutput(PVBOXGUESTCTRLHOSTCBCTX pCbCtx, PVBOXGUESTCTRLHOSTCALLBACK pSvcCbData)
 {
+    RT_NOREF(pCbCtx);
     AssertPtrReturn(pSvcCbData, VERR_INVALID_POINTER);
 
@@ -1490 +1493 @@
                                        ProcessInputStatus_T *pInputStatus, uint32_t *pcbProcessed)
 {
+    RT_NOREF(uHandle);
     AssertPtrReturn(pEvent, VERR_INVALID_POINTER);
 
@@ -1655 +1659 @@
                                          uint32_t uProtocol)
 {
+    /** @todo r=bird: If you subscribe to HN, which the 'u' in 'uProcFlags'
+     *        indicates, you should actually be using 'fProc'! */
+    RT_NOREF(uProtocol, uProcFlags);
     bool fImplies;
 
@@ -2025 +2032 @@
 int GuestProcessTool::i_getRc(void) const
 {
-    LONG exitCode;
+    LONG exitCode = -1;
     HRESULT hr = pProcess->COMGETTER(ExitCode(&exitCode));
-    Assert(SUCCEEDED(hr));
+    AssertComRC(hr);
 
     return GuestProcessTool::i_exitCodeToRc(mStartupInfo, exitCode);
@@ -2038 +2045 @@
     ProcessStatus_T procStatus = ProcessStatus_Undefined;
     HRESULT hr = pProcess->COMGETTER(Status(&procStatus));
-    Assert(SUCCEEDED(hr));
+    AssertComRC(hr);
 
     if (   procStatus == ProcessStatus_Started
@@ -2213 +2220 @@
     if (!i_isRunning())
     {
-        LONG lExitCode;
+        LONG lExitCode = -1;
         HRESULT hr = pProcess->COMGETTER(ExitCode(&lExitCode));
-        Assert(SUCCEEDED(hr));
+        AssertComRC(hr);
 
         if (plExitCode)