Changeset 63285 in vbox for trunk/src/VBox/NetworkServices/NetLib

Timestamp:

Aug 10, 2016 3:04:27 PM (8 years ago)

Author:

vboxsync

Message:

NetworkServices: warnings

File:

• trunk/src/VBox/NetworkServices/NetLib/VBoxNetPortForwardString.cpp (modified) (3 diffs)

trunk/src/VBox/NetworkServices/NetLib/VBoxNetPortForwardString.cpp

@@ -83 +83 @@
 
         if (cchField != 0)
-            RTStrCopy(pszAddress, RT_MIN(cchField + 1, cbAddress), pszRaw);
+            RTStrCopy(pszAddress, RT_MIN(cchField + 1, (size_t)cbAddress), pszRaw);
         else if (!fEmptyAcceptable)
             return -1;
@@ -246 +246 @@
 int netPfStrToPf(const char *pcszStrPortForward, bool fIPv6, PPORTFORWARDRULE pPfr)
 {
-/** r=bird: Redo from scratch?  This is very hard to read. */
+/** r=bird: Redo from scratch?  This is very hard to read.  And it's going about
+ *  things in a very complicated, potentially leaky (pszRaw) fashion. */
 
     int  proto;
@@ -286 +287 @@
         cbToken = pszEndOfName - pszRaw; /* don't take : into account */
         /* XXX it's unacceptable to have only name entry in PF */
-        AssertReturn(cbToken < cchRaw, VERR_INVALID_PARAMETER);
+        AssertReturn(cbToken < (ssize_t)cchRaw, VERR_INVALID_PARAMETER);
 
         if (   cbToken < 0