Changeset 63369 in vbox

Timestamp:

Aug 12, 2016 4:45:31 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

110010

Message:

warnings (gcc)

Location:

trunk/src/VBox

Files:

• Additions/x11/vboxvideo/vboxvideo.c (modified) (1 diff)
• Devices/Audio/AudioMixBuffer.cpp (modified) (3 diffs)
• Devices/Audio/DrvHostPulseAudio.cpp (modified) (1 diff)
• Devices/Network/DevE1000Phy.cpp (modified) (3 diffs)
• Devices/Network/DrvTAP.cpp (modified) (2 diffs)
• Devices/Network/DrvVDE.cpp (modified) (2 diffs)
• Devices/PC/DevDMA.cpp (modified) (1 diff)
• Devices/Storage/ATAPIPassthrough.cpp (modified) (2 diffs)
• Devices/Storage/DrvHostDVD.cpp (modified) (1 diff)
• Devices/USB/linux/USBProxyDevice-linux.cpp (modified) (1 diff)
• Devices/VirtIO/Virtio.cpp (modified) (1 diff)
• ExtPacks/VBoxDTrace/onnv/common/ctf/ctf_labels.c (modified) (1 diff)
• ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dt_lex.l (modified) (1 diff)
• ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dt_printf.c (modified) (1 diff)
• GuestHost/OpenGL/util/blitter.cpp (modified) (1 diff)
• GuestHost/OpenGL/util/htable.cpp (modified) (1 diff)
• ValidationKit/bootsectors/bs3kit/VBoxBs3ObjConverter.cpp (modified) (1 diff)

trunk/src/VBox/Additions/x11/vboxvideo/vboxvideo.c

@@ -1038 +1038 @@
 static void setSizesAndCursorIntegration(ScrnInfoPtr pScrn, bool fScreenInitTime)
 {
+    RT_NOREF(fScreenInitTime);
     TRACE_LOG("fScreenInitTime=%d\n", (int)fScreenInitTime);
 #ifdef VBOXVIDEO_13

trunk/src/VBox/Devices/Audio/AudioMixBuffer.cpp

@@ -61 +61 @@
 #endif
 
+#ifdef DEBUG
 DECLINLINE(void) audioMixBufDbgPrintInternal(PPDMAUDIOMIXBUF pMixBuf);
+#endif
 
 /*
@@ -1139 +1141 @@
 
 #ifdef DEBUG
+
 /**
  * Prints a single mixing buffer.
@@ -1245 +1248 @@
     audioMixBufDbgPrintInternal(pMixBuf);
 }
-#endif
+
+#endif /* DEBUG */
 
 /**

trunk/src/VBox/Devices/Audio/DrvHostPulseAudio.cpp

@@ -859 +859 @@
             rc = AudioMixBufMixToParent(&pStream->MixBuf, cWrittenTotal,
                                         &cProcessed);*/
+        NOREF(cProcessed);
         if (pcbRead)
             *pcbRead = cWrittenTotal;

trunk/src/VBox/Devices/Network/DevE1000Phy.cpp

@@ -51 +51 @@
 /* Internals */
 namespace Phy {
+#if defined(LOG_ENABLED) && !defined(PHY_UNIT_TEST)
     /** Retrieves state name by id */
     static const char * getStateName(uint16_t u16State);
+#endif
     /** Look up register index by address. */
     static int lookupRegister(uint32_t u32Address);
@@ -478 +480 @@
 }
 
+#if defined(LOG_ENABLED) && !defined(PHY_UNIT_TEST)
 static const char * Phy::getStateName(uint16_t u16State)
 {
@@ -493 +496 @@
     return (u16State < RT_ELEMENTS(pcszState)) ? pcszState[u16State] : "<invalid>";
 }
+#endif
 
 bool Phy::readMDIO(PPHY pPhy)

trunk/src/VBox/Devices/Network/DrvTAP.cpp

@@ -169 +169 @@
                                                   PCPDMNETWORKGSO pGso, PPPDMSCATTERGATHER ppSgBuf)
 {
+    RT_NOREF(pInterface);
+#ifdef VBOX_STRICT
     PDRVTAP pThis = PDMINETWORKUP_2_DRVTAP(pInterface);
     Assert(RTCritSectIsOwner(&pThis->XmitLock));
+#endif
 
     /*
@@ -214 +217 @@
 static DECLCALLBACK(int) drvTAPNetworkUp_FreeBuf(PPDMINETWORKUP pInterface, PPDMSCATTERGATHER pSgBuf)
 {
+    RT_NOREF(pInterface);
+#ifdef VBOX_STRICT
     PDRVTAP pThis = PDMINETWORKUP_2_DRVTAP(pInterface);
     Assert(RTCritSectIsOwner(&pThis->XmitLock));
+#endif
+
     if (pSgBuf)
     {

trunk/src/VBox/Devices/Network/DrvVDE.cpp

@@ -138 +138 @@
                                                   PCPDMNETWORKGSO pGso, PPPDMSCATTERGATHER ppSgBuf)
 {
+    RT_NOREF(pInterface);
+#ifdef VBOX_STRICT
     PDRVVDE pThis = PDMINETWORKUP_2_DRVVDE(pInterface);
     Assert(RTCritSectIsOwner(&pThis->XmitLock));
+#endif
 
     /*
@@ -183 +186 @@
 static DECLCALLBACK(int) drvVDENetworkUp_FreeBuf(PPDMINETWORKUP pInterface, PPDMSCATTERGATHER pSgBuf)
 {
+    RT_NOREF(pInterface);
+#ifdef VBOX_STRICT
     PDRVVDE pThis = PDMINETWORKUP_2_DRVVDE(pInterface);
     Assert(RTCritSectIsOwner(&pThis->XmitLock));
+#endif
     if (pSgBuf)
     {

trunk/src/VBox/Devices/PC/DevDMA.cpp

@@ -192 +192 @@
 #define DMACH2C(c)      (c < 4 ? 0 : 1)
 
+#ifdef LOG_ENABLED
 static int dmaChannelMap[8] = {-1, 2, 3, 1, -1, -1, -1, 0};
 /* Map a DMA page register offset (0-7) to channel index (0-3). */
 #define DMAPG2CX(c)     (dmaChannelMap[c])
+#endif
 
 static int dmaMapChannel[4] = {7, 3, 1, 2};

trunk/src/VBox/Devices/Storage/ATAPIPassthrough.cpp

@@ -415 +415 @@
 }
 
+#ifdef LOG_ENABLED
+
 /**
  * Converts the given track data form to a string.
@@ -494 +496 @@
     }
 }
+
+#endif /* LOG_ENABLED */
 
 DECLHIDDEN(int) ATAPIPassthroughTrackListCreateEmpty(PTRACKLIST *ppTrackList)

trunk/src/VBox/Devices/Storage/DrvHostDVD.cpp

@@ -420 +420 @@
                                            uint8_t *pabSense, size_t cbSense, uint32_t cTimeoutMillies)
 {
+    RT_NOREF(cbSense);
     PDRVHOSTBASE pThis = PDMIMEDIA_2_DRVHOSTBASE(pInterface);
     int rc;

trunk/src/VBox/Devices/USB/linux/USBProxyDevice-linux.cpp

@@ -1280 +1280 @@
 static int usbProxyLinuxSubmitURB(PUSBPROXYDEV pProxyDev, PUSBPROXYURBLNX pCur, PVUSBURB pUrb, bool *pfUnplugged)
 {
+    RT_NOREF(pUrb);
     PUSBPROXYDEVLNX pDevLnx = USBPROXYDEV_2_DATA(pProxyDev, PUSBPROXYDEVLNX);
     unsigned        cTries = 0;

trunk/src/VBox/Devices/VirtIO/Virtio.cpp

@@ -800 +800 @@
 }
 
+#ifdef VBOX_WITH_STATISTICS
 /* WARNING! This function must never be used in multithreaded context! */
 static const char *vpciCounter(const char *pszDevFmt,
                                const char *pszCounter)
 {
-    static char g_szCounterName[80];
-
-    RTStrPrintf(g_szCounterName, sizeof(g_szCounterName),
+    static char s_szCounterName[80];
+
+    RTStrPrintf(s_szCounterName, sizeof(s_szCounterName),
                 "/Devices/%s/%s", pszDevFmt, pszCounter);
 
-    return g_szCounterName;
-}
+    return s_szCounterName;
+}
+#endif
 
 // TODO: header

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/common/ctf/ctf_labels.c

@@ -39 +39 @@
          * Labels are only supported in V2 or later
          */
-        if (fp->ctf_version < CTF_VERSION_2)
+        if (fp->ctf_version < CTF_VERSION_2) {
+                *ctl = NULL; /* Shup up, GCC! */
+                *num_labels = 0;
                 return (ctf_set_errno(fp, ECTF_NOTSUP));
+        }
 
         h = (const ctf_header_t *)fp->ctf_data.cts_data;

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dt_lex.l

@@ -46 +46 @@
 # ifdef _MSC_VER
 #  pragma warning(disable:4668 4131 4255)
+# endif
+# ifdef __GNUC__
+#  if ((__GNUC__ << 16) + __GNUC_MINOR__) >= 0x4002
+#   pragma GCC diagnostic ignored "-Wunused-function"
+#  endif
 # endif
 # include <iprt/ctype.h>

trunk/src/VBox/ExtPacks/VBoxDTrace/onnv/lib/libdtrace/common/dt_printf.c

@@ -1434 +1434 @@
                 caddr_t addr;
                 size_t size;
-                uint32_t flags;
+                uint32_t flags VBDTUNASS(0);
 
                 if (pfd->pfd_preflen != 0) {

trunk/src/VBox/GuestHost/OpenGL/util/blitter.cpp

@@ -244 +244 @@
     float strX = ((float)dstWidth) / srcWidth;
     float strY = ((float)dstHeight) / srcHeight;
-    bool fScale = (dstWidth != srcWidth || dstHeight != srcHeight);
-    Assert(fScale);
+    Assert(dstWidth != srcWidth || dstHeight != srcHeight);
 
     RTRECT Intersection;

trunk/src/VBox/GuestHost/OpenGL/util/htable.cpp

@@ -158 +158 @@
         {
             void *pvOld = crHTablePutToSlot(pTbl, i, pvData);
-            Assert(!pvOld);
+            Assert(!pvOld); NOREF(pvOld);
             pTbl->iNext2Search = i+1;
             pTbl->iNext2Search %= pTbl->cSize;

trunk/src/VBox/ValidationKit/bootsectors/bs3kit/VBoxBs3ObjConverter.cpp

@@ -1504 +1504 @@
     /** @todo do we need to consider missing segments and ordering? */
     uint16_t cGrpNms = 0;
-    uint16_t aiGrpNms[2];
+    uint16_t aiGrpNms[2] = { 0, 0 }; /* Shut up, GCC. */
     if (fHaveData)
         aiGrpNms[cGrpNms++] = idxGrpData;