Changeset 63509 in vbox for trunk

Timestamp:

Aug 15, 2016 10:54:50 PM (8 years ago)

Author:

vboxsync

Message:

IPRT: warnings (clang)

Location:

trunk/src/VBox/Runtime

Files:

• common/log/log.cpp (modified) (2 diffs)
• generic/RTMpOnPair-generic.cpp (modified) (1 diff)
• r0drv/darwin/memuserkernel-r0drv-darwin.cpp (modified) (2 diffs)
• r0drv/darwin/mp-r0drv-darwin.cpp (modified) (2 diffs)
• r0drv/darwin/semevent-r0drv-darwin.cpp (modified) (2 diffs)
• r0drv/darwin/semeventmulti-r0drv-darwin.cpp (modified) (2 diffs)
• r0drv/darwin/semmutex-r0drv-darwin.cpp (modified) (3 diffs)
• r0drv/darwin/the-darwin-kernel.h (modified) (2 diffs)
• r0drv/darwin/thread2-r0drv-darwin.cpp (modified) (4 diffs)
• r0drv/darwin/threadpreempt-r0drv-darwin.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/log/log.cpp

@@ -359 +359 @@
 };
 
+#ifdef IN_RING3
 /** Log rotation backoff table - millisecond sleep intervals.
  * Important on Windows host, especially for VBoxSVC release logging.  Only a
@@ -366 +367 @@
 static const uint32_t g_acMsLogBackoff[] =
 { 10, 10, 10, 20, 50, 100, 200, 200, 200, 200, 500, 500, 500, 500, 1000, 1000, 1000, 1000, 1000, 1000, 1000 };
+#endif
 
 

trunk/src/VBox/Runtime/generic/RTMpOnPair-generic.cpp

@@ -64 +64 @@
 static DECLCALLBACK(void) rtMpOnPairGenericWorker(RTCPUID idCpu, void *pvUser1, void *pvUser2)
 {
+    RT_NOREF(pvUser2);
     PRTMPONPAIRGENERIC pArgs = (PRTMPONPAIRGENERIC)pvUser1;
 

trunk/src/VBox/Runtime/r0drv/darwin/memuserkernel-r0drv-darwin.cpp

@@ -106 +106 @@
 RTR0DECL(int) RTR0MemKernelCopyFrom(void *pvDst, void const *pvSrc, size_t cb)
 {
+    RT_NOREF(pvDst, pvSrc, cb);
     return VERR_NOT_SUPPORTED;
 }
@@ -112 +113 @@
 RTR0DECL(int) RTR0MemKernelCopyTo(void *pvDst, void const *pvSrc, size_t cb)
 {
+    RT_NOREF(pvDst, pvSrc, cb);
     return VERR_NOT_SUPPORTED;
 }

trunk/src/VBox/Runtime/r0drv/darwin/mp-r0drv-darwin.cpp

@@ -164 +164 @@
 {
     /** @todo darwin R0 MP (rainy day) */
+    RT_NOREF(idCpu);
     return 0;
 }
@@ -171 +172 @@
 {
     /** @todo darwin R0 MP (rainy day) */
+    RT_NOREF(idCpu);
     return 0;
 }

trunk/src/VBox/Runtime/r0drv/darwin/semevent-r0drv-darwin.cpp

@@ -96 +96 @@
 RTDECL(int)  RTSemEventCreateEx(PRTSEMEVENT phEventSem, uint32_t fFlags, RTLOCKVALCLASS hClass, const char *pszNameFmt, ...)
 {
+    RT_NOREF(hClass, pszNameFmt);
     AssertCompile(sizeof(RTSEMEVENTINTERNAL) > sizeof(void *));
     AssertReturn(!(fFlags & ~(RTSEMEVENT_FLAGS_NO_LOCK_VAL | RTSEMEVENT_FLAGS_BOOTSTRAP_HACK)), VERR_INVALID_PARAMETER);
@@ -245 +246 @@
                                   PCRTLOCKVALSRCPOS pSrcPos)
 {
+    RT_NOREF(pSrcPos);
+
     /*
      * Validate the input.

trunk/src/VBox/Runtime/r0drv/darwin/semeventmulti-r0drv-darwin.cpp

@@ -100 +100 @@
                                      const char *pszNameFmt, ...)
 {
+    RT_NOREF(hClass, pszNameFmt);
     AssertReturn(!(fFlags & ~RTSEMEVENTMULTI_FLAGS_NO_LOCK_VAL), VERR_INVALID_PARAMETER);
     AssertCompile(sizeof(RTSEMEVENTMULTIINTERNAL) > sizeof(void *));
@@ -264 +265 @@
                                        PCRTLOCKVALSRCPOS pSrcPos)
 {
+    RT_NOREF(pSrcPos);
+
     /*
      * Validate input.

trunk/src/VBox/Runtime/r0drv/darwin/semmutex-r0drv-darwin.cpp

@@ -79 +79 @@
                                RTLOCKVALCLASS hClass, uint32_t uSubClass, const char *pszNameFmt, ...)
 {
+    RT_NOREF(hClass, uSubClass, pszNameFmt);
     AssertReturn(!(fFlags & ~RTSEMMUTEX_FLAGS_NO_LOCK_VAL), VERR_INVALID_PARAMETER);
     RT_ASSERT_PREEMPTIBLE();
@@ -326 +327 @@
 RTDECL(int) RTSemMutexRequestDebug(RTSEMMUTEX hMutexSem, RTMSINTERVAL cMillies, RTHCUINTPTR uId, RT_SRC_POS_DECL)
 {
+    RT_SRC_POS_NOREF(); RT_NOREF(uId);
     return RTSemMutexRequest(hMutexSem, cMillies);
 }
@@ -338 +340 @@
 RTDECL(int) RTSemMutexRequestNoResumeDebug(RTSEMMUTEX hMutexSem, RTMSINTERVAL cMillies, RTHCUINTPTR uId, RT_SRC_POS_DECL)
 {
+    RT_SRC_POS_NOREF(); RT_NOREF(uId);
     return RTSemMutexRequestNoResume(hMutexSem, cMillies);
 }

trunk/src/VBox/Runtime/r0drv/darwin/the-darwin-kernel.h

@@ -52 +52 @@
 #endif
 
+#if defined(__clang__) || RT_GNUC_PREREQ(4, 4)
+# pragma GCC diagnostic push
+#endif
+#if defined(__clang__) || RT_GNUC_PREREQ(4, 2)
+# pragma GCC diagnostic ignored "-Wc++11-extensions"
+# pragma GCC diagnostic ignored "-Wc99-extensions"
+# pragma GCC diagnostic ignored "-Wextra-semi"
+# pragma GCC diagnostic ignored "-Wzero-length-array"
+# pragma GCC diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+#endif
+
 /* now we're ready for including the rest of the Darwin headers. */
 #include <kern/thread.h>
@@ -79 +90 @@
 #include <IOKit/IOBufferMemoryDescriptor.h>
 #include <IOKit/IOMapper.h>
+
+#if defined(__clang__) || RT_GNUC_PREREQ(4, 4)
+# pragma GCC diagnostic pop
+#endif
 
 

trunk/src/VBox/Runtime/r0drv/darwin/thread2-r0drv-darwin.cpp

@@ -133 +133 @@
 DECLHIDDEN(int) rtThreadNativeAdopt(PRTTHREADINT pThread)
 {
+    RT_NOREF(pThread);
     return VERR_NOT_IMPLEMENTED;
 }
@@ -139 +140 @@
 DECLHIDDEN(void) rtThreadNativeWaitKludge(PRTTHREADINT pThread)
 {
+    RT_NOREF(pThread);
     /** @todo fix RTThreadWait/RTR0Term race on darwin. */
     RTThreadSleep(1);
@@ -146 +148 @@
 DECLHIDDEN(void) rtThreadNativeDestroy(PRTTHREADINT pThread)
 {
-    NOREF(pThread);
+    RT_NOREF(pThread);
 }
 
@@ -160 +162 @@
 static void rtThreadNativeMain(void *pvArg, wait_result_t Ignored)
 {
+    RT_NOREF(Ignored);
     const thread_t Self = current_thread();
     PRTTHREADINT pThread = (PRTTHREADINT)pvArg;

trunk/src/VBox/Runtime/r0drv/darwin/threadpreempt-r0drv-darwin.cpp

@@ -111 +111 @@
 RTDECL(bool) RTThreadPreemptIsPending(RTTHREAD hThread)
 {
+    RT_NOREF(hThread);
     if (!g_pfnR0DarwinAstPending)
         return false;