Changeset 63510 in vbox for trunk/src/VBox/HostDrivers/Support/darwin

Timestamp:

Aug 15, 2016 11:08:03 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

110164

Message:

SUP: warnings (clang)

File:

• trunk/src/VBox/HostDrivers/Support/darwin/SUPDrv-darwin.cpp (modified) (13 diffs)

trunk/src/VBox/HostDrivers/Support/darwin/SUPDrv-darwin.cpp

@@ -212 +212 @@
     /*.d_mmap  = */eno_mmap,
     /*.d_strategy = */eno_strat,
-    /*.d_getc  = */eno_getc,
-    /*.d_putc  = */eno_putc,
+    /*.d_getc  = */(void *)(uintptr_t)&enodev, //eno_getc,
+    /*.d_putc  = */(void *)(uintptr_t)&enodev, //eno_putc,
     /*.d_type  = */0
 };
@@ -257 +257 @@
 static kern_return_t    VBoxDrvDarwinStart(struct kmod_info *pKModInfo, void *pvData)
 {
+    RT_NOREF(pKModInfo, pvData);
     int rc;
 #ifdef DEBUG
@@ -394 +395 @@
              * MSR prober stuff - optional!
              */
-            int rc2 = RTR0DbgKrnlInfoQuerySymbol(hKrnlInfo, NULL, "rdmsr_carefully", (void **)&g_pfnRdMsrCarefully);
+            rc2 = RTR0DbgKrnlInfoQuerySymbol(hKrnlInfo, NULL, "rdmsr_carefully", (void **)&g_pfnRdMsrCarefully);
             if (RT_FAILURE(rc2))
                 g_pfnRdMsrCarefully = NULL;
@@ -425 +426 @@
 static kern_return_t    VBoxDrvDarwinStop(struct kmod_info *pKModInfo, void *pvData)
 {
+    RT_NOREF(pKModInfo, pvData);
     int rc;
     LogFlow(("VBoxDrvDarwinStop\n"));
@@ -476 +478 @@
 static int VBoxDrvDarwinOpen(dev_t Dev, int fFlags, int fDevType, struct proc *pProcess)
 {
+    RT_NOREF(fFlags, fDevType);
 #ifdef DEBUG_DARWIN_GIP
     char szName[128];
@@ -561 +564 @@
 static int VBoxDrvDarwinClose(dev_t Dev, int fFlags, int fDevType, struct proc *pProcess)
 {
+    RT_NOREF(Dev, fFlags, fDevType, pProcess);
     Log(("VBoxDrvDarwinClose: pid=%d\n", (int)RTProcSelf()));
     Assert(proc_pid(pProcess) == (int)RTProcSelf());
@@ -584 +588 @@
 static int VBoxDrvDarwinIOCtl(dev_t Dev, u_long iCmd, caddr_t pData, int fFlags, struct proc *pProcess)
 {
+    RT_NOREF(fFlags);
     const bool          fUnrestricted = minor(Dev) == 0;
     const RTPROCESS     Process = proc_pid(pProcess);
@@ -692 +697 @@
 static int VBoxDrvDarwinIOCtlSlow(PSUPDRVSESSION pSession, u_long iCmd, caddr_t pData, struct proc *pProcess)
 {
+    RT_NOREF(pProcess);
     LogFlow(("VBoxDrvDarwinIOCtlSlow: pSession=%p iCmd=%p pData=%p pProcess=%p\n", pSession, iCmd, pData, pProcess));
 
@@ -741 +747 @@
         {
             OSDBGPRINT(("VBoxDrvDarwinIOCtlSlow: bad magic fFlags=%#x; iCmd=%#lx\n", Hdr.fFlags, iCmd));
-            IPRT_DARWIN_SAVE_EFL_AC();
+            IPRT_DARWIN_RESTORE_EFL_AC();
             return EINVAL;
         }
@@ -750 +756 @@
         {
             OSDBGPRINT(("VBoxDrvDarwinIOCtlSlow: max(%#x,%#x); iCmd=%#lx\n", Hdr.cbIn, Hdr.cbOut, iCmd));
-            IPRT_DARWIN_SAVE_EFL_AC();
+            IPRT_DARWIN_RESTORE_EFL_AC();
             return EINVAL;
         }
@@ -959 +965 @@
 static DECLCALLBACK(void) vboxdrvDarwinVmxEnableFix(RTCPUID idCpu, void *pvUser1, void *pvUser2)
 {
+    RT_NOREF(idCpu, pvUser1, pvUser2);
     RTCCUINTREG uCr4 = ASMGetCR4();
     if (!(uCr4 & X86_CR4_VMXE))
@@ -1000 +1007 @@
                 {
                     uint32_t fCaps;
-                    int rc = supdrvQueryVTCapsInternal(&fCaps);
+                    rc = supdrvQueryVTCapsInternal(&fCaps);
                     if (RT_SUCCESS(rc))
                     {
@@ -1314 +1321 @@
 static DECLCALLBACK(void) supdrvDarwinMsrProberModifyOnCpu(RTCPUID idCpu, void *pvUser1, void *pvUser2)
 {
+    RT_NOREF(idCpu, pvUser2);
     PSUPMSRPROBER               pReq    = (PSUPMSRPROBER)pvUser1;
     register uint32_t           uMsr    = pReq->u.In.uMsr;