Changeset 63512 in vbox for trunk

Timestamp:

Aug 15, 2016 11:13:51 PM (8 years ago)

Author:

vboxsync

Message:

VBoxNetFlt: warnings (clang)

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp (modified) (10 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/darwin/VBoxNetFlt-darwin.cpp

@@ -237 +237 @@
 static kern_return_t    VBoxNetFltDarwinStart(struct kmod_info *pKModInfo, void *pvData)
 {
-    int rc;
+    RT_NOREF(pKModInfo, pvData);
 
     /*
@@ -243 +243 @@
      * (IPRT is shared with VBoxDrv, it creates the loggers.)
      */
-    rc = RTR0Init(0);
+    int rc = RTR0Init(0);
     if (RT_SUCCESS(rc))
     {
@@ -283 +283 @@
 static kern_return_t VBoxNetFltDarwinStop(struct kmod_info *pKModInfo, void *pvData)
 {
+    RT_NOREF(pKModInfo, pvData);
     Log(("VBoxNetFltDarwinStop\n"));
 
@@ -569 +570 @@
  * @param   fSrc                The source of the frame.
  */
-DECLINLINE(void) vboxNetFltDarwinMBufToSG(PVBOXNETFLTINS pThis, mbuf_t pMBuf, void *pvFrame, PINTNETSG pSG, unsigned cSegs, uint32_t fSrc)
-{
-    NOREF(pThis);
+DECLINLINE(void) vboxNetFltDarwinMBufToSG(PVBOXNETFLTINS pThis, mbuf_t pMBuf, void *pvFrame, PINTNETSG pSG, unsigned cSegs,
+                                          uint32_t fSrc)
+{
+    RT_NOREF(pThis, fSrc);
 
     /*
@@ -772 +774 @@
 static errno_t vboxNetFltDarwinIffIoCtl(void *pvThis, ifnet_t pIfNet, protocol_family_t eProtocol, u_long uCmd, void *pvArg)
 {
+    RT_NOREF(pIfNet);
     PVBOXNETFLTINS pThis = (PVBOXNETFLTINS)pvThis;
     LogFlow(("vboxNetFltDarwinIffIoCtl: pThis=%p uCmd=%lx\n", pThis, uCmd));
@@ -985 +988 @@
 static errno_t vboxNetFltDarwinIffInput(void *pvThis, ifnet_t pIfNet, protocol_family_t eProtocol, mbuf_t *ppMBuf, char **ppchFrame)
 {
-    NOREF(eProtocol);
-    NOREF(pIfNet);
+    RT_NOREF(eProtocol, pIfNet);
     return vboxNetFltDarwinIffInputOutputWorker((PVBOXNETFLTINS)pvThis, *ppMBuf, *ppchFrame, INTNETTRUNKDIR_WIRE, eProtocol);
 }
@@ -994 +996 @@
 static DECLCALLBACK(int) vboxNetFltSendDummyWorker(RTTHREAD hThreadSelf, void *pvUser)
 {
+    RT_NOREF(hThreadSelf);
     Assert(pvUser);
     ifnet_t pIfNet = (ifnet_t)pvUser;
@@ -1331 +1334 @@
 {
     /* Nothing to do here. */
+    RT_NOREF(pThis);
     return VINF_SUCCESS;
 }
@@ -1338 +1342 @@
 {
     /* Nothing to do here. */
+    RT_NOREF(pThis);
     return VINF_SUCCESS;
 }
@@ -1517 +1522 @@
     }
 
-    struct net_event_data my_link;
     ifnet_t pIfNet = pThis->u.s.pIfNet; /* XXX: retain? */
     ifnet_family_t if_family = ifnet_family(pIfNet);