VirtualBox

Changeset 63562 in vbox for trunk/src/VBox/Devices/Graphics


Ignore:
Timestamp:
Aug 16, 2016 2:04:03 PM (8 years ago)
Author:
vboxsync
Message:

scm: cleaning up todos

Location:
trunk/src/VBox/Devices/Graphics
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/Devices/Graphics/BIOS/vgabios.c

    r53099 r63562  
    144144    outb(0x3C2, 0xC3);
    145145    /* More than 64k 3C4/04. */
    146     //@todo: 16-bit write
     146    /// @todo 16-bit write
    147147    outb(0x3C4, 0x04);
    148148    outb(0x3C5, 0x02);
    … …  
    364364        *chr_atr = read_word(vga_modes[line].sstart, address);
    365365    } else {
    366         //@todo: graphics modes (not so easy - or useful!)
     366        /// @todo graphics modes (not so easy - or useful!)
    367367#ifdef VGA_DEBUG
    368368        unimplemented();
    … …  
    629629}
    630630
    631 //@todo: Evaluate whether executing INT 10h is the right thing here
     631/// @todo Evaluate whether executing INT 10h is the right thing here
    632632extern void vga_font_set(uint8_t function, uint8_t data);
    633633#pragma aux vga_font_set =  \
    … …  
    17851785        size += 3 + 256 * 3 + 1;
    17861786
    1787     //@todo: Is this supposed to be in 1-byte or 64-byte units?
     1787    /// @todo Is this supposed to be in 1-byte or 64-byte units?
    17881788    return size;
    17891789}
    … …  
    20952095#endif
    20962096
    2097 //@todo: rearrange, call only from VBE module?
     2097/// @todo rearrange, call only from VBE module?
    20982098extern void vbe_biosfn_return_controller_information(uint16_t STACK_BASED *AX, uint16_t ES, uint16_t DI);
    20992099extern void vbe_biosfn_return_mode_information(uint16_t STACK_BASED *AX, uint16_t CX, uint16_t ES, uint16_t DI);

  • trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-ogl.cpp

    r63478 r63562  
    15631563        break;
    15641564    case SVGA3D_Z_D15S1:                /* D3DFMT_D15S1 - WINED3DFMT_S1_UINT_D15_UNORM */
    1565         pSurface->internalFormatGL = GL_DEPTH_COMPONENT16;  /* @todo ??? */
     1565        pSurface->internalFormatGL = GL_DEPTH_COMPONENT16;  /** @todo ??? */
    15661566        pSurface->formatGL = GL_DEPTH_STENCIL;
    15671567        pSurface->typeGL = GL_UNSIGNED_SHORT;

  • trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-savedstate.cpp

    r62932 r63562  
    612612                        case SVGA3D_SURFACE_HINT_DEPTHSTENCIL:
    613613                        case SVGA3D_SURFACE_HINT_DEPTHSTENCIL | SVGA3D_SURFACE_HINT_TEXTURE:
    614                             /* @todo unable to easily fetch depth surface data in d3d 9 */
     614                            /** @todo unable to easily fetch depth surface data in d3d 9 */
    615615                            fSkipSave = true;
    616616                            break;
    … …  
    635635                                        IDirect3DSurface9 *pSrc, *pDest;
    636636
    637                                         /* @todo stricter checks for associated context */
     637                                        /** @todo stricter checks for associated context */
    638638                                        uint32_t cid = pSurface->idAssociatedContext;
    639639                                        if (    cid >= pState->cContexts
    … …  
    759759                        case SVGA3D_SURFACE_HINT_DEPTHSTENCIL:
    760760                        case SVGA3D_SURFACE_HINT_DEPTHSTENCIL | SVGA3D_SURFACE_HINT_TEXTURE:
    761                             /* @todo fetch data from the renderbuffer */
     761                            /** @todo fetch data from the renderbuffer */
    762762                            /* No data follows */
    763763                            rc = SSMR3PutBool(pSSM, false);

  • trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-shared.cpp

    r62932 r63562  
    9393    wc.cbClsExtra       = 0;
    9494    wc.cbWndExtra       = 0;
    95     wc.hInstance        = GetModuleHandle("VBoxDD.dll");    /* @todo hardcoded name.. */
     95    wc.hInstance        = GetModuleHandle("VBoxDD.dll");    /** @todo hardcoded name.. */
    9696    wc.hIcon            = LoadIcon(NULL, IDI_APPLICATION);
    9797    wc.hCursor          = LoadCursor(NULL, IDC_ARROW);

  • trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-win.cpp

    r63134 r63562  
    546546
    547547    case SVGA3D_DEVCAP_MAX_SHADER_TEXTURES:
    548         /* @todo ?? */
     548        /** @todo ?? */
    549549        rc = VERR_INVALID_PARAMETER;
    550550        break;
    … …  
    620620        break;
    621621
    622     case SVGA3D_DEVCAP_MAX_RENDER_TARGETS:  /* @todo same thing? */
     622    case SVGA3D_DEVCAP_MAX_RENDER_TARGETS:  /** @todo same thing? */
    623623    case SVGA3D_DEVCAP_MAX_SIMULTANEOUS_RENDER_TARGETS:
    624624        *pu32Val = pCaps->NumSimultaneousRTs;
    … …  
    691691
    692692    case SVGA3D_DEVCAP_SURFACEFMT_Z_D24S8:
    693     case SVGA3D_DEVCAP_SURFACEFMT_Z_D24S8_INT: /* @todo not correct */
     693    case SVGA3D_DEVCAP_SURFACEFMT_Z_D24S8_INT: /** @todo not correct */
    694694        *pu32Val = vmsvga3dGetDepthFormatSupport(pState, idx3dCaps, D3DFMT_D24S8);
    695695        break;
    … …  
    700700
    701701    case SVGA3D_DEVCAP_SURFACEFMT_Z_DF16:
    702         /* @todo supposed to be floating-point, but unable to find a match for D3D9... */
     702        /** @todo supposed to be floating-point, but unable to find a match for D3D9... */
    703703        *pu32Val = 0;
    704704        break;
    … …  
    949949    case SVGA3D_Z_D16:
    950950        return D3DFMT_D16;
    951     case SVGA3D_Z_D24S8_INT:    /* @todo not correct */
     951    case SVGA3D_Z_D24S8_INT:    /** @todo not correct */
    952952    case SVGA3D_Z_D24S8:
    953953        return D3DFMT_D24S8;
    … …  
    958958    /* Advanced D3D9 depth formats. */
    959959    case SVGA3D_Z_DF16:
    960         /* @todo supposed to be floating-point, but unable to find a match for D3D9... */
     960        /** @todo supposed to be floating-point, but unable to find a match for D3D9... */
    961961        AssertFailedReturn(D3DFMT_UNKNOWN);
    962962    case SVGA3D_Z_DF24:
    … …  
    10801080        return D3DMULTISAMPLE_NONE;
    10811081
    1082     /* @todo exact same mapping as d3d? */
     1082    /** @todo exact same mapping as d3d? */
    10831083    return (D3DMULTISAMPLE_TYPE)multisampleCount;
    10841084}
    … …  
    13241324        PVMSVGA3DCONTEXT    pContext;
    13251325
    1326         /* @todo stricter checks for associated context */
     1326        /** @todo stricter checks for associated context */
    13271327        cid = pSurfaceSrc->idAssociatedContext;
    13281328        if (    cid >= pState->cContexts
    … …  
    13461346        IDirect3DTexture9      *pSrcTexture = pSurfaceSrc->u.pTexture;
    13471347
    1348         /* @todo stricter checks for associated context */
     1348        /** @todo stricter checks for associated context */
    13491349        cid = pSurfaceDest->idAssociatedContext;
    13501350        if (    cid >= pState->cContexts
    … …  
    18211821        Rect.bottom = pBox->y + pBox->h;   /* exclusive */
    18221822
    1823         /* @todo inefficient for VRAM buffers!! */
     1823        /** @todo inefficient for VRAM buffers!! */
    18241824        if (fTexture)
    18251825        {
    … …  
    18321832                    IDirect3DSurface9 *pSrc, *pDest;
    18331833
    1834                     /* @todo stricter checks for associated context */
     1834                    /** @todo stricter checks for associated context */
    18351835                    uint32_t cid = pSurface->idAssociatedContext;
    18361836                    if (    cid >= pState->cContexts
    … …  
    18421842                    pContext = pState->papContexts[cid];
    18431843
    1844                     /* @todo only sync when something was actually rendered (since the last sync) */
     1844                    /** @todo only sync when something was actually rendered (since the last sync) */
    18451845                    Log(("vmsvga3dSurfaceDMA: sync bounce buffer\n"));
    18461846                    hr = pSurface->bounce.pTexture->GetSurfaceLevel(uHostMipmap, &pDest);
    … …  
    19011901                if (transfer == SVGA3D_WRITE_HOST_VRAM)
    19021902                {
    1903                     /* @todo stricter checks for associated context */
     1903                    /** @todo stricter checks for associated context */
    19041904                    uint32_t cid = pSurface->idAssociatedContext;
    19051905                    if (    cid >= pState->cContexts
    … …  
    19901990    }
    19911991
    1992     /* @todo Only screen 0 for now. */
     1992    /** @todo Only screen 0 for now. */
    19931993    AssertReturn(dest == 0, VERR_INTERNAL_ERROR);
    19941994    AssertReturn(src.mipmap == 0 && src.face == 0, VERR_INVALID_PARAMETER);
    1995     /* @todo scaling */
     1995    /** @todo scaling */
    19961996    AssertReturn(destRect.right - destRect.left == srcRect.right - srcRect.left && destRect.bottom - destRect.top == srcRect.bottom - srcRect.top, VERR_INVALID_PARAMETER);
    19971997
    … …  
    20352035        dest.pitch      = pThis->svga.cbScanline;
    20362036
    2037         /* @todo merge into one SurfaceDMA call */
     2037        /** @todo merge into one SurfaceDMA call */
    20382038        for (uint32_t i = 0; i < cRects; i++)
    20392039        {
    … …  
    20672067            uint32_t            cid;
    20682068
    2069             /* @todo stricter checks for associated context */
     2069            /** @todo stricter checks for associated context */
    20702070            cid = pSurface->idAssociatedContext;
    20712071
    … …  
    21212121        uint32_t            cid;
    21222122
    2123         /* @todo stricter checks for associated context */
     2123        /** @todo stricter checks for associated context */
    21242124        cid = pSurface->idAssociatedContext;
    21252125
    … …  
    21662166    AssertReturn(pSurface->idAssociatedContext != SVGA3D_INVALID_ID, VERR_INTERNAL_ERROR);
    21672167
    2168     /* @todo stricter checks for associated context */
     2168    /** @todo stricter checks for associated context */
    21692169    cid = pSurface->idAssociatedContext;
    21702170    Log(("vmsvga3dCommandPresent: sid=%x cRects=%d cid=%x\n", sid, cRects, cid));
    … …  
    24712471    PresParam.SwapEffect                    = D3DSWAPEFFECT_FLIP;
    24722472    PresParam.hDeviceWindow                 = pContext->hwnd;
    2473     PresParam.Windowed                      = TRUE;     /* @todo */
     2473    PresParam.Windowed                      = TRUE;     /** @todo */
    24742474    PresParam.EnableAutoDepthStencil        = FALSE;
    24752475    PresParam.AutoDepthStencilFormat        = D3DFMT_UNKNOWN;   /* not relevant */
    24762476    PresParam.Flags                         = 0;
    24772477    PresParam.FullScreen_RefreshRateInHz    = 0;        /* windowed -> 0 */
    2478     /* @todo consider using D3DPRESENT_DONOTWAIT so we don't wait for the GPU during Present calls. */
     2478    /** @todo consider using D3DPRESENT_DONOTWAIT so we don't wait for the GPU during Present calls. */
    24792479    PresParam.PresentationInterval          = D3DPRESENT_INTERVAL_IMMEDIATE;
    24802480
    … …  
    26962696                                IDirect3DSurface9 *pSrc, *pDest;
    26972697
    2698                                 /* @todo only sync when something was actually rendered (since the last sync) */
     2698                                /** @todo only sync when something was actually rendered (since the last sync) */
    26992699                                Log(("vmsvga3dChangeMode: sync bounce buffer (level %d)\n", i));
    27002700                                hr = pSurface->bounce.pTexture->GetSurfaceLevel(i, &pDest);
    … …  
    27402740                    {
    27412741                    case SVGA3D_SURFACE_CUBEMAP:
    2742                         AssertFailed(); /* @todo */
     2742                        AssertFailed(); /** @todo */
    27432743                        break;
    27442744
    … …  
    28092809            PresParam.SwapEffect                    = D3DSWAPEFFECT_FLIP;
    28102810            PresParam.hDeviceWindow                 = pContext->hwnd;
    2811             PresParam.Windowed                      = TRUE;     /* @todo */
     2811            PresParam.Windowed                      = TRUE;     /** @todo */
    28122812            PresParam.EnableAutoDepthStencil        = FALSE;
    28132813            PresParam.AutoDepthStencilFormat        = D3DFMT_UNKNOWN;   /* not relevant */
    28142814            PresParam.Flags                         = 0;
    28152815            PresParam.FullScreen_RefreshRateInHz    = 0;        /* windowed -> 0 */
    2816             /* @todo consider using D3DPRESENT_DONOTWAIT so we don't wait for the GPU during Present calls. */
     2816            /** @todo consider using D3DPRESENT_DONOTWAIT so we don't wait for the GPU during Present calls. */
    28172817            PresParam.PresentationInterval          = D3DPRESENT_INTERVAL_IMMEDIATE;;
    28182818
    … …  
    30073007
    30083008    Log(("vmsvga3dSetZRange: old viewport settings (%d,%d)(%d,%d) z=%d/%d\n", viewport.X, viewport.Y, viewport.Width, viewport.Height, (uint32_t)(viewport.MinZ * 100.0), (uint32_t)(viewport.MaxZ * 100.0)));
    3009     /* @todo convert the depth range from -1-1 to 0-1 although we shouldn't be getting such values in the first place... */
     3009    /** @todo convert the depth range from -1-1 to 0-1 although we shouldn't be getting such values in the first place... */
    30103010    if (zRange.min < 0.0)
    30113011        zRange.min = 0.0;
    … …  
    32933293                break;
    32943294            }
    3295             /* @todo ignoring face for now. */
     3295            /** @todo ignoring face for now. */
    32963296            renderState = D3DRS_FILLMODE;
    32973297            break;
    … …  
    33063306        case SVGA3D_RS_LINEPATTERN:            /* SVGA3dLinePattern */
    33073307            /* No longer supported by d3d; mesagl comments suggest not all backends support it */
    3308             /* @todo */
     3308            /** @todo */
    33093309            Log(("WARNING: SVGA3D_RS_LINEPATTERN %x not supported!!\n", pRenderState[i].uintValue));
    33103310            /*
    … …  
    34233423        case SVGA3D_RS_COORDINATETYPE:         /* SVGA3dCoordinateType */
    34243424            Assert(pRenderState[i].uintValue == SVGA3D_COORDINATE_LEFTHANDED);
    3425             /* @todo setup a view matrix to scale the world space by -1 in the z-direction for right handed coordinates. */
     3425            /** @todo setup a view matrix to scale the world space by -1 in the z-direction for right handed coordinates. */
    34263426            /*
    34273427            renderState = D3DRS_COORDINATETYPE;
    … …  
    34313431
    34323432        case SVGA3D_RS_ZBIAS:                  /* float */
    3433             /* @todo unknown meaning; depth bias is not identical
     3433            /** @todo unknown meaning; depth bias is not identical
    34343434            renderState = D3DRS_DEPTHBIAS;
    34353435            val = pRenderState[i].uintValue;
    … …  
    39083908        Assert(pRenderTarget->idAssociatedContext == cid);
    39093909
    3910         /* @todo Assert(!pRenderTarget->fDirty); */
     3910        /** @todo Assert(!pRenderTarget->fDirty); */
    39113911
    39123912        AssertReturn(pRenderTarget->u.pSurface, VERR_INVALID_PARAMETER);
    … …  
    40864086        return D3DTOP_MODULATE4X;
    40874087    case SVGA3D_TC_DSDT:
    4088         AssertFailed(); /* @todo ??? */
     4088        AssertFailed(); /** @todo ??? */
    40894089        return D3DTOP_DISABLE;
    40904090    case SVGA3D_TC_DOTPRODUCT3:
    … …  
    41514151        return D3DTTFF_DISABLE;
    41524152    case SVGA3D_TEX_TRANSFORM_S:
    4153         return D3DTTFF_COUNT1;      /* @todo correct? */
     4153        return D3DTTFF_COUNT1;      /** @todo correct? */
    41544154    case SVGA3D_TEX_TRANSFORM_T:
    4155         return D3DTTFF_COUNT2;      /* @todo correct? */
     4155        return D3DTTFF_COUNT2;      /** @todo correct? */
    41564156    case SVGA3D_TEX_TRANSFORM_R:
    4157         return D3DTTFF_COUNT3;      /* @todo correct? */
     4157        return D3DTTFF_COUNT3;      /** @todo correct? */
    41584158    case SVGA3D_TEX_TRANSFORM_Q:
    4159         return D3DTTFF_COUNT4;      /* @todo correct? */
     4159        return D3DTTFF_COUNT4;      /** @todo correct? */
    41604160    case SVGA3D_TEX_PROJECTED:
    41614161        return D3DTTFF_PROJECTED;
    … …  
    44654465
    44664466    /* @note face not used for D3D9 */
    4467     /* @todo ignore everything except SVGA3D_FACE_NONE? */
     4467    /** @todo ignore everything except SVGA3D_FACE_NONE? */
    44684468    //Assert(face == SVGA3D_FACE_NONE);
    44694469    if (face != SVGA3D_FACE_NONE)
    … …  
    48864886    AssertReturn(numRanges && numRanges <= SVGA3D_MAX_DRAW_PRIMITIVE_RANGES, VERR_INVALID_PARAMETER);
    48874887    AssertReturn(!cVertexDivisor || cVertexDivisor == numVertexDecls, VERR_INVALID_PARAMETER);
    4888     /* @todo */
     4888    /** @todo */
    48894889    Assert(!cVertexDivisor);
    48904890
    … …  
    50745074        else
    50755075        {
    5076             Assert(pRange[iPrimitive].indexBias >= 0);  /* @todo */
     5076            Assert(pRange[iPrimitive].indexBias >= 0);  /** @todo */
    50775077
    50785078            UINT numVertices;

  • trunk/src/VBox/Devices/Graphics/DevVGA.cpp

    r63480 r63562  
    21062106
    21072107#if 0 //def VBOX_WITH_VDMA
    2108     /** @todo: we get a second resize here when VBVA is on, while we actually should not */
     2108    /** @todo we get a second resize here when VBVA is on, while we actually should not */
    21092109    /* do not do pfnResize in case VBVA is on since all mode changes are performed over VBVA
    21102110     * we are checking for VDMA state here to ensure this code works only for WDDM driver,

  • trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp

    r62928 r63562  
    617617        if (!fRestored)
    618618        {
    619             /* @todo Actually this function must not touch the partialRecord structure at all,
     619            /** @todo Actually this function must not touch the partialRecord structure at all,
    620620             * because initially it is a zero and when VBVA is disabled this should be set to zero.
    621621             * But I'm not sure that no code depends on zeroing partialRecord here.
    … …  
    12011201                if(rc == VERR_NOT_IMPLEMENTED)
    12021202                {
    1203                     /* @todo: set some flag in pVGAState indicating VHWA is not supported */
     1203                    /** @todo set some flag in pVGAState indicating VHWA is not supported */
    12041204                    /* VERR_NOT_IMPLEMENTED is not a failure, we just do not support it */
    12051205                    rc = VINF_SUCCESS;
    … …  
    13161316}
    13171317
    1318 /* @todo call this also on reset? */
     1318/** @todo call this also on reset? */
    13191319int vbvaVHWAEnable (PVGASTATE pVGAState, bool bEnable)
    13201320{
    … …  
    21232123    else if (u32Index == VBOX_VBVA_CONF32_HOST_HEAP_SIZE)
    21242124    {
    2125         /* @todo a value calculated from the vram size */
     2125        /** @todo a value calculated from the vram size */
    21262126        pConf32->u32Value = 64*_1K;
    21272127    }

  • trunk/src/VBox/Devices/Graphics/DevVGA_VDMA.cpp

    r63549 r63562  
    25462546                }
    25472547# endif
    2548                 /* todo: post the buffer to chromium */
     2548                /** @todo post the buffer to chromium */
    25492549                return VINF_SUCCESS;
    25502550            }
    … …  
    26802680            if (offset + pCmd->cbBuf > 0x1000)
    26812681            {
    2682                 /* @todo: more advanced mechanism of command buffer proc is actually needed */
     2682                /** @todo more advanced mechanism of command buffer proc is actually needed */
    26832683                rc = VERR_INVALID_PARAMETER;
    26842684                break;
    … …  
    26902690            if (!RT_SUCCESS(rc))
    26912691            {
    2692                 /* @todo: if (rc == VERR_PGM_PHYS_PAGE_RESERVED) -> fall back on using PGMPhysRead ?? */
     2692                /** @todo if (rc == VERR_PGM_PHYS_PAGE_RESERVED) -> fall back on using PGMPhysRead ?? */
    26932693                break;
    26942694            }
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette