Changeset 63562 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Aug 16, 2016 2:04:03 PM (8 years ago)

Author:

vboxsync

Message:

scm: cleaning up todos

Location:

trunk/src/VBox/Devices/Network

Files:

• DevE1000.cpp (modified) (7 diffs)
• DevINIP.cpp (modified) (1 diff)
• DevPCNet.cpp (modified) (1 diff)
• DevVirtioNet.cpp (modified) (1 diff)
• SrvIntNetR0.cpp (modified) (1 diff)
• lwip-new/vbox/VBoxLwipCore.cpp (modified) (2 diffs)
• lwip-new/vbox/sys_arch.c (modified) (1 diff)
• slirp/bootp.c (modified) (1 diff)
• slirp/ip_input.c (modified) (1 diff)
• slirp/libalias/alias.c (modified) (1 diff)
• slirp/slirp.c (modified) (3 diffs)
• slirp/socket.c (modified) (1 diff)
• slirp/tcp_input.c (modified) (1 diff)
• slirp/tcp_subr.c (modified) (1 diff)
• slirp/tftp.c (modified) (1 diff)
• slirp/udp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -3466 +3466 @@
     else
     {
-        pGso->cbHdrsSeg = pCtx->dw3.u8HDRLEN; /* @todo IPv6 UFO */
+        pGso->cbHdrsSeg = pCtx->dw3.u8HDRLEN; /** @todo IPv6 UFO */
         if (pCtx->dw2.fTCP)
             pGso->u8Type = PDMNETWORKGSOTYPE_IPV6_TCP;
@@ -5123 +5123 @@
         }
 
-        /// @todo: uncomment: pThis->uStatIntTXQE++;
-        /// @todo: uncomment: e1kRaiseInterrupt(pThis, ICR_TXQE);
+        /// @todo uncomment: pThis->uStatIntTXQE++;
+        /// @todo uncomment: e1kRaiseInterrupt(pThis, ICR_TXQE);
         /*
          * Release the lock.
@@ -5287 +5287 @@
         STAM_PROFILE_ADV_STOP(&pThis->CTX_SUFF_Z(StatTransmit), a);
 
-        /// @todo: uncomment: pThis->uStatIntTXQE++;
-        /// @todo: uncomment: e1kRaiseInterrupt(pThis, ICR_TXQE);
+        /// @todo uncomment: pThis->uStatIntTXQE++;
+        /// @todo uncomment: e1kRaiseInterrupt(pThis, ICR_TXQE);
 
         e1kCsTxLeave(pThis);
@@ -6688 +6688 @@
 #endif
 #endif /* E1K_WITH_TXD_CACHE */
-/**@todo GSO requires some more state here. */
+/** @todo GSO requires some more state here. */
     E1kLog(("%s State has been saved\n", pThis->szPrf));
     return VINF_SUCCESS;
@@ -6770 +6770 @@
         SSMR3GetMem(pSSM, &pThis->auRegs, sizeof(pThis->auRegs));
         SSMR3GetBool(pSSM, &pThis->fIntRaised);
-        /** @todo: PHY could be made a separate device with its own versioning */
+        /** @todo PHY could be made a separate device with its own versioning */
         Phy::loadState(pSSM, &pThis->phy);
         SSMR3GetU32(pSSM, &pThis->uSelectedReg);
@@ -7181 +7181 @@
     PDMCritSectEnter(&pThis->cs, VERR_SEM_BUSY);
 
-    /** @todo: r=pritesh still need to check if i missed
+    /** @todo r=pritesh still need to check if i missed
      * to clean something in this function
      */
@@ -7518 +7518 @@
                                 N_("Invalid configuration for E1000 device"));
 
-    /** @todo: LineSpeed unused! */
+    /** @todo LineSpeed unused! */
 
     pThis->fR0Enabled    = true;

trunk/src/VBox/Devices/Network/DevINIP.cpp

@@ -284 +284 @@
         PDMDEV_SET_ERROR(pDevIns, rc,
                          N_("Configuration error: Failed to get the \"IP\" value"));
-        /* @todo: perhaps we should panic if IPv4 address isn't specify, with assumtion that
+        /** @todo perhaps we should panic if IPv4 address isn't specify, with assumtion that
          * ISCSI target specified in IPv6 form.
          */

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -4712 +4712 @@
     PDMCritSectEnter(&pThis->CritSect, VERR_SEM_BUSY);
 
-    /** @todo: r=pritesh still need to check if i missed
+    /** @todo r=pritesh still need to check if i missed
      * to clean something in this function
      */

trunk/src/VBox/Devices/Network/DevVirtioNet.cpp

@@ -471 +471 @@
     vnetCsRxLeave(pThis);
 
-    // TODO: Implement reset
+    /// @todo Implement reset
     if (pThis->fCableConnected)
         STATUS = VNET_S_LINK_UP;

trunk/src/VBox/Devices/Network/SrvIntNetR0.cpp

@@ -6228 +6228 @@
             if (   enmTrunkType == kIntNetTrunkType_WhateverNone
 #ifdef VBOX_WITH_NAT_SERVICE
-                || enmTrunkType == kIntNetTrunkType_SrvNat /* @todo: what does it mean */
+                || enmTrunkType == kIntNetTrunkType_SrvNat /** @todo what does it mean */
 #endif
                 || (   pCur->enmTrunkType == enmTrunkType

trunk/src/VBox/Devices/Network/lwip-new/vbox/VBoxLwipCore.cpp

@@ -28 +28 @@
 #include <iprt/types.h>
 #include "VBoxLwipCore.h"
-/* @todo: lwip or nat ? */
+/** @todo lwip or nat ? */
 #define LOG_GROUP LOG_GROUP_DRV_NAT
 #include <iprt/cpp/lock.h>
@@ -155 +155 @@
     if (lwipRc != ERR_OK)
     {
-        /* @todo: map lwip error code? */
+        /** @todo map lwip error code? */
         rc = VERR_INTERNAL_ERROR;
     }

trunk/src/VBox/Devices/Network/lwip-new/vbox/sys_arch.c

@@ -64 +64 @@
 
 /** Actual declaration of the mbox type. */
-/* @todo: magic - ??? */
+/** @todo magic - ??? */
 struct sys_mbox
 {

trunk/src/VBox/Devices/Network/slirp/bootp.c

@@ -67 +67 @@
     uint8_t *q = vend;
     uint8_t len;
-    /*@todo magic validation */
+    /** @todo magic validation */
     q += 4; /*magic*/
     while(*q != RFC1533_END)

trunk/src/VBox/Devices/Network/slirp/ip_input.c

@@ -660 +660 @@
     register caddr_t opts;
     int olen;
-    NOREF(mopt); /* @todo: do we really will need this options buffer? */
+    NOREF(mopt); /** @todo do we really will need this options buffer? */
 
     olen = (ip->ip_hl<<2) - sizeof(struct ip);

trunk/src/VBox/Devices/Network/slirp/libalias/alias.c

@@ -1579 +1579 @@
 LibAliasRefreshModules(void)
 {
-    /* @todo (r - vasily) here should be module loading */
+    /** @todo (r - vasily) here should be module loading */
 #ifndef VBOX
     char buf[256], conf[] = "/etc/libalias.conf";

trunk/src/VBox/Devices/Network/slirp/slirp.c

@@ -373 +373 @@
     pData->slirp_ethaddr = &special_ethaddr[0];
     alias_addr.s_addr = pData->special_addr.s_addr | RT_H2N_U32_C(CTL_ALIAS);
-    /* @todo: add ability to configure this staff */
+    /** @todo add ability to configure this staff */
 
     /*
@@ -418 +418 @@
     }
 #ifdef VBOX_WITH_NAT_SEND2HOME
-    /* @todo: we should know all interfaces available on host. */
+    /** @todo we should know all interfaces available on host. */
     pData->pInSockAddrHomeAddress = RTMemAllocZ(sizeof(struct sockaddr));
     pData->cInHomeAddressSize = 1;
@@ -734 +734 @@
          * receive more, and we have room for it XXX /2 ?
          */
-        /* @todo: vvl - check which predicat here will be more useful here in rerm of new sbufs. */
+        /** @todo vvl - check which predicat here will be more useful here in rerm of new sbufs. */
         if (   CONN_CANFRCV(so)
             && (SBUF_LEN(&so->so_snd) < (SBUF_SIZE(&so->so_snd)/2))

trunk/src/VBox/Devices/Network/slirp/socket.c

@@ -115 +115 @@
         AssertReturn((pNewSocket, false));
         pData->pInSockAddrHomeAddress[idxAddr].sin_port = pSo->so_fport;
-        /* @todo: more verbose on errors,
+        /** @todo more verbose on errors,
          * @note: we shouldn't care if this send fail or not (we're in broadcast).
          */

trunk/src/VBox/Devices/Network/slirp/tcp_input.c

@@ -481 +481 @@
     {
         QSOCKET_UNLOCK(tcb);
-        /* @todo fix SOLOOKUP macrodefinition to be usable here */
+        /** @todo fix SOLOOKUP macrodefinition to be usable here */
         so = solookup(&tcb, ti->ti_src, ti->ti_sport,
                       ti->ti_dst, ti->ti_dport);

trunk/src/VBox/Devices/Network/slirp/tcp_subr.c

@@ -562 +562 @@
     if (cVerbose > 0)
         LogRel(("NAT: Old socket recv size: %dKB\n", opt / 1024));
-    /* @todo (r-vvl) make it configurable (via extra data) */
+    /** @todo (r-vvl) make it configurable (via extra data) */
     opt = pData->socket_rcv;
     status = setsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, sizeof(int));

trunk/src/VBox/Devices/Network/slirp/tftp.c

@@ -303 +303 @@
                 rc = tftpSessionParseAndMarkOption(pszTftpRRQRaw, &pTftpSession->OptionTSize);
 
-            /* @todo: we don't use timeout, but its value in the range 0-255 */
+            /** @todo we don't use timeout, but its value in the range 0-255 */
             if (   RT_SUCCESS(rc)
                 && !RTStrICmp("timeout", g_TftpDesc[idxOptionArg].pszName))
                 rc = tftpSessionParseAndMarkOption(pszTftpRRQRaw, &pTftpSession->OptionTimeout);
 
-            /* @todo: unknown option detection */
+            /** @todo unknown option detection */
             if (RT_FAILURE(rc))
             {

trunk/src/VBox/Devices/Network/slirp/udp.c

@@ -686 +686 @@
     /* The original check was completely broken, as the commented out
      * if statement was always true (INADDR_ANY=0). */
-    /* @todo: vvl - alias_addr should be set (if required)
+    /** @todo vvl - alias_addr should be set (if required)
      * later by liabalias module.
      */