Changeset 63562 in vbox for trunk/src/VBox/Devices/Network/slirp

Timestamp:

Aug 16, 2016 2:04:03 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

110217

Message:

scm: cleaning up todos

Location:

trunk/src/VBox/Devices/Network/slirp

Files:

• bootp.c (modified) (1 diff)
• ip_input.c (modified) (1 diff)
• libalias/alias.c (modified) (1 diff)
• slirp.c (modified) (3 diffs)
• socket.c (modified) (1 diff)
• tcp_input.c (modified) (1 diff)
• tcp_subr.c (modified) (1 diff)
• tftp.c (modified) (1 diff)
• udp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/bootp.c

@@ -67 +67 @@
     uint8_t *q = vend;
     uint8_t len;
-    /*@todo magic validation */
+    /** @todo magic validation */
     q += 4; /*magic*/
     while(*q != RFC1533_END)

trunk/src/VBox/Devices/Network/slirp/ip_input.c

@@ -660 +660 @@
     register caddr_t opts;
     int olen;
-    NOREF(mopt); /* @todo: do we really will need this options buffer? */
+    NOREF(mopt); /** @todo do we really will need this options buffer? */
 
     olen = (ip->ip_hl<<2) - sizeof(struct ip);

trunk/src/VBox/Devices/Network/slirp/libalias/alias.c

@@ -1579 +1579 @@
 LibAliasRefreshModules(void)
 {
-    /* @todo (r - vasily) here should be module loading */
+    /** @todo (r - vasily) here should be module loading */
 #ifndef VBOX
     char buf[256], conf[] = "/etc/libalias.conf";

trunk/src/VBox/Devices/Network/slirp/slirp.c

@@ -373 +373 @@
     pData->slirp_ethaddr = &special_ethaddr[0];
     alias_addr.s_addr = pData->special_addr.s_addr | RT_H2N_U32_C(CTL_ALIAS);
-    /* @todo: add ability to configure this staff */
+    /** @todo add ability to configure this staff */
 
     /*
@@ -418 +418 @@
     }
 #ifdef VBOX_WITH_NAT_SEND2HOME
-    /* @todo: we should know all interfaces available on host. */
+    /** @todo we should know all interfaces available on host. */
     pData->pInSockAddrHomeAddress = RTMemAllocZ(sizeof(struct sockaddr));
     pData->cInHomeAddressSize = 1;
@@ -734 +734 @@
          * receive more, and we have room for it XXX /2 ?
          */
-        /* @todo: vvl - check which predicat here will be more useful here in rerm of new sbufs. */
+        /** @todo vvl - check which predicat here will be more useful here in rerm of new sbufs. */
         if (   CONN_CANFRCV(so)
             && (SBUF_LEN(&so->so_snd) < (SBUF_SIZE(&so->so_snd)/2))

trunk/src/VBox/Devices/Network/slirp/socket.c

@@ -115 +115 @@
         AssertReturn((pNewSocket, false));
         pData->pInSockAddrHomeAddress[idxAddr].sin_port = pSo->so_fport;
-        /* @todo: more verbose on errors,
+        /** @todo more verbose on errors,
          * @note: we shouldn't care if this send fail or not (we're in broadcast).
          */

trunk/src/VBox/Devices/Network/slirp/tcp_input.c

@@ -481 +481 @@
     {
         QSOCKET_UNLOCK(tcb);
-        /* @todo fix SOLOOKUP macrodefinition to be usable here */
+        /** @todo fix SOLOOKUP macrodefinition to be usable here */
         so = solookup(&tcb, ti->ti_src, ti->ti_sport,
                       ti->ti_dst, ti->ti_dport);

trunk/src/VBox/Devices/Network/slirp/tcp_subr.c

@@ -562 +562 @@
     if (cVerbose > 0)
         LogRel(("NAT: Old socket recv size: %dKB\n", opt / 1024));
-    /* @todo (r-vvl) make it configurable (via extra data) */
+    /** @todo (r-vvl) make it configurable (via extra data) */
     opt = pData->socket_rcv;
     status = setsockopt(s, SOL_SOCKET, SO_RCVBUF, (char *)&opt, sizeof(int));

trunk/src/VBox/Devices/Network/slirp/tftp.c

@@ -303 +303 @@
                 rc = tftpSessionParseAndMarkOption(pszTftpRRQRaw, &pTftpSession->OptionTSize);
 
-            /* @todo: we don't use timeout, but its value in the range 0-255 */
+            /** @todo we don't use timeout, but its value in the range 0-255 */
             if (   RT_SUCCESS(rc)
                 && !RTStrICmp("timeout", g_TftpDesc[idxOptionArg].pszName))
                 rc = tftpSessionParseAndMarkOption(pszTftpRRQRaw, &pTftpSession->OptionTimeout);
 
-            /* @todo: unknown option detection */
+            /** @todo unknown option detection */
             if (RT_FAILURE(rc))
             {

trunk/src/VBox/Devices/Network/slirp/udp.c

@@ -686 +686 @@
     /* The original check was completely broken, as the commented out
      * if statement was always true (INADDR_ANY=0). */
-    /* @todo: vvl - alias_addr should be set (if required)
+    /** @todo vvl - alias_addr should be set (if required)
      * later by liabalias module.
      */