VirtualBox

Changeset 63566 in vbox


Ignore:
Timestamp:
Aug 16, 2016 2:05:58 PM (8 years ago)
Author:
vboxsync
Message:

scm: cleaning up todos

Location:
trunk/src/VBox/Additions
Files:
39 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/wddm/VBoxD3DIf.cpp

    r63018 r63566  
    2222D3DFORMAT vboxDDI2D3DFormat(D3DDDIFORMAT format)
    2323{
    24     /* @todo: check they are all equal */
     24    /** @todo check they are all equal */
    2525    return (D3DFORMAT)format;
    2626}
    … …  
    2828D3DMULTISAMPLE_TYPE vboxDDI2D3DMultiSampleType(D3DDDIMULTISAMPLE_TYPE enmType)
    2929{
    30     /* @todo: check they are all equal */
     30    /** @todo check they are all equal */
    3131    return (D3DMULTISAMPLE_TYPE)enmType;
    3232}
    … …  
    3434D3DPOOL vboxDDI2D3DPool(D3DDDI_POOL enmPool)
    3535{
    36     /* @todo: check they are all equal */
     36    /** @todo check they are all equal */
    3737    switch (enmPool)
    3838    {
    … …  
    4242    case D3DDDIPOOL_LOCALVIDMEM:
    4343    case D3DDDIPOOL_NONLOCALVIDMEM:
    44         /* @todo: what would be proper here? */
     44        /** @todo what would be proper here? */
    4545        return D3DPOOL_DEFAULT;
    4646    default:
    … …  
    5252D3DRENDERSTATETYPE vboxDDI2D3DRenderStateType(D3DDDIRENDERSTATETYPE enmType)
    5353{
    54     /* @todo: @fixme: not entirely correct, need to check */
     54    /** @todo @fixme: not entirely correct, need to check */
    5555    return (D3DRENDERSTATETYPE)enmType;
    5656}
    … …  
    677677                    vboxDDI2D3DMultiSampleType(pRc->RcDesc.enmMultisampleType),
    678678                    pRc->RcDesc.MultisampleQuality,
    679                     TRUE /* @todo: BOOL Discard */,
     679                    TRUE /** @todo BOOL Discard */,
    680680                    &pD3D9Surf,
    681681                    NULL /*HANDLE* pSharedHandle*/);

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/wddm/VBoxDispD3D.cpp

    r63105 r63566  
    10031003            /* bad, @todo: correct the swapchain by either removing the Rt and adding it to another swapchain
    10041004             * or by removing the pBbAlloc out of it */
    1005 //@todo:            Assert(0);
     1005/// @todo            Assert(0);
    10061006
    10071007            PVBOXWDDMDISP_RENDERTGT pRt = vboxWddmSwapchainRtForAlloc(pSwapchain, pBbAlloc);
    … …  
    11401140                    /* the swapchain has changed, copy data to the new surface */
    11411141#ifdef DEBUG_misha
    1142                     /* @todo: we can not generally update the render target directly, implement */
     1142                    /** @todo we can not generally update the render target directly, implement */
    11431143                    Assert(iBb != (~0));
    11441144#endif
    … …  
    14871487
    14881488            Params.Base.hDeviceWindow = NULL;
    1489                         /* @todo: it seems there should be a way to detect this correctly since
     1489                        /** @todo it seems there should be a way to detect this correctly since
    14901490                         * our vboxWddmDDevSetDisplayMode will be called in case we are using full-screen */
    14911491            Params.Base.Windowed = TRUE;
    … …  
    17571757        }
    17581758
    1759 //@todo:        Assert(!pSwapchain->fFlags.bChanged);
     1759/// @todo        Assert(!pSwapchain->fFlags.bChanged);
    17601760        Assert(pSwapchain->pSwapChainIf);
    17611761        hr = vboxWddmSwapchainChkCreateIf(pDevice, pSwapchain);
    … …  
    17671767    }
    17681768
    1769 //@todo:    Assert(vboxWddmSwapchainGetBb(pSwapchain)->pAlloc == pAlloc || iRt != 0);
     1769/// @todo    Assert(vboxWddmSwapchainGetBb(pSwapchain)->pAlloc == pAlloc || iRt != 0);
    17701770    IDirect3DSurface9 *pSurf;
    17711771    hr = vboxWddmSwapchainSurfGet(pDevice, pSwapchain, pAlloc, &pSurf);
    … …  
    19571957    else
    19581958    {
    1959         /* @todo This is workaround for wine 1 render target. */
     1959        /** @todo This is workaround for wine 1 render target. */
    19601960        if (!pAlloc)
    19611961        {
    … …  
    23632363    vboxVDbgPrintF(("<== "__FUNCTION__", hDevice(0x%p)\n", hDevice));
    23642364#ifdef DEBUG_misha
    2365     /* @todo: check if it's ok to always return success */
     2365    /** @todo check if it's ok to always return success */
    23662366    vboxVDbgPrint((__FUNCTION__": @todo: check if it's ok to always return success\n"));
    23672367    Assert(0);
    … …  
    26712671        else
    26722672        {
    2673             /* todo: impl */
     2673            /** @todo impl */
    26742674            WARN(("multiple user stream sources (%d) not implemented!!", pDevice->cStreamSourcesUm));
    26752675        }
    … …  
    32303230    VBOXDISPCRHGSMI_SCOPE_SET_DEV(pDevice);
    32313231    Assert(0);
    3232 //    @todo: vboxWddmDalCheckAdd(pDevice);
     3232/// @todo vboxWddmDalCheckAdd(pDevice);
    32333233    vboxVDbgPrintF(("==> "__FUNCTION__", hDevice(0x%p)\n", hDevice));
    32343234    return E_FAIL;
    … …  
    53375337    if (hr != S_OK)
    53385338    {
    5339         /* todo: fallback to memcpy or whatever ? */
     5339        /** @todo fallback to memcpy or whatever ? */
    53405340        Assert(0);
    53415341    }
    … …  
    53685368        hr = pDevice9If->ColorFill(pSurfIf, &pData->DstRect, pData->Color);
    53695369        Assert(hr == S_OK);
    5370         /* @todo: check what need to do when PresentToDwm flag is set */
     5370        /** @todo check what need to do when PresentToDwm flag is set */
    53715371        Assert(pData->Flags.Value == 0);
    53725372
    … …  
    53885388    VBOXDISPCRHGSMI_SCOPE_SET_DEV(pDevice);
    53895389    Assert(0);
    5390 //@todo:    vboxWddmDalCheckAdd(pDevice, pDAlloc, TRUE);
     5390/// @todo    vboxWddmDalCheckAdd(pDevice, pDAlloc, TRUE);
    53915391    vboxVDbgPrintF(("==> "__FUNCTION__", hDevice(0x%p)\n", hDevice));
    53925392    return E_FAIL;
    … …  
    60886088
    60896089    HRESULT hr = S_OK;
    6090     /* @todo check residency for the "real" allocations */
     6090    /** @todo check residency for the "real" allocations */
    60916091#if 0
    60926092    for (UINT i = 0; i < pData->NumResources; ++i)
    … …  
    64546454                            params.SwapEffect = D3DSWAPEFFECT_DISCARD;
    64556455        //                    params.hDeviceWindow = hWnd;
    6456                                         /* @todo: it seems there should be a way to detect this correctly since
     6456                                        /** @todo it seems there should be a way to detect this correctly since
    64576457                                         * our vboxWddmDDevSetDisplayMode will be called in case we are using full-screen */
    64586458                            params.Windowed = TRUE;

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/wddm/VBoxUhgsmiBase.cpp

    r63033 r63566  
    5858        {
    5959            /*DWORD winEr = GetLastError(); - unused */
    60             /* todo: translate winer */
     60            /** @todo translate winer */
    6161            return VERR_GENERAL_FAILURE;
    6262        }

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/xpdm/VBoxDispDDraw.cpp

    r63058 r63566  
    195195
    196196
    197                     /*@todo: it's probably a memory leak, because DDDestroySurface wouldn't be called for
     197                    /** @todo it's probably a memory leak, because DDDestroySurface wouldn't be called for
    198198                     *       primary surfaces.
    199199                     */

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/xpdm/VBoxDispDriver.cpp

    r63058 r63566  
    288288    pGdiInfo->ulNumPalReg = (pDev->mode.ulBitsPerPel==8) ? (1<<pDev->mode.ulBitsPerPel) : 0;
    289289
    290     /* @todo: might want to implement IOCTL_VIDEO_QUERY_COLOR_CAPABILITIES in miniport driver
     290    /** @todo might want to implement IOCTL_VIDEO_QUERY_COLOR_CAPABILITIES in miniport driver
    291291     *        and query host for this info there
    292292     */
    … …  
    393393BOOL DrvEnableDriver(ULONG iEngineVersion, ULONG cj, PDRVENABLEDATA pded)
    394394{
    395     /*@todo: can't link with hal.lib
     395    /** @todo can't link with hal.lib
    396396    int irc = RTR0Init(0);
    397397    if (RT_FAILURE(irc))
    … …  
    607607
    608608    /* Clear mapped memory, to avoid garbage while video mode is switching */
    609     /* @todo: VIDEO_MODE_NO_ZERO_MEMORY does nothing in miniport's IOCTL_VIDEO_SET_CURRENT_MODE*/
     609    /** @todo VIDEO_MODE_NO_ZERO_MEMORY does nothing in miniport's IOCTL_VIDEO_SET_CURRENT_MODE*/
    610610    memset(pDev->memInfo.FrameBufferBase, 0, pDev->mode.ulHeight * abs(pDev->mode.lScanlineStride));
    611611

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/xpdm/VBoxDispVHWA.cpp

    r63061 r63566  
    141141    }
    142142
    143     /* @todo: temporary hack */
     143    /** @todo temporary hack */
    144144    VBoxDispVHWACommandCheckHostCmds(pDev);
    145145
    … …  
    660660void VBoxDispVHWAFromDDOVERLAYFX(VBOXVHWA_OVERLAYFX *pVHWAOverlay, DDOVERLAYFX *pDdOverlay)
    661661{
    662     //TODO: fxFlags
     662    /// @todo fxFlags
    663663    VBoxDispVHWAFromDDCOLORKEY(&pVHWAOverlay->DstCK, &pDdOverlay->dckDestColorkey);
    664664    VBoxDispVHWAFromDDCOLORKEY(&pVHWAOverlay->SrcCK, &pDdOverlay->dckSrcColorkey);

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/disp/xpdm/VBoxDispVRDP.cpp

    r63061 r63566  
    13861386        if (ROP3_NEED_SRC(rop4))
    13871387        {
    1388             /* @todo Three way blt. RDP_ORDER_TRIBLT. */
     1388            /** @todo Three way blt. RDP_ORDER_TRIBLT. */
    13891389            LOG(("TRIBLT pbo->iSolidColor = 0x%08X.", pbo->iSolidColor));
    13901390            vrdpReportDirtyRects(pDev, &clipRects);
    … …  
    14321432                    else
    14331433                    {
    1434                         /* @todo BITMAPCACHE followed by MEMBLT? */
     1434                        /** @todo BITMAPCACHE followed by MEMBLT? */
    14351435                        vrdpReportDirtyRects(pDev, &clipRects);
    14361436                    }

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPMisc.cpp

    r63062 r63566  
    510510        /* do not zero up the view rect since it may still be valid */
    511511//        memset(&pSwapchain->ViewRect, 0, sizeof (pSwapchain->ViewRect));
    512         /* @todo: do we really need to zero this up here ? */
     512        /** @todo do we really need to zero this up here ? */
    513513        VBoxVrListClear(&pSwapchain->VisibleRegions);
    514514
    … …  
    14631463    {
    14641464        Assert(0);
    1465         /* @todo: try flushing.. */
     1465        /** @todo try flushing.. */
    14661466        LOGREL(("vboxVdmaCBufDrCreate returned NULL"));
    14671467        Status = STATUS_INSUFFICIENT_RESOURCES;

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPVModes.cpp

    r63057 r63566  
    622622    else
    623623    {
    624         /* @todo: try flushing.. */
     624        /** @todo try flushing.. */
    625625        WARN(("vboxVdmaCBufDrCreate returned NULL"));
    626626        Status = STATUS_INSUFFICIENT_RESOURCES;

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPVbva.cpp

    r63242 r63566  
    751751            notify.InterruptType = DXGK_INTERRUPT_DMA_FAULTED;
    752752            notify.DmaFaulted.FaultedFenceId = u32FenceId;
    753             notify.DmaFaulted.Status = STATUS_UNSUCCESSFUL; /* @todo: better status ? */
     753            notify.DmaFaulted.Status = STATUS_UNSUCCESSFUL; /** @todo better status ? */
    754754            notify.DmaFaulted.NodeOrdinal = pVbva->idNode;
    755755            break;

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPVdma.cpp

    r63057 r63566  
    18941894            notify.InterruptType = DXGK_INTERRUPT_DMA_FAULTED;
    18951895            notify.DmaFaulted.FaultedFenceId = u32FenceId;
    1896             notify.DmaFaulted.Status = STATUS_UNSUCCESSFUL; /* @todo: better status ? */
     1896            notify.DmaFaulted.Status = STATUS_UNSUCCESSFUL; /** @todo better status ? */
    18971897            notify.DmaFaulted.NodeOrdinal = u32NodeOrdinal;
    18981898            break;

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPVhwa.cpp

    r63057 r63566  
    387387                    {
    388388                        pSettings->fFlags |= VBOXVHWA_F_CKEY_SRC;
    389                         /* todo: VBOXVHWA_CKEYCAPS_SRCOVERLAYONEACTIVE ? */
     389                        /** @todo VBOXVHWA_CKEYCAPS_SRCOVERLAYONEACTIVE ? */
    390390                    }
    391391
    … …  
    393393                    {
    394394                        pSettings->fFlags |= VBOXVHWA_F_CKEY_DST;
    395                         /* todo: VBOXVHWA_CKEYCAPS_DESTOVERLAYONEACTIVE ? */
     395                        /** @todo VBOXVHWA_CKEYCAPS_DESTOVERLAYONEACTIVE ? */
    396396                    }
    397397                }
    … …  
    577577        pInfo->cBackBuffers = 0;
    578578    pInfo->Reserved = 0;
    579         /* @todo: color keys */
     579        /** @todo color keys */
    580580//                        pInfo->DstOverlayCK;
    581581//                        pInfo->DstBltCK;
    … …  
    607607        pSurf->AllocData.SurfDesc.pitch = pInfo->pitch;
    608608        Assert(pSurf->AllocData.SurfDesc.pitch);
    609         /* @todo: make this properly */
     609        /** @todo make this properly */
    610610        pSurf->AllocData.SurfDesc.bpp = pSurf->AllocData.SurfDesc.pitch * 8 / pSurf->AllocData.SurfDesc.width;
    611611        Assert(pSurf->AllocData.SurfDesc.bpp);
    … …  
    757757
    758758    int rc = VINF_SUCCESS;
    759     /* @todo: need a better sync */
     759    /** @todo need a better sync */
    760760    uint32_t cNew = ASMAtomicIncU32(&pSource->Vhwa.cOverlaysCreated);
    761761    if (cNew == 1)
    … …  
    800800    Assert(!!(pSource->Vhwa.Settings.fFlags & VBOXVHWA_F_ENABLED));
    801801
    802     /* @todo: need a better sync */
     802    /** @todo need a better sync */
    803803    uint32_t cNew = ASMAtomicDecU32(&pSource->Vhwa.cOverlaysCreated);
    804804    int rc = VINF_SUCCESS;

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPVidPn.cpp

    r63057 r63566  
    12531253    pNewVidPnPresentPathInfo->VisibleFromActiveBROffset.cx = 0;
    12541254    pNewVidPnPresentPathInfo->VisibleFromActiveBROffset.cy = 0;
    1255     pNewVidPnPresentPathInfo->VidPnTargetColorBasis = D3DKMDT_CB_SRGB; /* @todo: how does it matters? */
     1255    pNewVidPnPresentPathInfo->VidPnTargetColorBasis = D3DKMDT_CB_SRGB; /** @todo how does it matters? */
    12561256    pNewVidPnPresentPathInfo->VidPnTargetColorCoeffDynamicRanges.FirstChannel =  8;
    12571257    pNewVidPnPresentPathInfo->VidPnTargetColorCoeffDynamicRanges.SecondChannel =  8;

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/VBoxMPWddm.cpp

    r63057 r63566  
    340340
    341341    VBoxVideoSetModeRegisters(width, height, width, bpp, 0, (uint16_t)xOffset, (uint16_t)yOffset);
    342     /*@todo read back from port to check if mode switch was successful */
     342    /** @todo read back from port to check if mode switch was successful */
    343343
    344344    return STATUS_SUCCESS;
    … …  
    723723       {
    724724           PCM_RESOURCE_LIST pRcList = pDeviceInfo->TranslatedResourceList;
    725            /* @todo: verify resources */
     725           /** @todo verify resources */
    726726           for (ULONG i = 0; i < pRcList->Count; ++i)
    727727           {
    … …  
    759759       {
    760760           LOGREL(("HGSMI unsupported, returning err"));
    761            /* @todo: report a better status */
     761           /** @todo report a better status */
    762762           Status = STATUS_UNSUCCESSFUL;
    763763       }
    … …  
    860860            else
    861861            {
    862                 /* todo: ?? */
     862                /** @todo ?? */
    863863            }
    864864
    … …  
    879879                    if (RT_FAILURE(rc))
    880880                    {
    881                         /* @todo: de-initialize */
     881                        /** @todo de-initialize */
    882882                    }
    883883                }
    … …  
    995995                if (RT_FAILURE(rc))
    996996                {
    997                     /* @todo: */
     997                    /** @todo */
    998998                }
    999999            }
    … …  
    12841284                    LOGREL(("HGSMI failed to initialize, returning err"));
    12851285
    1286                     /* @todo: report a better status */
     1286                    /** @todo report a better status */
    12871287                    Status = STATUS_UNSUCCESSFUL;
    12881288                }
    … …  
    15401540        {
    15411541            AssertBreakpoint();
    1542             /* @todo: FIXME: implement !!! */
     1542            /** @todo FIXME: implement !!! */
    15431543        }
    15441544        else
    … …  
    17011701            {
    17021702                AssertBreakpoint();
    1703                 /* @todo: FIXME: implement !!! */
     1703                /** @todo FIXME: implement !!! */
    17041704            }
    17051705            else
    … …  
    22042204            pCaps->SchedulingCaps.MultiEngineAware = 1;
    22052205            pCaps->MemoryManagementCaps.Value = 0;
    2206             /* @todo: this correlates with pCaps->SchedulingCaps.MultiEngineAware */
     2206            /** @todo this correlates with pCaps->SchedulingCaps.MultiEngineAware */
    22072207            pCaps->MemoryManagementCaps.PagingNode = 0;
    2208             /* @todo: this correlates with pCaps->SchedulingCaps.MultiEngineAware */
     2208            /** @todo this correlates with pCaps->SchedulingCaps.MultiEngineAware */
    22092209            pCaps->GpuEngineTopology.NbAsymetricProcessingNodes = VBOXWDDM_NUM_NODES;
    22102210#ifdef VBOX_WDDM_WIN8
    … …  
    22472247                pDr->CpuTranslatedAddress = VBoxCommonFromDeviceExt(pDevExt)->phVRAM;
    22482248                /* make sure the size is page aligned */
    2249                 /* @todo: need to setup VBVA buffers and adjust the mem size here */
     2249                /** @todo need to setup VBVA buffers and adjust the mem size here */
    22502250                pDr->Size = vboxWddmVramCpuVisibleSegmentSize(pDevExt);
    22512251                pDr->NbOfBanks = 0;
    … …  
    22602260                pDr->CpuTranslatedAddress.QuadPart = 0;
    22612261                /* make sure the size is page aligned */
    2262                 /* @todo: need to setup VBVA buffers and adjust the mem size here */
     2262                /** @todo need to setup VBVA buffers and adjust the mem size here */
    22632263                pDr->Size = vboxWddmVramCpuInvisibleSegmentSize(pDevExt);
    22642264                pDr->NbOfBanks = 0;
    … …  
    24332433            if (pAllocation->bAssigned)
    24342434            {
    2435                 /* @todo: do we need to notify host? */
     2435                /** @todo do we need to notify host? */
    24362436                vboxWddmAssignPrimary(&pDevExt->aSources[pAllocation->AllocData.SurfDesc.VidPnSourceId], NULL, pAllocation->AllocData.SurfDesc.VidPnSourceId);
    24372437            }
    … …  
    29092909                pGetStandardAllocationDriverData->pCreateShadowSurfaceData->Pitch = Pitch;
    29102910
    2911                 /* @todo: need [d/q]word align?? */
     2911                /** @todo need [d/q]word align?? */
    29122912
    29132913                if (pGetStandardAllocationDriverData->pAllocationPrivateDriverData)
    … …  
    35473547            if (!pDr)
    35483548            {
    3549                 /* @todo: try flushing.. */
     3549                /** @todo try flushing.. */
    35503550                LOGREL(("vboxVdmaCBufDrCreate returned NULL"));
    35513551                return STATUS_INSUFFICIENT_RESOURCES;
    … …  
    36033603
    36043604    AssertFailed();
    3605     /* @todo: fixme: implement */
     3605    /** @todo fixme: implement */
    36063606
    36073607    LOGF(("LEAVE, hAdapter(0x%x)", hAdapter));
    … …  
    36863686            {
    36873687                WARN(("pBuildPagingBuffer->DmaSize(%d) < sizeof VBOXCMDVBVA_PAGING_TRANSFER (%d)", pBuildPagingBuffer->DmaSize , sizeof (VBOXCMDVBVA_PAGING_TRANSFER)));
    3688                 /* @todo: can this actually happen? what status to return? */
     3688                /** @todo can this actually happen? what status to return? */
    36893689                return STATUS_GRAPHICS_INSUFFICIENT_DMA_BUFFER;
    36903690            }
    … …  
    38623862    uint32_t cbCmdDma = 0;
    38633863
    3864     /* @todo: */
     3864    /** @todo */
    38653865    switch (pBuildPagingBuffer->Operation)
    38663866    {
    … …  
    40084008            else
    40094009            {
    4010                 /* @todo: try flushing.. */
     4010                /** @todo try flushing.. */
    40114011                LOGREL(("vboxVdmaCBufDrCreate returned NULL"));
    40124012                Status = STATUS_INSUFFICIENT_RESOURCES;
    … …  
    40584058
    40594059    AssertBreakpoint();
    4060     /* @todo: fixme: implement */
     4060    /** @todo fixme: implement */
    40614061
    40624062    LOGF(("LEAVE, hAdapter(0x%x)", hAdapter));
    … …  
    43104310        PVBOXMP_DEVEXT pDevExt = (PVBOXMP_DEVEXT)hAdapter;
    43114311        PVBOXWDDM_POINTER_INFO pPointerInfo = &pDevExt->aSources[pSetPointerShape->VidPnSourceId].PointerInfo;
    4312         /* @todo: to avoid extra data copy and extra heap allocation,
     4312        /** @todo to avoid extra data copy and extra heap allocation,
    43134313         *  need to maintain the pre-allocated HGSMI buffer and convert the data directly to it */
    43144314        if (vboxVddmPointerShapeToAttributes(pSetPointerShape, pPointerInfo))
    … …  
    43394339
    43404340    AssertBreakpoint();
    4341     /* @todo: fixme: implement */
     4341    /** @todo fixme: implement */
    43424342
    43434343    LOGF(("LEAVE, hAdapter(0x%x)", hAdapter));
    … …  
    45944594            }
    45954595            case VBOXESC_ISVRDPACTIVE:
    4596                 /* @todo: implement */
     4596                /** @todo implement */
    45974597                Status = STATUS_SUCCESS;
    45984598                break;
    … …  
    57695769        WARN(("pRender->DmaBufferPrivateDataSize(%d) < sizeof VBOXCMDVBVA_HDR (%d)",
    57705770                pRender->DmaBufferPrivateDataSize , sizeof (VBOXCMDVBVA_HDR)));
    5771         /* @todo: can this actually happen? what status to return? */
     5771        /** @todo can this actually happen? what status to return? */
    57725772        return STATUS_INVALID_PARAMETER;
    57735773    }
    … …  
    61946194    {
    61956195        WARN(("Present->DmaBufferPrivateDataSize(%d) < sizeof VBOXCMDVBVA_HDR (%d)", pPresent->DmaBufferPrivateDataSize , sizeof (VBOXCMDVBVA_HDR)));
    6196         /* @todo: can this actually happen? what status to return? */
     6196        /** @todo can this actually happen? what status to return? */
    61976197        return STATUS_INVALID_PARAMETER;
    61986198    }
    … …  
    62096209    {
    62106210        WARN(("Present->DmaSize(%d) < VBOXWDDM_DUMMY_DMABUFFER_SIZE (%d)", pPresent->DmaSize , VBOXWDDM_DUMMY_DMABUFFER_SIZE));
    6211         /* @todo: can this actually happen? what status to return? */
     6211        /** @todo can this actually happen? what status to return? */
    62126212        return STATUS_INVALID_PARAMETER;
    62136213    }
    … …  
    62646264        {
    62656265            WARN(("Present->DmaBufferPrivateDataSize(%d) < (%d)", pPresent->DmaBufferPrivateDataSize , VBOXCMDVBVA_SIZEOF_BLTSTRUCT_MAX));
    6266             /* @todo: can this actually happen? what status to return? */
     6266            /** @todo can this actually happen? what status to return? */
    62676267            return STATUS_INVALID_PARAMETER;
    62686268        }
    … …  
    63236323        {
    63246324            WARN(("Present->DmaBufferPrivateDataSize(%d) < sizeof VBOXCMDVBVA_FLIP (%d)", pPresent->DmaBufferPrivateDataSize , sizeof (VBOXCMDVBVA_FLIP)));
    6325             /* @todo: can this actually happen? what status to return? */
     6325            /** @todo can this actually happen? what status to return? */
    63266326            return STATUS_INVALID_PARAMETER;
    63276327        }
    … …  
    64016401            {
    64026402                WARN(("Present->DmaBufferPrivateDataSize(%d) < VBOXCMDVBVA_SIZEOF_CLRFILLSTRUCT_MAX (%d)", pPresent->DmaBufferPrivateDataSize , VBOXCMDVBVA_SIZEOF_CLRFILLSTRUCT_MAX));
    6403                 /* @todo: can this actually happen? what status to return? */
     6403                /** @todo can this actually happen? what status to return? */
    64046404                return STATUS_INVALID_PARAMETER;
    64056405            }
    … …  
    65166516    {
    65176517        LOGREL(("Present->DmaBufferPrivateDataSize(%d) < sizeof VBOXWDDM_DMA_PRIVATEDATA_PRESENTHDR (%d)", pPresent->DmaBufferPrivateDataSize , sizeof (VBOXWDDM_DMA_PRIVATEDATA_PRESENTHDR)));
    6518         /* @todo: can this actually happen? what status tu return? */
     6518        /** @todo can this actually happen? what status tu return? */
    65196519        return STATUS_INVALID_PARAMETER;
    65206520    }

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/xpdm/VBoxMPIOCTL.cpp

    r63047 r63566  
    5959
    6060    /* Tell the host that we no longer support graphics in the additions */
    61     /* @todo VBoxMPSetGraphicsCap(FALSE); */
     61    /** @todo VBoxMPSetGraphicsCap(FALSE); */
    6262
    6363    LOGF_LEAVE();
    … …  
    220220                              (USHORT)pModeInfo->VisScreenWidth, (USHORT)pModeInfo->BitsPerPlane, 0, 0, 0);
    221221
    222     /*@todo read back from port to check if mode switch was successful */
     222    /** @todo read back from port to check if mode switch was successful */
    223223
    224224    LOGF_LEAVE();

  • trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/xpdm/VBoxMPInternal.cpp

    r63047 r63566  
    475475                while (pCur)
    476476                {
    477                     /*@todo: */
     477                    /** @todo */
    478478                    Assert(!pCur->u.Data);
    479479                    Assert(!pFirst);
    … …  
    498498                            Assert(!pCur->u.Data);
    499499#if 0  /* Who is supposed to set pNext? */
    500                             //TODO: use offset here
     500                            /// @todo use offset here
    501501                            pCur = pCur->u.pNext;
    502502                            Assert(!pCur);
    … …  
    519519                            Assert(!pCur->u.Data);
    520520#if 0  /* pLast has been asserted to be NULL, and who should set pNext? */
    521                             //TODO: use offset here
     521                            /// @todo use offset here
    522522                            if(pLast)
    523523                                pLast->u.pNext = pCur->u.pNext;
    … …  
    567567        else
    568568        {
    569             /*@todo*/
     569            /** @todo */
    570570        }
    571571    }

  • trunk/src/VBox/Additions/WINNT/Installer/VBoxDrvInst.cpp

    r63091 r63566  
    601601int RegistryRemoveStringFromMultiSZ(const TCHAR *pszSubKey, const TCHAR *pszKeyValue, const TCHAR *pszValueToRemove)
    602602{
    603     // @todo Make string sizes dynamically allocated!
     603    /// @todo Make string sizes dynamically allocated!
    604604
    605605    const TCHAR *pszKey = pszSubKey;
    … …  
    913913
    914914    /* Fixup end of multistring. */
    915     TCHAR szDepend[ _MAX_PATH ] = { 0 }; /* @todo Use dynamically allocated string here! */
     915    TCHAR szDepend[ _MAX_PATH ] = { 0 }; /** @todo Use dynamically allocated string here! */
    916916    if (pszDependencies != NULL)
    917917    {

  • trunk/src/VBox/Additions/WINNT/SharedFolders/driver/file.c

    r63078 r63566  
    251251         ByteCount, ByteOffset, FileSize));
    252252
    253     /* @todo check if this is necessary. */
     253    /** @todo check if this is necessary. */
    254254#ifdef FCB_STATE_READCACHING_ENABLED    /* Correct spelling for Vista 6001 SDK. */
    255255    if (!FlagOn(capFcb->FcbState, FCB_STATE_READCACHING_ENABLED))
    … …  
    268268    }
    269269
    270     /* @todo read 0 bytes == always success? */
     270    /** @todo read 0 bytes == always success? */
    271271    if (   !BufferMdl
    272272        || ByteCount == 0)
    … …  
    373373         ByteCount, ByteOffset, FileSize));
    374374
    375     /* @todo allow to write 0 bytes. */
     375    /** @todo allow to write 0 bytes. */
    376376    if (   !BufferMdl
    377377        || ByteCount == 0)
    … …  
    469469
    470470        case LOWIO_OP_UNLOCK_MULTIPLE:
    471             /* @todo Remove multiple locks listed in LowIoContext.ParamsFor.Locks.LockList. */
     471            /** @todo Remove multiple locks listed in LowIoContext.ParamsFor.Locks.LockList. */
    472472            Log(("VBOXSF: MRxLocks: Unsupported LOWIO_OP_UNLOCK_MULTIPLE!\n",
    473473                 LowIoContext->Operation));

  • trunk/src/VBox/Additions/WINNT/SharedFolders/driver/info.c

    r63077 r63566  
    350350                    pInfo->EndOfFile.QuadPart      = pDirEntry->Info.cbObject;
    351351                    pInfo->EaSize                  = 0;
    352                     pInfo->ShortNameLength         = 0; /* @todo ? */
     352                    pInfo->ShortNameLength         = 0; /** @todo ? */
    353353                    pInfo->FileIndex               = index;
    354354                    pInfo->FileAttributes          = VBoxToNTFileAttributes(pDirEntry->Info.Attr.fMode);
    … …  
    398398                    pInfo->EndOfFile.QuadPart      = pDirEntry->Info.cbObject;
    399399                    pInfo->EaSize                  = 0;
    400                     pInfo->ShortNameLength         = 0; /* @todo ? */
     400                    pInfo->ShortNameLength         = 0; /** @todo ? */
    401401                    pInfo->EaSize                  = 0;
    402402                    pInfo->FileId.QuadPart         = 0;
    … …  
    11461146                    pInfo->AllocationSize.QuadPart = pFileEntry->cbAllocated;
    11471147                    pInfo->EndOfFile.QuadPart      = pFileEntry->cbObject;
    1148                     pInfo->NumberOfLinks           = 1; /* @todo 0? */
     1148                    pInfo->NumberOfLinks           = 1; /** @todo 0? */
    11491149                    pInfo->DeletePending           = FALSE;
    11501150

  • trunk/src/VBox/Additions/WINNT/SharedFolders/driver/vbsf.c

    r63087 r63566  
    543543    DriverObject->MajorFunction[IRP_MJ_DEVICE_CONTROL] = VBoxMRXDeviceControl;
    544544
    545     /* @todo start the redirector here RxStartMiniRdr. */
     545    /** @todo start the redirector here RxStartMiniRdr. */
    546546
    547547    Log(("VBOXSF: DriverEntry: Init successful!\n"));
    … …  
    11071107               cRemainingName -= 2;
    11081108
    1109                /* @todo should also check that the drive letter corresponds to the name. */
     1109               /** @todo should also check that the drive letter corresponds to the name. */
    11101110               if (vboxIsPrefixOK(pwc, cRemainingName * sizeof (WCHAR)))
    11111111                   Status = STATUS_SUCCESS;

  • trunk/src/VBox/Additions/WINNT/SharedFolders/driver/vbsfhlp.c

    r63073 r63566  
    229229
    230230    default:
    231         /* @todo error handling */
     231        /** @todo error handling */
    232232        Status = STATUS_INVALID_PARAMETER;
    233233        Log(("Unexpected vbox error %Rrc\n",

  • trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxClipboard.cpp

    r62522 r63566  
    379379            else
    380380            {
    381                 const uint32_t cbPrealloc = 4096; /* @todo r=andy Make it dynamic for supporting larger text buffers! */
     381                const uint32_t cbPrealloc = 4096; /** @todo r=andy Make it dynamic for supporting larger text buffers! */
    382382                uint32_t cb = 0;
    383383

  • trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDispIf.cpp

    r63549 r63566  
    12701270    if (pOp->pIf->enmMode == VBOXDISPIF_MODE_WDDM)
    12711271    {
    1272         /* @todo: do we need ti impl it? */
     1272        /** @todo do we need ti impl it? */
    12731273        *pfConnected = TRUE;
    12741274        return ERROR_SUCCESS;
    … …  
    20392039DWORD VBoxDispIfSwitchMode(PVBOXDISPIF pIf, VBOXDISPIF_MODE enmMode, VBOXDISPIF_MODE *penmOldMode)
    20402040{
    2041     /* @todo: may need to addd synchronization in case we want to change modes dynamically
     2041    /** @todo may need to addd synchronization in case we want to change modes dynamically
    20422042     * i.e. currently the mode is supposed to be initialized once on service initialization */
    20432043    if (penmOldMode)

  • trunk/src/VBox/Additions/common/VBoxGuest/VBoxDev-haiku.c

    r62521 r63566  
    124124    RTSpinlockAcquire(g_DevExt.SessionSpinlock);
    125125
    126     /* @todo we don't know if it belongs to this session!! */
     126    /** @todo we don't know if it belongs to this session!! */
    127127    if (sState.selectSync)
    128128    {

  • trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-haiku.c

    r62521 r63566  
    433433     */
    434434    pState->uIOPortBase = pDevice->u.h0.base_registers[0];
    435     /* @todo check flags for IO? */
     435    /** @todo check flags for IO? */
    436436    if (pState->uIOPortBase)
    437437    {
    … …  
    440440         */
    441441        uint32 phys = pDevice->u.h0.base_registers[1];
    442         /* @todo Check flags for mem? */
     442        /** @todo Check flags for mem? */
    443443        pState->VMMDevMemSize    = pDevice->u.h0.base_register_sizes[1];
    444444        pState->iVMMDevMemAreaId = map_physical_memory("VirtualBox Guest MMIO", phys, pState->VMMDevMemSize,

  • trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibModule.cpp

    r62842 r63566  
    6969# endif
    7070#else
    71     /** todo */
     71    /** @todo */
    7272    pReq->enmGuestOS    = VBOXOSFAMILY_Unknown;
    7373#endif

  • trunk/src/VBox/Additions/common/VBoxService/VBoxServiceStats.cpp

    r62679 r63566  
    614614
    615615#else
    616     /* todo: implement for other platforms. */
     616    /** @todo implement for other platforms. */
    617617
    618618#endif

  • trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp

    r63338 r63566  
    7373# include <unistd.h>
    7474# if !defined(RT_OS_OS2) && !defined(RT_OS_FREEBSD) && !defined(RT_OS_HAIKU)
    75 #  include <utmpx.h> /* @todo FreeBSD 9 should have this. */
     75#  include <utmpx.h> /** @todo FreeBSD 9 should have this. */
    7676# endif
    7777# ifdef RT_OS_OS2
    … …  
    11071107         * Only AF_INET and no loopback interfaces
    11081108         */
    1109         /** @todo: IPv6 interfaces */
     1109        /** @todo IPv6 interfaces */
    11101110        if (   pIfCurr->ifa_addr->sa_family == AF_INET
    11111111            && !(pIfCurr->ifa_flags & IFF_LOOPBACK))

  • trunk/src/VBox/Additions/common/testcase/tstPageFusion.cpp

    r62679 r63566  
    208208    do
    209209    {
    210         /** todo when changing this make sure VBoxService.exe is excluded! */
     210        /** @todo when changing this make sure VBoxService.exe is excluded! */
    211211        char *pszDot = strrchr(ModuleInfo.szModule, '.');
    212212        if (    pszDot
    … …  
    315315void VBoxServicePageSharingInspectGuest()
    316316{
    317     /* @todo other platforms */
     317    /** @todo other platforms */
    318318}
    319319#endif
    … …  
    332332#endif
    333333
    334     /* @todo report system name and version */
     334    /** @todo report system name and version */
    335335    /* Never fail here. */
    336336    return VINF_SUCCESS;

  • trunk/src/VBox/Additions/darwin/vboxfs/VBoxVFS-VFSOps.cpp

    r63526 r63566  
    439439            && fRootVnodeState != VBOXVFS_OBJECT_INVALID)
    440440        {
    441             /* @todo: Currently, we are burning CPU cycles while waiting. This is for a short
     441            /** @todo Currently, we are burning CPU cycles while waiting. This is for a short
    442442             * time but we should relax here! */
    443443            fRootVnodeState = ASMAtomicReadU8(&pMount->fRootVnodeState);
    … …  
    529529    VFSATTR_CLEAR_ACTIVE(pAttr, f_fssubtype);
    530530
    531     /* todo: take care about f_capabilities and f_attributes, f_fsid */
     531    /** @todo take care about f_capabilities and f_attributes, f_fsid */
    532532    VFSATTR_CLEAR_ACTIVE(pAttr, f_capabilities);
    533533    VFSATTR_CLEAR_ACTIVE(pAttr, f_attributes);
    534534    VFSATTR_CLEAR_ACTIVE(pAttr, f_fsid);
    535535
    536     /* todo: take care about f_create_time, f_modify_time, f_access_time, f_backup_time */
     536    /** @todo take care about f_create_time, f_modify_time, f_access_time, f_backup_time */
    537537    VFSATTR_CLEAR_ACTIVE(pAttr, f_create_time);
    538538    VFSATTR_CLEAR_ACTIVE(pAttr, f_modify_time);

  • trunk/src/VBox/Additions/darwin/vboxfs/VBoxVFS-VNODEOps.cpp

    r63526 r63566  
    101101        //VATTR_CLEAR_ACTIVE(vnode_args, va_addedtime);
    102102
    103         /* todo: take care about va_encoding (file name encoding) */
     103        /** @todo take care about va_encoding (file name encoding) */
    104104        VATTR_CLEAR_ACTIVE(vnode_args, va_encoding);
    105         /* todo: take care about: va_acl */
     105        /** @todo take care about: va_acl */
    106106        VATTR_CLEAR_ACTIVE(vnode_args, va_acl);
    107107
    … …  
    312312            /* If vnode exist in guets VFS cache, but not exist on a host -- just forget it. */
    313313            cache_purge(vnode);
    314             /* todo: free vnode data here */
     314            /** @todo free vnode data here */
    315315            rc = ENOENT;
    316316        }

  • trunk/src/VBox/Additions/freebsd/vboxvfs/vboxvfs_vfsops.c

    r62524 r63566  
    154154    mp->mnt_data = pShFlGlobalInfo;
    155155
    156     /* @todo root vnode. */
     156    /** @todo root vnode. */
    157157
    158158    vfs_getnewfsid(mp);

  • trunk/src/VBox/Additions/haiku/SharedFolders/vboxsf.c

    r62526 r63566  
    5757{
    5858#if 0
    59     /* @todo enable this soon */
     59    /** @todo enable this soon */
    6060    int rc = get_module(VBOXGUEST_MODULE_NAME, (module_info **)&g_VBoxGuest);
    6161    if (RT_LIKELY(rc == B_OK)
    … …  
    766766
    767767    uint32_t l = *length;
    768     void* other_buffer = malloc(l);  /* @todo map the user memory into kernel space here for efficiency */
     768    void* other_buffer = malloc(l);  /** @todo map the user memory into kernel space here for efficiency */
    769769    int rc = VbglR0SfRead(&g_clientHandle, &volume->map, cookie->handle, pos, &l, other_buffer, false /*fLocked*/);
    770770    memcpy(buffer, other_buffer, l);
    … …  
    787787
    788788    uint32_t l = *length;
    789     void* other_buffer = malloc(l);  /* @todo map the user memory into kernel space here for efficiency */
     789    void* other_buffer = malloc(l);  /** @todo map the user memory into kernel space here for efficiency */
    790790    memcpy(other_buffer, buffer, l);
    791791    int rc = VbglR0SfWrite(&g_clientHandle, &volume->map, cookie->handle, pos, &l, other_buffer, false /*fLocked*/);
    … …  
    899899
    900900
    901 /* @todo move this into the runtime */
     901/** @todo move this into the runtime */
    902902status_t vbox_err_to_haiku_err(int rc)
    903903{

  • trunk/src/VBox/Additions/haiku/VBoxMouse/VBoxMouseFilter.cpp

    r62526 r63566  
    6262#include <iprt/err.h>
    6363
    64 /* @todo can this be merged with VBoxMouse? */
     64/** @todo can this be merged with VBoxMouse? */
    6565
    6666RTDECL(BInputServerFilter *)

  • trunk/src/VBox/Additions/haiku/VBoxVideo/accelerant/accelerant.cpp

    r62526 r63566  
    282282status_t vboxvideo_get_mode_list(display_mode *dm)
    283283{
    284     // TODO return some standard modes here
     284    /// @todo return some standard modes here
    285285    TRACE("%s\n", __FUNCTION__);
    286286    return vboxvideo_get_display_mode(dm);

  • trunk/src/VBox/Additions/haiku/VBoxVideo/driver/driver.cpp

    r62526 r63566  
    278278        return B_BAD_VALUE;
    279279
    280     /* @todo init device! */
     280    /** @todo init device! */
    281281
    282282    *cookie = (void *)&gDeviceInfo;
    … …  
    301301    if (di.openCount <= 1)
    302302    {
    303         // TODO deinit device!
     303        /// @todo deinit device!
    304304        delete_area(di.sharedArea);
    305305        di.sharedArea = -1;

  • trunk/src/VBox/Additions/solaris/Virtio/Virtio-solaris.c

    r62529 r63566  
    191191    AssertReturn(pQueue->Ring.cDesc > 0, NULL);
    192192
    193     /* @todo enable interrupt. */
     193    /** @todo enable interrupt. */
    194194
    195195    return pQueue;

  • trunk/src/VBox/Additions/solaris/Virtio/VirtioNet-solaris.c

    r62529 r63566  
    362362    PVIRTIODEVICE pDevice = pvArg;
    363363
    364     /* @todo ncookies handles? */
     364    /** @todo ncookies handles? */
    365365    int rc = ddi_dma_alloc_handle(pDevice->pDip, &g_VirtioNetBufDmaAttr,
    366366                                  fFlags & KM_NOSLEEP ? DDI_DMA_DONTWAIT : DDI_DMA_SLEEP,
    … …  
    468468        pMacRegHandle->m_type_ident = MAC_PLUGIN_IDENT_ETHER;
    469469        pMacRegHandle->m_min_sdu    = 0;
    470         pMacRegHandle->m_max_sdu    = 1500;    /* @todo verify */
    471         /* @todo should we set the margin size? */
     470        pMacRegHandle->m_max_sdu    = 1500;    /** @todo verify */
     471        /** @todo should we set the margin size? */
    472472        pMacRegHandle->m_src_addr   = pNet->MacAddr.au8;
    473473

  • trunk/src/VBox/Additions/x11/VBoxClient/draganddrop.cpp

    r62883 r63566  
    360360}
    361361
    362 /** todo Make this iterative. */
     362/** @todo Make this iterative. */
    363363Window xHelpers::applicationWindowBelowCursor(Window wndParent) const
    364364{
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette