Changeset 63568 in vbox

Timestamp:

Aug 16, 2016 2:07:39 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

110223

Message:

scm: cleaning up todos

Location:

trunk/src

Files:

• apps/svnsync-vbox/main.c (modified) (3 diffs)
• bldprogs/scmrw.cpp (modified) (1 diff)
• recompiler/VBoxRecompiler.c (modified) (1 diff)
• recompiler/exec.c (modified) (1 diff)
• recompiler/target-i386/translate.c (modified) (2 diffs)
• recompiler/tcg/i386/tcg-target.c (modified) (1 diff)

trunk/src/apps/svnsync-vbox/main.c

@@ -1111 +1111 @@
 #endif /* !VBOX */
 
-  /* TODO: It would be nice if we could set the dest repos UUID to be
+  /** @todo It would be nice if we could set the dest repos UUID to be
      equal to the UUID of the source repos, at least optionally.  That
      way people could check out/log/diff using a local fast mirror,
@@ -1798 +1798 @@
         db->ignore_everything = TRUE;
 
-        /* TODO: copy over files in this directory which were already exported
+        /** @todo copy over files in this directory which were already exported
          * due to inconsistent export settings (e.g. directory is not exported,
          * but file in it is exported). */
@@ -2582 +2582 @@
             {
 #ifdef VBOX
-/* TODO fix use of from/to revision numbers. */
+/** @todo fix use of from/to revision numbers. */
               SVN_ERR(copy_revprops(from_session, to_session,
                                     to_latest, to_latest, TRUE, pool));

trunk/src/bldprogs/scmrw.cpp

@@ -742 +742 @@
                         && (ch = pchLine[off + 4]) != ' '
                         && ch != '\t'
-                        && ch != ':'                /* todo: */
-                        && (ch != '*' || off + 5 > cchLine || pchLine[off + 5] != '/')  /*todo*/
+                        && ch != ':'                /** @todo */
+                        && (ch != '*' || off + 5 > cchLine || pchLine[off + 5] != '/')  /** @todo */
                         ) )
                 { /* not a hit - likely */ }

trunk/src/recompiler/VBoxRecompiler.c

@@ -854 +854 @@
             case EXCP_EXECUTE_RAW:
             case EXCP_EXECUTE_HM:
-                /** @todo: is it correct? No! */
+                /** @todo is it correct? No! */
                 rc = VINF_SUCCESS;
                 break;

trunk/src/recompiler/exec.c

@@ -4499 +4499 @@
        we have already translated the block once so it's probably ok.  */
     tb_gen_code(env, pc, cs_base, flags, cflags);
-    /* TODO: If env->pc != tb->pc (i.e. the faulting instruction was not
+    /** @todo If env->pc != tb->pc (i.e. the faulting instruction was not
        the first in the TB) then we end up generating a whole new TB and
        repeating the fault, which is horribly inefficient.

trunk/src/recompiler/target-i386/translate.c

@@ -742 +742 @@
 {
 # if 1
-    /** @todo: once TCG codegen improves, we may want to use version
+    /** @todo once TCG codegen improves, we may want to use version
         from else version */
     gen_helper_check_external_event();
@@ -760 +760 @@
                     | CPU_INTERRUPT_EXTERNAL_DMA
                     | CPU_INTERRUPT_EXTERNAL_HARD);
-    /** @todo: predict branch as taken */
+    /** @todo predict branch as taken */
     tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, skip_label);
     tcg_temp_free(t0);

trunk/src/recompiler/tcg/i386/tcg-target.c

@@ -1259 +1259 @@
     int useReg2 = ((index & 3) == 3);
 
-    /** @todo:  should we make phys address accessors fastcalls - probably not a big deal */
+    /** @todo  should we make phys address accessors fastcalls - probably not a big deal */
     /* out parameter (address), note that phys address is always 64-bit */
     AssertMsg(sizeof(RTGCPHYS) == 8, ("Physical address must be 64-bits, update caller\n"));