Changeset 63764 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Sep 8, 2016 1:14:26 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

110576

Message:

FE/Qt: bugref:6899: Accessibility support (step 17): Selector UI: Reworking details item interface to use description instead of name which becomes obsolete.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details

Files:

• UIGDetailsElement.cpp (modified) (1 diff)
• UIGDetailsElement.h (modified) (1 diff)
• UIGDetailsGroup.h (modified) (1 diff)
• UIGDetailsItem.cpp (modified) (1 diff)
• UIGDetailsItem.h (modified) (1 diff)
• UIGDetailsSet.cpp (modified) (1 diff)
• UIGDetailsSet.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsElement.cpp

@@ -193 +193 @@
 }
 
-QString UIGDetailsElement::name() const
-{
-    return m_strName;
-}
-
 QString UIGDetailsElement::description() const
 {
-    return tr("Details");
+    return tr("%1 details", "like 'General details' or 'Storage details'").arg(m_strName);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsElement.h

@@ -115 +115 @@
     void resizeEvent(QGraphicsSceneResizeEvent *pEvent);
 
-    /** Returns the name of the item. */
-    virtual QString name() const /* override */;
     /** Returns the description of the item. */
     virtual QString description() const /* override */;

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsGroup.h

@@ -68 +68 @@
     };
 
-    /** Returns the name of the item. */
-    virtual QString name() const /* override */ { return QString(); }
     /** Returns the description of the item. */
     virtual QString description() const /* override */ { return QString(); }

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsItem.cpp

@@ -151 +151 @@
         AssertPtrReturn(item(), QString());
 
-        switch (enmTextRole)
-        {
-            case QAccessible::Name:        return item()->name();
-            case QAccessible::Description: return item()->description();
-            default: break;
-        }
+        /* Return the description: */
+        if (enmTextRole == QAccessible::Description)
+            return item()->description();
 
         /* Null-string by default: */

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsItem.h

@@ -69 +69 @@
     UIGDetailsItem* parentItem() const;
 
-    /** Returns the name of the item. */
-    virtual QString name() const = 0;
     /** Returns the description of the item. */
     virtual QString description() const = 0;

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsSet.cpp

@@ -219 +219 @@
     /* Update appearance: */
     rebuildSet();
-}
-
-QString UIGDetailsSet::name() const
-{
-    return QString();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/selector/graphics/details/UIGDetailsSet.h

@@ -82 +82 @@
     };
 
-    /** Returns the name of the item. */
-    virtual QString name() const /* override */;
     /** Returns the description of the item. */
     virtual QString description() const /* override */;