Changeset 63772 in vbox for trunk

Timestamp:

Sep 8, 2016 8:28:08 PM (8 years ago)

Author:

vboxsync

Message:

bugref:8087: Additions/x11: support non-root X server: do not disable VBVA on mode changes, as this caused all our reported capability flags to be lost, and the host to think we did not support dynamic resizing. We already disable VBVA when the master is changed and that is enough. The motivation for disabling VBVA was that we did not enable it until we saw that the user-space master was willing to send us dirty rectangle information.

Location:

trunk/src/VBox/Additions/linux/drm

Files:

• README.testing (added)
• vbox_drv.c (modified) (1 diff)
• vbox_mode.c (modified) (1 diff)

trunk/src/VBox/Additions/linux/drm/vbox_drv.c

@@ -260 +260 @@
      * to do VESA. */
     /** @todo work out if anyone is likely to and whether it will even work. */
+    /* Update: we also disable it because if the new master does not do dirty
+     * rectangle reporting (e.g. old versions of Plymouth) then at least the
+     * first screen will still be updated.  We enable it as soon as we
+     * receive a dirty rectangle report. */
     vbox_disable_accel(vbox);
     mutex_unlock(&vbox->hw_mutex);

trunk/src/VBox/Additions/linux/drm/vbox_mode.c

@@ -259 +259 @@
     vbox_crtc_mode_set_base(crtc, x, y, old_fb);
     mutex_lock(&vbox->hw_mutex);
-    /* Disable VBVA when someone sets a new mode until they send us dirty
-     * rectangles, which proves that they can.  A single screen can work
-     * without VBVA. */
-    vbox_disable_accel(vbox);
     rc = vbox_set_view(crtc);
     if (!rc)