Changeset 63816 in vbox

Timestamp:

Sep 13, 2016 4:03:33 PM (8 years ago)

Author:

vboxsync

Message:

Audio/DevIchAc97.cpp: Check the stream's status register if a device stream state change actually is required.

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -557 +557 @@
     AssertPtrReturn(pStream, VERR_INVALID_POINTER);
 
+    /* Check the stream's status register if a state change actually is required. */
+    const bool fIsActive = RT_BOOL(pStream->Regs.sr & AC97_SR_DCH);
+
+    LogFunc(("[SD%RU8] fActive=%RTbool, fIsActive=%RTbool, cStreamsActive=%RU8\n",
+             pStream->u8Strm, fActive, fIsActive, pThis->cStreamsActive));
+
+    if (fIsActive == fActive) /* Is a change required? */
+        return VINF_SUCCESS;
+
     if (!fActive)
     {
@@ -574 +583 @@
     }
 
-    int rc = AudioMixerSinkCtl(ichac97IndexToSink(pThis, pStream->u8Strm),
-                               fActive ? AUDMIXSINKCMD_ENABLE : AUDMIXSINKCMD_DISABLE);
-
-    LogFlowFunc(("[SD%RU8] fActive=%RTbool, cStreamsActive=%RU8, rc=%Rrc\n",
-                 pStream->u8Strm, fActive, pThis->cStreamsActive, rc));
-
-    return rc;
+    return AudioMixerSinkCtl(ichac97IndexToSink(pThis, pStream->u8Strm),
+                             fActive ? AUDMIXSINKCMD_ENABLE : AUDMIXSINKCMD_DISABLE);
 }