Changeset 63862 in vbox

Timestamp:

Sep 16, 2016 9:47:12 AM (8 years ago)

Author:

vboxsync

Message:

Audio/DevIchAc97.cpp: Better separated initialization/destruction and opening/closing the AC'97 streams, added some critical sections, minor logging adjustments.

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (56 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -84 +84 @@
 #define AC97_CR_DONT_CLEAR_MASK (AC97_CR_IOCE | AC97_CR_FEIE | AC97_CR_LVBIE)
 
-#define AC97_GC_WR    4              /* rw */
-#define AC97_GC_CR    2              /* rw */
+#define AC97_GC_WR    4                 /* rw    Warm reset. */
+#define AC97_GC_CR    2                 /* rw    Cold reset. */
 #define AC97_GC_VALID_MASK (RT_BIT(6) - 1)
 
@@ -282 +282 @@
 
 /**
- * Internal state of an AC97 stream.
+ * Internal state of an AC'97 stream.
  */
 typedef struct AC97STREAMSTATE
@@ -296 +296 @@
 
 /**
- * Structure for keeping an AC97 stream state.
- *
- * Contains only register values which do *not* change until a
- * stream reset occurs.
+ * Structure for keeping an AC'97 stream state.
  */
 typedef struct AC97STREAM
@@ -305 +302 @@
     /** Stream number (SDn). */
     uint8_t         u8Strm;
+    /** Criticial section for this stream. */
+    RTCRITSECT      CritSect;
     /** Bus master registers of this stream. */
     AC97BMREGS      Regs;
@@ -378 +377 @@
     /** The timer for pumping data thru the attached LUN drivers. */
     PTMTIMERR3              pTimer;
+    /** Criticial section for timer. */
+    RTCRITSECT              csTimer;
 # if HC_ARCH_BITS == 32
     uint32_t                Padding0;
@@ -401 +402 @@
     R3PTRTYPE(PAUDIOMIXER)  pMixer;
     /** Audio sink for PCM output. */
-    R3PTRTYPE(PAUDMIXSINK)  pSinkOutput;
+    R3PTRTYPE(PAUDMIXSINK)  pSinkOut;
     /** Audio sink for line input. */
     R3PTRTYPE(PAUDMIXSINK)  pSinkLineIn;
@@ -429 +430 @@
 #endif
 DECLINLINE(PAC97STREAM) ichac97GetStreamFromID(PAC97STATE pThis, uint32_t uID);
-static int ichac97StreamInit(PAC97STATE pThis, PAC97STREAM pStream, uint8_t u8Strm);
+static int ichac97StreamInit(PAC97STREAM pStream, uint8_t u8Strm);
+static void ichac97StreamDestroy(PAC97STREAM pStream);
+static int ichac97StreamOpen(PAC97STATE pThis, PAC97STREAM pStream);
+static int ichac97StreamReOpen(PAC97STATE pThis, PAC97STREAM pStream);
+static void ichac97StreamClose(PAC97STREAM pStream);
 static DECLCALLBACK(void) ichac97Reset(PPDMDEVINS pDevIns);
 #ifndef VBOX_WITH_AUDIO_AC97_CALLBACKS
@@ -455 +460 @@
     {
         case AC97SOUNDSOURCE_PI_INDEX: return pThis->pSinkLineIn; break;
-        case AC97SOUNDSOURCE_PO_INDEX: return pThis->pSinkOutput; break;
+        case AC97SOUNDSOURCE_PO_INDEX: return pThis->pSinkOut;    break;
         case AC97SOUNDSOURCE_MC_INDEX: return pThis->pSinkMicIn;  break;
         default:       break;
@@ -540 +545 @@
 }
 
-static bool ichac97StreamIsActive(PAC97STATE pThis, PAC97STREAM pStream)
+/**
+ * Returns whether an AC'97 stream is enabled or not.
+ *
+ * @returns IPRT status code.
+ * @param   pThis               AC'97 device state.
+ * @param   pStream             Stream to return status for.
+ */
+static bool ichac97StreamIsEnabled(PAC97STATE pThis, PAC97STREAM pStream)
 {
     AssertPtrReturn(pThis,   false);
@@ -546 +558 @@
 
     PAUDMIXSINK pSink = ichac97IndexToSink(pThis, pStream->u8Strm);
-    bool fActive = RT_BOOL(AudioMixerSinkGetStatus(pSink) & AUDMIXSINK_STS_RUNNING);
-
-    LogFlowFunc(("[SD%RU8] fActive=%RTbool\n", pStream->u8Strm, fActive));
-    return fActive;
-}
-
-static int ichac97StreamSetActive(PAC97STATE pThis, PAC97STREAM pStream, bool fActive)
+    bool fIsEnabled = RT_BOOL(AudioMixerSinkGetStatus(pSink) & AUDMIXSINK_STS_RUNNING);
+
+    LogFunc(("[SD%RU8] fIsEnabled=%RTbool\n", pStream->u8Strm, fIsEnabled));
+    return fIsEnabled;
+}
+
+static int ichac97StreamEnable(PAC97STATE pThis, PAC97STREAM pStream, bool fEnable)
 {
     AssertPtrReturn(pThis,   VERR_INVALID_POINTER);
     AssertPtrReturn(pStream, VERR_INVALID_POINTER);
 
-    /* Check the stream's status register if a state change actually is required. */
-    const bool fIsActive = !RT_BOOL(pStream->Regs.sr & AC97_SR_DCH);
-
-    LogFunc(("[SD%RU8] fActive=%RTbool, fIsActive=%RTbool, cStreamsActive=%RU8\n",
-             pStream->u8Strm, fActive, fIsActive, pThis->cStreamsActive));
-
-    if (fIsActive == fActive) /* Is a change required? */
-        return VINF_SUCCESS;
-
-    if (!fActive)
-    {
-        if (pThis->cStreamsActive) /* Disable can be called mupltiple times. */
-            pThis->cStreamsActive--;
+    PAUDMIXSINK pSink = ichac97IndexToSink(pThis, pStream->u8Strm);
+    AssertPtr(pSink);
+
+    const bool fIsEnabled = AudioMixerSinkGetStatus(pSink) & AUDMIXSINK_STS_RUNNING;
+
+    LogFunc(("[SD%RU8] fEnable=%RTbool, fIsEnabled=%RTbool, DCH=%RTbool, cStreamsActive=%RU8\n",
+             pStream->u8Strm, fEnable, fIsEnabled, RT_BOOL(pStream->Regs.sr & AC97_SR_DCH), pThis->cStreamsActive));
+
+    int rc = VINF_SUCCESS;
+
+    if (fEnable != fIsEnabled)
+    {
+        rc = ichac97StreamReOpen(pThis, pStream);
+        if (RT_SUCCESS(rc))
+            rc = AudioMixerSinkCtl(ichac97IndexToSink(pThis, pStream->u8Strm),
+                                   fEnable ? AUDMIXSINKCMD_ENABLE : AUDMIXSINKCMD_DISABLE);
+        if (RT_SUCCESS(rc))
+        {
+            if (!fEnable)
+            {
+                if (pThis->cStreamsActive) /* Disable can be called mupltiple times. */
+                    pThis->cStreamsActive--;
 
 #ifndef VBOX_WITH_AUDIO_AC97_CALLBACKS
-        ichac97TimerMaybeStop(pThis);
+                ichac97TimerMaybeStop(pThis);
 #endif
-    }
-    else
-    {
-        pThis->cStreamsActive++;
+            }
+            else
+            {
+                pThis->cStreamsActive++;
 #ifndef VBOX_WITH_AUDIO_AC97_CALLBACKS
-        ichac97TimerMaybeStart(pThis);
+                ichac97TimerMaybeStart(pThis);
 #endif
-    }
-
-    return AudioMixerSinkCtl(ichac97IndexToSink(pThis, pStream->u8Strm),
-                             fActive ? AUDMIXSINKCMD_ENABLE : AUDMIXSINKCMD_DISABLE);
+            }
+        }
+    }
+
+    LogFunc(("Returning %Rrc\n", rc));
+    return rc;
 }
 
@@ -592 +615 @@
     AssertPtrReturnVoid(pStream);
 
-    LogFlowFunc(("[SD%RU8]\n", pStream->u8Strm));
+    LogFunc(("[SD%RU8]\n", pStream->u8Strm));
 
     PAC97BMREGS pRegs = &pStream->Regs;
@@ -600 +623 @@
     pRegs->lvi      = 0;
 
-    ichac97StreamSetActive(pThis, pStream, false /* fActive */);
+    ichac97StreamEnable(pThis, pStream, false /* fActive */);
 
     ichac97StreamUpdateSR(pThis, pStream, AC97_SR_DCH); /** @todo Do we need to do that? */
@@ -612 +635 @@
 }
 
+static int ichac97StreamInit(PAC97STREAM pStream, uint8_t u8Strm)
+{
+    AssertPtrReturn(pStream, VERR_INVALID_PARAMETER);
+
+    LogFunc(("[SD%RU8] pStream=%p\n", u8Strm, pStream));
+
+    int rc = VINF_SUCCESS;
+
+    pStream->u8Strm         = u8Strm;
+    pStream->State.cbFIFOW  = _4K; /** @todo Make FIFOW size configurable. */
+    pStream->State.offFIFOW = 0;
+    pStream->State.au8FIFOW = (uint8_t *)RTMemAllocZ(pStream->State.cbFIFOW);
+    if (pStream->State.au8FIFOW)
+    {
+        rc = RTCritSectInit(&pStream->CritSect);
+    }
+    else
+        rc = VERR_NO_MEMORY;
+
+    return rc;
+}
+
 static void ichac97StreamDestroy(PAC97STREAM pStream)
 {
@@ -625 +670 @@
     pStream->State.cbFIFOW  = 0;
     pStream->State.offFIFOW = 0;
-}
-
-#if 0 /* unused */
-static void ichac97StreamsDestroy(PAC97STATE pThis)
+
+    if (RTCritSectIsInitialized(&pStream->CritSect))
+        RTCritSectDelete(&pStream->CritSect);
+}
+
+static int ichac97StreamsInit(PAC97STATE pThis)
 {
     LogFlowFuncEnter();
 
-    ichac97DestroyIn(pThis, PDMAUDIORECSOURCE_LINE);
-    ichac97DestroyIn(pThis, PDMAUDIORECSOURCE_MIC);
-    ichac97DestroyOut(pThis);
-
-    ichac97StreamDestroy(&pThis->StreamLineIn);
-    ichac97StreamDestroy(&pThis->StreamMicIn);
-    ichac97StreamDestroy(&pThis->StreamOut);
-}
-#endif
-
-static int ichac97StreamsInit(PAC97STATE pThis)
-{
-    LogFlowFuncEnter();
-
-    ichac97StreamInit(pThis, &pThis->StreamLineIn, AC97SOUNDSOURCE_PI_INDEX);
-    ichac97StreamInit(pThis, &pThis->StreamMicIn,  AC97SOUNDSOURCE_MC_INDEX);
-    ichac97StreamInit(pThis, &pThis->StreamOut,    AC97SOUNDSOURCE_PO_INDEX);
+    ichac97StreamInit(&pThis->StreamLineIn, AC97SOUNDSOURCE_PI_INDEX);
+    ichac97StreamInit(&pThis->StreamMicIn,  AC97SOUNDSOURCE_MC_INDEX);
+    ichac97StreamInit(&pThis->StreamOut,    AC97SOUNDSOURCE_PO_INDEX);
 
     return VINF_SUCCESS;
@@ -810 +843 @@
     AssertPtrReturn(pCfg,    VERR_INVALID_POINTER);
 
+    LogFunc(("%s\n", pszName));
+
     /* Update the sink's format. */
     PDMAUDIOPCMPROPS PCMProps;
     int rc = DrvAudioHlpStreamCfgToProps(pCfg, &PCMProps);
     if (RT_SUCCESS(rc))
-        rc = AudioMixerSinkSetFormat(pThis->pSinkOutput, &PCMProps);
+        rc = AudioMixerSinkSetFormat(pThis->pSinkOut, &PCMProps);
 
     if (RT_FAILURE(rc))
@@ -829 +864 @@
         }
 
-        AudioMixerSinkRemoveStream(pThis->pSinkOutput, pDrv->Out.pMixStrm);
+        AudioMixerSinkRemoveStream(pThis->pSinkOut, pDrv->Out.pMixStrm);
 
         AudioMixerStreamDestroy(pDrv->Out.pMixStrm);
         pDrv->Out.pMixStrm = NULL;
 
-        int rc2 = AudioMixerSinkCreateStream(pThis->pSinkOutput, pDrv->pConnector, pCfg, 0 /* fFlags */, &pDrv->Out.pMixStrm);
+        int rc2 = AudioMixerSinkCreateStream(pThis->pSinkOut, pDrv->pConnector, pCfg, 0 /* fFlags */, &pDrv->Out.pMixStrm);
         if (RT_SUCCESS(rc2))
         {
-            rc2 = AudioMixerSinkAddStream(pThis->pSinkOutput, pDrv->Out.pMixStrm);
+            rc2 = AudioMixerSinkAddStream(pThis->pSinkOut, pDrv->Out.pMixStrm);
             LogFlowFunc(("LUN#%RU8: Created output \"%s\", rc=%Rrc\n", pDrv->uLUN, pCfg->szName, rc2));
         }
@@ -849 +884 @@
 }
 
-static int ichac97StreamInitEx(PAC97STATE pThis, PAC97STREAM pStream, uint8_t u8Strm, PPDMAUDIOSTREAMCFG pCfg)
+/**
+ * Opens an AC'97 stream, extended version.
+ *
+ * @returns IPRT status code.
+ * @param   pThis               AC'97 device state.
+ * @param   pStream             Stream to initialize.
+ * @param   pCfg                Audio stream configuration to initialize the stream with.
+ */
+static int ichac97StreamOpenEx(PAC97STATE pThis, PAC97STREAM pStream, PPDMAUDIOSTREAMCFG pCfg)
 {
     AssertPtrReturn(pThis,             VERR_INVALID_POINTER);
     AssertPtrReturn(pStream,           VERR_INVALID_POINTER);
-    AssertReturn(u8Strm <= AC97SOUNDSOURCE_LAST_INDEX, VERR_INVALID_PARAMETER);
     AssertPtrReturn(pCfg,              VERR_INVALID_POINTER);
 
-    pStream->u8Strm = u8Strm;
-
-    LogFlowFunc(("u8Strm=%RU8, %RU32Hz, %RU8 %s\n",
-                 pStream->u8Strm, pCfg->uHz, pCfg->cChannels, pCfg->cChannels > 1 ? "Channels" : "Channel"));
+    LogFunc(("[SD%RU8] pCfg=%p\n", pStream->u8Strm, pCfg));
 
     int rc;
@@ -877 +916 @@
 
         default:
-            rc = VERR_NOT_SUPPORTED;
+            AssertFailedStmt(rc = VERR_NOT_SUPPORTED);
             break;
     }
@@ -888 +927 @@
 }
 
-static int ichac97StreamInit(PAC97STATE pThis, PAC97STREAM pStream, uint8_t u8Strm)
+/**
+ * Opens an AC'97 stream.
+ * This will open an AC'97 stream with 2 (stereo) channels, 16-bit samples and
+ * the last set sample rate in the AC'97 mixer for this stream.
+ *
+ * @returns IPRT status code.
+ * @param   pThis               AC'97 device state.
+ * @param   pStream             Stream to initialize.
+ */
+static int ichac97StreamOpen(PAC97STATE pThis, PAC97STREAM pStream)
 {
     int rc = VINF_SUCCESS;
+
+    LogFunc(("[SD%RU8]\n", pStream->u8Strm));
 
     PDMAUDIOSTREAMCFG streamCfg;
     RT_ZERO(streamCfg);
 
-    switch (u8Strm)
+    switch (pStream->u8Strm)
     {
         case AC97SOUNDSOURCE_PI_INDEX:
@@ -922 +972 @@
     if (RT_SUCCESS(rc))
     {
-        pStream->State.cbFIFOW  = _4K; /** @todo Make FIFOW size configurable. */
-        pStream->State.offFIFOW = 0;
-        pStream->State.au8FIFOW = (uint8_t *)RTMemAllocZ(pStream->State.cbFIFOW);
-        if (!pStream->State.au8FIFOW)
-            rc = VERR_NO_MEMORY;
-    }
-
-    if (RT_SUCCESS(rc))
-    {
         if (streamCfg.uHz)
         {
-            streamCfg.cChannels     = 2; /** @todo Handle mono channels? */
+            streamCfg.cChannels     = 2;
             streamCfg.enmFormat     = PDMAUDIOFMT_S16;
             streamCfg.enmEndianness = PDMAUDIOHOSTENDIANNESS;
 
-            rc = ichac97StreamInitEx(pThis, pStream, u8Strm, &streamCfg);
+            rc = ichac97StreamOpenEx(pThis, pStream, &streamCfg);
         }
         else
-        {
-            /* If no frequency is given, disable the stream. */
-            rc = ichac97StreamSetActive(pThis, pStream, false /* fActive */);
-        }
-    }
-
-    LogFlowFunc(("[SD%RU8] rc=%Rrc\n", u8Strm, rc));
+            rc = VERR_INVALID_PARAMETER;
+    }
+
+    LogFlowFunc(("[SD%RU8] rc=%Rrc\n", pStream->u8Strm, rc));
     return rc;
 }
 
-static int ichac97StreamReInit(PAC97STATE pThis, PAC97STREAM pStrm)
-{
-    return ichac97StreamInit(pThis, pStrm, pStrm->u8Strm);
+static void ichac97StreamClose(PAC97STREAM pStream)
+{
+    LogFlowFunc(("[SD%RU8]\n", pStream->u8Strm));
+}
+
+/**
+ * Re-opens an AC'97 stream on the backend side with the current AC'97 mixer
+ * settings for this stream.
+ *
+ * @returns IPRT status code.
+ * @param   pThis               AC'97 device state.
+ * @param   pStream             Stream to re-open.
+ */
+static int ichac97StreamReOpen(PAC97STATE pThis, PAC97STREAM pStream)
+{
+    LogFlowFunc(("[SD%RU8]\n", pStream->u8Strm));
+
+    ichac97StreamClose(pStream);
+
+    return ichac97StreamOpen(pThis, pStream);
 }
 
@@ -1033 +1088 @@
                 break;
             case PDMAUDIOMIXERCTL_FRONT:
-                rc = AudioMixerSinkSetVolume(pThis->pSinkOutput, &Vol);
+                rc = AudioMixerSinkSetVolume(pThis->pSinkOut,    &Vol);
                 break;
 
@@ -1226 +1281 @@
          * Write data to the mixer sink.
          */
-        rc = AudioMixerSinkWrite(pThis->pSinkOutput, AUDMIXOP_COPY, pu8FIFOW, cbToRead, &cbWritten);
+        rc = AudioMixerSinkWrite(pThis->pSinkOut, AUDMIXOP_COPY, pu8FIFOW, cbToRead, &cbWritten);
         if (RT_FAILURE(rc))
             break;
@@ -1290 +1345 @@
         uint32_t cbWrittenToStream;
 
-        int rc2 = AudioMixerSinkWrite(pThis->pSinkOutput, AUDMIXOP_COPY,
+        int rc2 = AudioMixerSinkWrite(pThis->pSinkOut, AUDMIXOP_COPY,
                                       pThis->silence, cbToWrite, &cbWrittenToStream);
         if (RT_SUCCESS(rc2))
@@ -1355 +1410 @@
 
 #ifndef VBOX_WITH_AUDIO_AC97_CALLBACKS
+#if 0
+static int ichac97TimerStart(PAC97STATE pThis)
+{
+    /*int rc = RTCritSectEnter(&pThis->csTimer);
+    if (RT_SUCCESS(rc))*/
+    {
+        AssertPtr(pThis->pTimer);
+
+        const bool fIsActive = TMTimerIsActive(pThis->pTimer);
+
+        LogFunc(("cStreamsActive=%RU8, fIsActive=%RTbool\n", pThis->cStreamsActive, fIsActive));
+
+        if (!fIsActive) /* Timer not started yet? */
+        {
+            LogFunc(("Starting timer\n"));
+            LogRel3(("AC97: Starting timer\n"));
+
+            /* Update current time timestamp. */
+            pThis->uTimerTS = TMTimerGet(pThis->pTimer);
+
+            /* Fire off timer. */
+            TMTimerSet(pThis->pTimer, TMTimerGet(pThis->pTimer) + pThis->cTimerTicks);
+        }
+
+        /*int rc2 = RTCritSectLeave(&pThis->csTimer);
+        if (RT_SUCCESS(rc))
+            rc = rc2;*/
+    }
+
+    return 0;
+}
+#endif
+
 static void ichac97TimerMaybeStart(PAC97STATE pThis)
 {
@@ -1375 +1463 @@
 
     /* Fire off timer. */
-    TMTimerSet(pThis->pTimer, TMTimerGet(pThis->pTimer) + pThis->cTimerTicks);
+    TMTimerSet(pThis->pTimer, 0 /* u64Expire */);
 }
 
@@ -1402 +1490 @@
     AssertPtr(pThis);
 
-    STAM_PROFILE_START(&pThis->StatTimer, a);
-
-    uint64_t cTicksNow     = TMTimerGet(pTimer);
-
-    LogFlowFuncEnter();
-
-    /* Update current time timestamp. */
-    pThis->uTimerTS = cTicksNow;
-
-    /* Flag indicating whether to kick the timer again for a
-     * new data processing round. */
-    bool fKickTimer = false;
-
-    uint32_t cbToProcess;
-
-    int rc = AudioMixerSinkUpdate(pThis->pSinkLineIn);
+    int rc = RTCritSectEnter(&pThis->csTimer);
     if (RT_SUCCESS(rc))
     {
-        cbToProcess = AudioMixerSinkGetReadable(pThis->pSinkLineIn);
-        if (cbToProcess)
-            rc = ichac97TransferAudio(pThis, &pThis->StreamLineIn, cbToProcess, NULL /* pcbProcessed */);
-
-        fKickTimer |= !!(AudioMixerSinkGetStatus(pThis->pSinkLineIn) & AUDMIXSINK_STS_DIRTY);
-    }
-
-    rc = AudioMixerSinkUpdate(pThis->pSinkMicIn);
-    if (RT_SUCCESS(rc))
-    {
-        cbToProcess = AudioMixerSinkGetReadable(pThis->pSinkMicIn);
-        if (cbToProcess)
-            rc = ichac97TransferAudio(pThis, &pThis->StreamMicIn, cbToProcess, NULL /* pcbProcessed */);
-
-        fKickTimer |= !!(AudioMixerSinkGetStatus(pThis->pSinkMicIn) & AUDMIXSINK_STS_DIRTY);
-    }
-
-    rc = AudioMixerSinkUpdate(pThis->pSinkOutput);
-    if (RT_SUCCESS(rc))
-    {
-        cbToProcess = AudioMixerSinkGetWritable(pThis->pSinkOutput);
-        if (cbToProcess)
-            rc = ichac97TransferAudio(pThis, &pThis->StreamOut, cbToProcess, NULL /* pcbProcessed */);
-
-        fKickTimer |= !!(AudioMixerSinkGetStatus(pThis->pSinkOutput) & AUDMIXSINK_STS_DIRTY);
-    }
-
-    if (   ASMAtomicReadBool(&pThis->fTimerActive)
-        || fKickTimer)
-    {
-        /* Kick the timer again. */
-        uint64_t cTicks = pThis->cTimerTicks;
-        /** @todo adjust cTicks down by now much cbOutMin represents. */
-        TMTimerSet(pThis->pTimer, cTicksNow + cTicks);
-    }
-
-    STAM_PROFILE_STOP(&pThis->StatTimer, a);
+        STAM_PROFILE_START(&pThis->StatTimer, a);
+
+        uint64_t cTicksNow = TMTimerGet(pTimer);
+
+        /* Update current time timestamp. */
+        pThis->uTimerTS = cTicksNow;
+
+        /* Flag indicating whether to kick the timer again for the next DMA transfer or sink processing. */
+        bool fDoNextTransfer = false;
+
+        uint32_t cbToProcess;
+
+        rc = AudioMixerSinkUpdate(pThis->pSinkLineIn);
+        if (RT_SUCCESS(rc))
+        {
+            cbToProcess = AudioMixerSinkGetReadable(pThis->pSinkLineIn);
+            if (cbToProcess)
+                rc = ichac97TransferAudio(pThis, &pThis->StreamLineIn, cbToProcess, NULL /* pcbProcessed */);
+
+            if (AudioMixerSinkGetStatus(pThis->pSinkLineIn) & AUDMIXSINK_STS_DIRTY)
+                fDoNextTransfer = true;
+        }
+
+        rc = AudioMixerSinkUpdate(pThis->pSinkMicIn);
+        if (RT_SUCCESS(rc))
+        {
+            cbToProcess = AudioMixerSinkGetReadable(pThis->pSinkMicIn);
+            if (cbToProcess)
+                rc = ichac97TransferAudio(pThis, &pThis->StreamMicIn, cbToProcess, NULL /* pcbProcessed */);
+
+            if (AudioMixerSinkGetStatus(pThis->pSinkMicIn) & AUDMIXSINK_STS_DIRTY)
+                fDoNextTransfer = true;
+        }
+
+        rc = AudioMixerSinkUpdate(pThis->pSinkOut);
+        if (RT_SUCCESS(rc))
+        {
+            cbToProcess = AudioMixerSinkGetWritable(pThis->pSinkOut);
+            if (cbToProcess)
+                rc = ichac97TransferAudio(pThis, &pThis->StreamOut, cbToProcess, NULL /* pcbProcessed */);
+
+            if (AudioMixerSinkGetStatus(pThis->pSinkOut) & AUDMIXSINK_STS_DIRTY)
+                fDoNextTransfer = true;
+        }
+
+        if (fDoNextTransfer)
+        {
+            /* Kick the timer again. */
+            uint64_t cTicks = pThis->cTimerTicks;
+            /** @todo adjust cTicks down by now much cbOutMin represents. */
+            TMTimerSet(pThis->pTimer, cTicksNow + cTicks);
+        }
+        else
+        {
+            LogFunc(("Stopping timer\n"));
+            LogRel3(("AC97: Stopping timer\n"));
+        }
+
+        STAM_PROFILE_STOP(&pThis->StatTimer, a);
+
+        int rc2 = RTCritSectLeave(&pThis->csTimer);
+        if (RT_SUCCESS(rc))
+            rc2 = rc;
+    }
 }
 #endif /* !VBOX_WITH_AUDIO_AC97_CALLBACKS */
@@ -1466 +1566 @@
     /* pcbProcessed is optional. */
 
-    Log3Func(("[SD%RU8] cbToProcess=%RU32\n", pStream->u8Strm, cbToProcess));
+    int rc = RTCritSectEnter(&pStream->CritSect);
+    if (RT_FAILURE(rc))
+        return rc;
+
+    LogFunc(("[SD%RU8] cbToProcess=%RU32\n", pStream->u8Strm, cbToProcess));
 
     PAC97BMREGS pRegs = &pStream->Regs;
@@ -1487 +1591 @@
         if (pcbProcessed)
             *pcbProcessed = 0;
+
+        Log3Func(("[SD%RU8] Halted\n", pStream->u8Strm));
+
+        rc = RTCritSectLeave(&pStream->CritSect);
+        AssertRC(rc);
+
         return VINF_SUCCESS;
     }
@@ -1494 +1604 @@
     {
         Log3Func(("[SD%RU8] BCIS set\n", pStream->u8Strm));
+
         if (pcbProcessed)
             *pcbProcessed = 0;
+
+        rc = RTCritSectLeave(&pStream->CritSect);
+        AssertRC(rc);
+
         return VINF_SUCCESS;
     }
-
-    int rc = VINF_SUCCESS;
 
     uint32_t cbLeft  = RT_MIN((uint32_t)(pRegs->picb << 1), cbToProcess);
@@ -1619 +1732 @@
     }
 
+    int rc2 = RTCritSectLeave(&pStream->CritSect);
+    AssertRC(rc2);
+
     if (RT_SUCCESS(rc))
     {
@@ -1641 +1757 @@
 
     PAC97STREAM pStream = ichac97GetStreamFromID(pThis, AC97_PORT2IDX(uPortIdx));
-    PAC97BMREGS pRegs   = pStream ? &pStream->Regs : NULL;
+    PAC97BMREGS pRegs   = NULL;
+
+    if (pStream)
+    {
+        pRegs = &pStream->Regs;
+
+        int rc2 = RTCritSectEnter(&pStream->CritSect);
+        AssertRC(rc2);
+    }
+
+    int rc = VINF_SUCCESS;
 
     switch (cbVal)
@@ -1687 +1813 @@
                 case MC_SR:
                     /* Status Register (lower part) */
-                    *pu32Val = pRegs->sr & 0xff; /** @todo r=andy Use RT_LO_U8. */
+                    *pu32Val = RT_LO_U8(pRegs->sr);
                     Log3Func(("SRb[%d] -> %#x\n", AC97_PORT2IDX(uPortIdx), *pu32Val));
                     break;
@@ -1774 +1900 @@
 
         default:
-            return VERR_IOM_IOPORT_UNUSED;
-    }
-    return VINF_SUCCESS;
+        {
+            AssertFailed();
+            rc = VERR_IOM_IOPORT_UNUSED;
+        }
+    }
+
+    if (pStream)
+    {
+        int rc2 = RTCritSectLeave(&pStream->CritSect);
+        AssertRC(rc2);
+    }
+
+    return rc;
 }
 
@@ -1792 +1928 @@
 
     PAC97STREAM pStream = ichac97GetStreamFromID(pThis, AC97_PORT2IDX(uPortIdx));
-    PAC97BMREGS pRegs   = pStream ? &pStream->Regs : NULL;
+    PAC97BMREGS pRegs   = NULL;
+
+    PAUDMIXSINK pSink   = NULL;
+
+    if (pStream)
+    {
+        pRegs = &pStream->Regs;
+        pSink = ichac97IndexToSink(pThis, pStream->u8Strm);
+        AssertPtr(pSink);
+
+        int rc2 = RTCritSectEnter(&pStream->CritSect);
+        AssertRC(rc2);
+    }
 
     switch (cbVal)
@@ -1800 +1948 @@
             switch (uPortIdx)
             {
+                /*
+                 * Last Valid Index.
+                 */
                 case PI_LVI:
                 case PO_LVI:
                 case MC_LVI:
-                    /* Last Valid Index */
-                    if ((pRegs->cr & AC97_CR_RPBM) && (pRegs->sr & AC97_SR_DCH))
+                {
+                    if (   (pRegs->cr & AC97_CR_RPBM)
+                        && (pRegs->sr & AC97_SR_DCH))
                     {
                         pRegs->sr &= ~(AC97_SR_DCH | AC97_SR_CELV);
@@ -1813 +1965 @@
                     }
                     pRegs->lvi = u32Val % 32;
-                    Log3Func(("LVI[%d] <- %#x\n", AC97_PORT2IDX(uPortIdx), u32Val));
-                    break;
+                    Log3Func(("[SD%RU8] LVI <- %#x\n", pStream->u8Strm, u32Val));
+                    break;
+                }
+
+                /*
+                 * Control Registers.
+                 */
                 case PI_CR:
                 case PO_CR:
                 case MC_CR:
                 {
-                    /* Control Register */
                     if (u32Val & AC97_CR_RR) /* Busmaster reset */
                     {
@@ -1829 +1985 @@
                         if (!(pRegs->cr & AC97_CR_RPBM))
                         {
-                            ichac97StreamSetActive(pThis, pStream, false /* fActive */);
+                            ichac97StreamEnable(pThis, pStream, false /* fActive */);
 
                             pRegs->sr |= AC97_SR_DCH;
@@ -1838 +1994 @@
                             pRegs->piv = (pRegs->piv + 1) % 32;
 
+                            pRegs->sr &= ~AC97_SR_DCH;
+
+                            /* Fetch the initial BDLE descriptor. */
                             ichac97StreamFetchBDLE(pThis, pStream);
-                            ichac97StreamSetActive(pThis, pStream, true /* fActive */);
-
-                            pRegs->sr &= ~AC97_SR_DCH;
+
+                            ichac97StreamEnable(pThis, pStream, true /* fActive */);
                         }
                     }
-                    Log3Func(("CR[%d] <- %#x (cr %#x)\n", AC97_PORT2IDX(uPortIdx), u32Val, pRegs->cr));
+                    Log3Func(("[SD%RU8] CR <- %#x (cr %#x)\n", pStream->u8Strm, u32Val, pRegs->cr));
                     break;
                 }
+
+                /*
+                 * Status Registers.
+                 */
                 case PI_SR:
                 case PO_SR:
                 case MC_SR:
-                    /* Status Register */
+                {
                     pRegs->sr |= u32Val & ~(AC97_SR_RO_MASK | AC97_SR_WCLEAR_MASK);
                     ichac97StreamUpdateSR(pThis, pStream, pRegs->sr & ~(u32Val & AC97_SR_WCLEAR_MASK));
-                    Log3Func(("SR[%d] <- %#x (sr %#x)\n", AC97_PORT2IDX(uPortIdx), u32Val, pRegs->sr));
-                    break;
+                    Log3Func(("[SD%RU8] SR <- %#x (sr %#x)\n", pStream->u8Strm, u32Val, pRegs->sr));
+                    break;
+                }
+
                 default:
-                    LogFunc(("U nabm writeb %#x <- %#x\n", Port, u32Val));
+                    LogFunc(("Unimplemented: %#x <- %#x (Byte)\n", Port, u32Val));
                     break;
             }
@@ -1872 +2036 @@
                     pRegs->sr |= u32Val & ~(AC97_SR_RO_MASK | AC97_SR_WCLEAR_MASK);
                     ichac97StreamUpdateSR(pThis, pStream, pRegs->sr & ~(u32Val & AC97_SR_WCLEAR_MASK));
-                    Log3Func(("SR[%d] <- %#x (sr %#x)\n", AC97_PORT2IDX(uPortIdx), u32Val, pRegs->sr));
+                    Log3Func(("[SD%RU8] SR <- %#x (sr %#x)\n", pStream->u8Strm, u32Val, pRegs->sr));
                     break;
                 default:
-                    LogFunc(("U nabm writew %#x <- %#x\n", Port, u32Val));
+                    LogFunc(("Unimplemented: %#x <- %#x (Word)\n", Port, u32Val));
                     break;
             }
@@ -1890 +2054 @@
                     /* Buffer Descriptor list Base Address Register */
                     pRegs->bdbar = u32Val & ~3;
-                    Log3Func(("BDBAR[%d] <- %#x (bdbar %#x)\n", AC97_PORT2IDX(uPortIdx), u32Val, pRegs->bdbar));
+                    Log3Func(("[SD%RU8] BDBAR <- %#x (bdbar %#x)\n", AC97_PORT2IDX(uPortIdx), u32Val, pRegs->bdbar));
                     break;
                 case AC97_GLOB_CNT:
@@ -1909 +2073 @@
                     break;
                 default:
-                    LogFunc(("U nabm writel %#x <- %#x\n", Port, u32Val));
+                    LogFunc(("Unimplemented: %#x <- %#x (DWord)\n", Port, u32Val));
                     break;
             }
@@ -1919 +2083 @@
             break;
     }
+
+    if (pStream)
+    {
+        int rc2 = RTCritSectLeave(&pStream->CritSect);
+        AssertRC(rc2);
+    }
+
     return VINF_SUCCESS;
 }
@@ -1929 +2100 @@
     RT_NOREF(pDevIns);
     PAC97STATE pThis = (PAC97STATE)pvUser;
+
+    int rc = VINF_SUCCESS;
 
     switch (cbVal)
@@ -1966 +2139 @@
         {
             AssertFailed();
-            return VERR_IOM_IOPORT_UNUSED;
-        }
-    }
-    return VINF_SUCCESS;
+            rc = VERR_IOM_IOPORT_UNUSED;
+        }
+    }
+
+    return rc;
 }
 
@@ -2041 +2215 @@
                     {
                         ichac97MixerSet(pThis, AC97_PCM_Front_DAC_Rate, 48000);
-                        ichac97StreamReInit(pThis, &pThis->StreamOut);
+                        ichac97StreamReOpen(pThis, &pThis->StreamOut);
 
                         ichac97MixerSet(pThis, AC97_PCM_LR_ADC_Rate,    48000);
-                        ichac97StreamReInit(pThis, &pThis->StreamLineIn);
+                        ichac97StreamReOpen(pThis, &pThis->StreamLineIn);
                     }
                     if (!(u32Val & AC97_EACS_VRM))
                     {
                         ichac97MixerSet(pThis, AC97_MIC_ADC_Rate,       48000);
-                        ichac97StreamReInit(pThis, &pThis->StreamMicIn);
+                        ichac97StreamReOpen(pThis, &pThis->StreamMicIn);
                     }
                     LogFunc(("Setting extended audio control to %#x\n", u32Val));
@@ -2059 +2233 @@
                         ichac97MixerSet(pThis, index, u32Val);
                         LogFunc(("Set front DAC rate to %RU32\n", u32Val));
-                        ichac97StreamReInit(pThis, &pThis->StreamOut);
+                        ichac97StreamReOpen(pThis, &pThis->StreamOut);
                     }
                     else
@@ -2069 +2243 @@
                         ichac97MixerSet(pThis, index, u32Val);
                         LogFunc(("Set MIC ADC rate to %RU32\n", u32Val));
-                        ichac97StreamReInit(pThis, &pThis->StreamMicIn);
+                        ichac97StreamReOpen(pThis, &pThis->StreamMicIn);
                     }
                     else
@@ -2079 +2253 @@
                         ichac97MixerSet(pThis, index, u32Val);
                         LogFunc(("Set front LR ADC rate to %RU32\n", u32Val));
-                        ichac97StreamReInit(pThis, &pThis->StreamLineIn);
+                        ichac97StreamReOpen(pThis, &pThis->StreamLineIn);
                     }
                     else
@@ -2148 +2322 @@
         case AC97SOUNDSOURCE_MC_INDEX: return &pThis->StreamMicIn;
         case AC97SOUNDSOURCE_PO_INDEX: return &pThis->StreamOut;
-        default:       break;
+        default:                       break;
     }
 
@@ -2200 +2374 @@
     uint8_t active[AC97SOUNDSOURCE_LAST_INDEX];
 
-    active[AC97SOUNDSOURCE_PI_INDEX] = ichac97StreamIsActive(pThis, &pThis->StreamLineIn) ? 1 : 0;
-    active[AC97SOUNDSOURCE_PO_INDEX] = ichac97StreamIsActive(pThis, &pThis->StreamOut)    ? 1 : 0;
-    active[AC97SOUNDSOURCE_MC_INDEX] = ichac97StreamIsActive(pThis, &pThis->StreamMicIn)  ? 1 : 0;
+    active[AC97SOUNDSOURCE_PI_INDEX] = ichac97StreamIsEnabled(pThis, &pThis->StreamLineIn) ? 1 : 0;
+    active[AC97SOUNDSOURCE_PO_INDEX] = ichac97StreamIsEnabled(pThis, &pThis->StreamOut)    ? 1 : 0;
+    active[AC97SOUNDSOURCE_MC_INDEX] = ichac97StreamIsEnabled(pThis, &pThis->StreamMicIn)  ? 1 : 0;
 
     SSMR3PutMem(pSSM, active, sizeof(active));
@@ -2272 +2446 @@
                              ichac97MixerGet(pThis, AC97_Headphone_Volume_Mute));
 
-    int rc = ichac97StreamsInit(pThis);
-    if (RT_SUCCESS(rc))
+    rc2 = ichac97StreamsInit(pThis);
+    if (RT_SUCCESS(rc2))
     {
         /** @todo r=andy Stream IDs are hardcoded to certain streams. */
-        rc = ichac97StreamSetActive(pThis, &pThis->StreamLineIn,    RT_BOOL(uaStrmsActive[AC97SOUNDSOURCE_PI_INDEX]));
-        if (RT_SUCCESS(rc))
-            rc = ichac97StreamSetActive(pThis, &pThis->StreamMicIn, RT_BOOL(uaStrmsActive[AC97SOUNDSOURCE_MC_INDEX]));
-        if (RT_SUCCESS(rc))
-            rc = ichac97StreamSetActive(pThis, &pThis->StreamOut,   RT_BOOL(uaStrmsActive[AC97SOUNDSOURCE_PO_INDEX]));
+        rc2 = ichac97StreamEnable(pThis, &pThis->StreamLineIn,    RT_BOOL(uaStrmsActive[AC97SOUNDSOURCE_PI_INDEX]));
+        if (RT_SUCCESS(rc2))
+            rc2 = ichac97StreamEnable(pThis, &pThis->StreamMicIn, RT_BOOL(uaStrmsActive[AC97SOUNDSOURCE_MC_INDEX]));
+        if (RT_SUCCESS(rc2))
+            rc2 = ichac97StreamEnable(pThis, &pThis->StreamOut,   RT_BOOL(uaStrmsActive[AC97SOUNDSOURCE_PO_INDEX]));
     }
 
@@ -2286 +2460 @@
     pThis->last_samp = 0;
 
-    LogFlowFuncLeaveRC(rc);
-    return rc;
+    return VINF_SUCCESS;
 }
 
@@ -2355 +2528 @@
 
     /*
-     * Stop any audio currently playing and/or recording.
-     */
-    AudioMixerSinkCtl(pThis->pSinkOutput, AUDMIXSINKCMD_DISABLE);
-    AudioMixerSinkCtl(pThis->pSinkMicIn,  AUDMIXSINKCMD_DISABLE);
-    AudioMixerSinkCtl(pThis->pSinkLineIn, AUDMIXSINKCMD_DISABLE);
-
-    /*
      * Reset all streams.
      */
@@ -2395 +2561 @@
     Assert(RTListIsEmpty(&pThis->lstDrv));
 
-    LogFlowFuncLeave();
-    return VINF_SUCCESS;
+    int rc;
+#ifndef VBOX_WITH_AUDIO_AC97_CALLBACKS
+    rc = RTCritSectDelete(&pThis->csTimer);
+#else
+    rc = VINF_SUCCESS;
+#endif
+
+    LogFlowFuncLeaveRC(rc);
+    return rc;
 }
 
@@ -2712 +2885 @@
         {
             /* Add all required audio sinks. */
-            int rc2 = AudioMixerCreateSink(pThis->pMixer, "[Playback] PCM Output", AUDMIXSINKDIR_OUTPUT, &pThis->pSinkOutput);
+            int rc2 = AudioMixerCreateSink(pThis->pMixer, "[Playback] PCM Output", AUDMIXSINKDIR_OUTPUT, &pThis->pSinkOut);
             AssertRC(rc2);
 
@@ -2731 +2904 @@
     if (RT_SUCCESS(rc))
     {
-        /* Start the emulation timer. */
-        rc = PDMDevHlpTMTimerCreate(pDevIns, TMCLOCK_VIRTUAL, ichac97Timer, pThis,
-                                    TMTIMER_FLAGS_NO_CRIT_SECT, "DevIchAc97", &pThis->pTimer);
-        AssertRCReturn(rc, rc);
-
+        rc = RTCritSectInit(&pThis->csTimer);
         if (RT_SUCCESS(rc))
         {
-            pThis->cTimerTicks = TMTimerGetFreq(pThis->pTimer) / uTimerHz;
-            pThis->uTimerTS    = TMTimerGet(pThis->pTimer);
-            LogFunc(("Timer ticks=%RU64 (%RU16 Hz)\n", pThis->cTimerTicks, uTimerHz));
-
-            ichac97TimerMaybeStart(pThis);
+            /* Start the emulation timer. */
+            rc = PDMDevHlpTMTimerCreate(pDevIns, TMCLOCK_VIRTUAL, ichac97Timer, pThis,
+                                        TMTIMER_FLAGS_NO_CRIT_SECT, "DevIchAc97", &pThis->pTimer);
+            AssertRCReturn(rc, rc);
+
+            if (RT_SUCCESS(rc))
+            {
+                pThis->cTimerTicks = TMTimerGetFreq(pThis->pTimer) / uTimerHz;
+                pThis->uTimerTS    = TMTimerGet(pThis->pTimer);
+                LogFunc(("Timer ticks=%RU64 (%RU16 Hz)\n", pThis->cTimerTicks, uTimerHz));
+            }
         }
     }