Changeset 63917 in vbox

Timestamp:

Sep 21, 2016 7:58:31 AM (8 years ago)

Author:

vboxsync

Message:

DrvVD: Don't fail completely when loading a plugin failed, log the error and go on

File:

• trunk/src/VBox/Devices/Storage/DrvVD.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Storage/DrvVD.cpp

@@ -3751 +3751 @@
 static int drvvdLoadPlugins(PCFGMNODE pCfg)
 {
-    int rc = VINF_SUCCESS;
     PCFGMNODE pCfgPlugins = CFGMR3GetChild(pCfg, "Plugins");
 
@@ -3757 +3756 @@
     {
         PCFGMNODE pPluginCur = CFGMR3GetFirstChild(pCfgPlugins);
-        while (   pPluginCur
-               && RT_SUCCESS(rc))
-        {
+        while (pPluginCur)
+        {
+            int rc = VINF_SUCCESS;
             char *pszPluginFilename = NULL;
             rc = CFGMR3QueryStringAlloc(pPluginCur, "Path", &pszPluginFilename);
@@ -3765 +3764 @@
                 rc = VDPluginLoadFromFilename(pszPluginFilename);
 
+            if (RT_FAILURE(rc))
+                LogRel(("VD: Failed to load plugin '%s' with %Rrc, continuing\n", pszPluginFilename, rc));
+
             pPluginCur = CFGMR3GetNextChild(pPluginCur);
         }
     }
 
-    return rc;
+    return VINF_SUCCESS;
 }