Changeset 64213 in vbox for trunk

Timestamp:

Oct 11, 2016 3:58:12 PM (8 years ago)

Author:

vboxsync

Message:

Main/MediumLock: when destroying locks, lock lists or lock list maps, keep the error information unchanged, because it's very surprising behavior that the potential unlock errors are showing up in the thread's error info, often losing it during error handling

File:

• trunk/src/VBox/Main/src-server/MediumLock.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-server/MediumLock.cpp

@@ -30 +30 @@
 MediumLock::~MediumLock()
 {
+    // destroying medium locks is routinely done as part of error handling
+    // and it's not expected to lose error info
+    ErrorInfoKeeper eik;
     Unlock();
 }
@@ -156 +159 @@
 MediumLockList::~MediumLockList()
 {
+    // destroying medium lock lists is routinely done as part of error handling
+    // and it's not expected to lose error info
+    ErrorInfoKeeper eik;
     Clear();
     // rest is done by the list object's destructor
@@ -269 +275 @@
 MediumLockListMap::~MediumLockListMap()
 {
+    // destroying medium lock list maps is routinely done as part of
+    // error handling and it's not expected to lose error info
+    ErrorInfoKeeper eik;
     Clear();
     // rest is done by the map object's destructor