Changeset 64285 in vbox for trunk/src/VBox/Additions

Timestamp:

Oct 16, 2016 8:08:03 PM (8 years ago)

Author:

vboxsync

Message:

Additions: bugref:8622: Use crc of user name in name of ipc pipe

Location:

trunk/src/VBox/Additions

Files:

• WINNT/Installer/InstallHelper/VBoxGuestInstallHelper.cpp (modified) (2 diffs)
• WINNT/VBoxTray/VBoxIPC.cpp (modified) (2 diffs)
• WINNT/VBoxTray/VBoxTray.cpp (modified) (1 diff)
• common/VBoxService/VBoxServiceVMInfo-win.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/WINNT/Installer/InstallHelper/VBoxGuestInstallHelper.cpp

@@ -34 +34 @@
 #include <iprt/mem.h>
 #include <iprt/string.h>
+#include <iprt/localipc.h>
 
 /* Required structures/defines of VBoxTray. */
@@ -152 +153 @@
         if (RT_SUCCESS(rc))
         {
-            char szPipeName[255];
-            if (RTStrPrintf(szPipeName, sizeof(szPipeName), "%s%s",
-                            VBOXTRAY_IPC_PIPE_PREFIX, pszUserName))
+            char szPipeName[80];
+            size_t cbPipeName = sizeof(szPipeName);
+            rc = RTLocalIpcMakeNameUniqueUser(VBOXTRAY_IPC_PIPE_PREFIX, pszUserName, szPipeName, &cbPipeName);
+            if (RT_SUCCESS(rc))
             {
                 rc = RTLocalIpcSessionConnect(phSession, szPipeName, 0 /* Flags */);
             }
-            else
-                rc = VERR_NO_MEMORY;
 
             RTStrFree(pszUserName);

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxIPC.cpp

@@ -175 +175 @@
 }
 
+
 /**
  * Initializes the IPC communication.
@@ -195 +196 @@
     if (RT_SUCCESS(rc))
     {
-        char szPipeName[512 + sizeof(VBOXTRAY_IPC_PIPE_PREFIX)];
-        strcpy(szPipeName, VBOXTRAY_IPC_PIPE_PREFIX);
+        char szUserName[512];
         rc = RTProcQueryUsername(NIL_RTPROCESS,
-                                 &szPipeName[sizeof(VBOXTRAY_IPC_PIPE_PREFIX) - 1],
-                                 sizeof(szPipeName) - sizeof(VBOXTRAY_IPC_PIPE_PREFIX) + 1,
+                                 szUserName,
+                                 sizeof(szUserName),
                                  NULL /*pcbUser*/);
         if (RT_SUCCESS(rc))
         {
-            rc = RTLocalIpcServerCreate(&pCtx->hServer, szPipeName, 0 /*fFlags*/);
+            char szPipeName[80];
+            size_t cbPipeName = sizeof(szPipeName);
+            rc = RTLocalIpcMakeNameUniqueUser(VBOXTRAY_IPC_PIPE_PREFIX, szUserName, szPipeName, &cbPipeName);
             if (RT_SUCCESS(rc))
             {
-                pCtx->pEnv = pEnv;
-                RTListInit(&pCtx->SessionList);
-
-                *ppInstance = pCtx;
-
-                /* GetLastInputInfo only is available starting at Windows 2000 -- might fail. */
-                g_pfnGetLastInputInfo = (PFNGETLASTINPUTINFO)
-                    RTLdrGetSystemSymbol("User32.dll", "GetLastInputInfo");
-
-                LogRelFunc(("Local IPC server now running at \"%s\"\n", szPipeName));
-                return VINF_SUCCESS;
-            }
-
+
+                rc = RTLocalIpcServerCreate(&pCtx->hServer, szPipeName, 0 /*fFlags*/);
+                if (RT_SUCCESS(rc))
+                {
+                    pCtx->pEnv = pEnv;
+                    RTListInit(&pCtx->SessionList);
+
+                    *ppInstance = pCtx;
+
+                    /* GetLastInputInfo only is available starting at Windows 2000 -- might fail. */
+                    g_pfnGetLastInputInfo = (PFNGETLASTINPUTINFO)
+                        RTLdrGetSystemSymbol("User32.dll", "GetLastInputInfo");
+
+                    LogRelFunc(("Local IPC server now running at \"%s\"\n", szPipeName));
+                    return VINF_SUCCESS;
+                }
+
+            }
         }
 

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxTray.cpp

@@ -308 +308 @@
             LogRel(("Failed to initialize service '%s', rc=%Rrc\n", pSvc->pDesc->pszName, rc2));
             if (rc2 == VERR_NOT_SUPPORTED)
-            {
                 LogRel(("Service '%s' is not supported on this system\n", pSvc->pDesc->pszName));
-                rc2 = VINF_SUCCESS;
-            }
+            rc2 = VINF_SUCCESS;
             /* Keep going. */
         }

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo-win.cpp

@@ -39 +39 @@
 #include <iprt/time.h>
 #include <iprt/thread.h>
+
 
 #include <VBox/VBoxGuestLib.h>
@@ -955 +956 @@
 
     int rc = VINF_SUCCESS;
-
-    char szPipeName[255];
+    char szPipeName[80];
+    size_t cbPipeName = sizeof(szPipeName);
+    rc = RTLocalIpcMakeNameUniqueUser(VBOXTRAY_IPC_PIPE_PREFIX, pszUser, szPipeName, &cbPipeName);
 /** @todo r=bird:  Pointless if.  */
-    if (RTStrPrintf(szPipeName, sizeof(szPipeName), "%s%s", VBOXTRAY_IPC_PIPE_PREFIX, pszUser))
+    if (RT_SUCCESS(rc))
     {
         bool fReportToHost = false;