Changeset 64293 in vbox for trunk/src

Timestamp:

Oct 17, 2016 11:34:18 AM (8 years ago)

Author:

vboxsync

Message:

mp-win.cpp: Can't skip lazy GIP re-initialization anywhere, because GIP may have a different max CPU count on Vista level systems.

File:

• trunk/src/VBox/Runtime/r3/win/mp-win.cpp (modified) (11 diffs)

trunk/src/VBox/Runtime/r3/win/mp-win.cpp

@@ -57 +57 @@
 *   Defined Constants And Macros                                                                                                 *
 *********************************************************************************************************************************/
-/** @def RTMPWIN_UPDATE_GIP_GLOBAL
+/** @def RTMPWIN_UPDATE_GIP_GLOBALS
  * Does lazy (re-)initialization using information provieded by GIP. */
 #ifdef IPRT_WITH_GIP_MP_INFO
-# define RTMPWIN_UPDATE_GIP_GLOBAL() \
+# define RTMPWIN_UPDATE_GIP_GLOBALS() \
     do { RTMPWIN_UPDATE_GIP_GLOBALS_AND_GET_PGIP(); } while (0)
 #else
-# define RTMPWIN_UPDATE_GIP_GLOBAL() do { } while (0)
+# define RTMPWIN_UPDATE_GIP_GLOBALS() do { } while (0)
 #endif
 
@@ -523 +523 @@
 {
     RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
-    RTMPWIN_UPDATE_GIP_GLOBAL();
+    RTMPWIN_UPDATE_GIP_GLOBALS();
 
 #ifdef IPRT_WITH_RTCPUID_AS_GROUP_AND_NUMBER
@@ -540 +540 @@
 {
     RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
-    RTMPWIN_UPDATE_GIP_GLOBAL();
+    RTMPWIN_UPDATE_GIP_GLOBALS();
 
     if ((unsigned)iCpu < RT_ELEMENTS(g_aidRtMpWinByCpuSetIdx))
@@ -568 +568 @@
 RTDECL(int) RTMpSetIndexFromCpuGroupMember(uint32_t idxGroup, uint32_t idxMember)
 {
+    RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
+    RTMPWIN_UPDATE_GIP_GLOBALS();
+
     if (idxGroup < g_cRtMpWinMaxCpuGroups)
         if (idxMember < g_aRtMpWinCpuGroups[idxGroup].cMaxCpus)
@@ -577 +580 @@
 RTDECL(uint32_t) RTMpGetCpuGroupCounts(uint32_t idxGroup, uint32_t *pcActive)
 {
+    RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
+    RTMPWIN_UPDATE_GIP_GLOBALS();
+
     if (idxGroup < g_cRtMpWinMaxCpuGroups)
     {
@@ -591 +597 @@
 RTDECL(uint32_t) RTMpGetMaxCpuGroupCount(void)
 {
+    RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
+    RTMPWIN_UPDATE_GIP_GLOBALS();
+
     return g_cRtMpWinMaxCpuGroups;
 }
@@ -603 +612 @@
 {
     RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
-#ifdef IPRT_WITH_RTCPUID_AS_GROUP_AND_NUMBER
-    RTMPWIN_UPDATE_GIP_GLOBAL();
-#endif
+    RTMPWIN_UPDATE_GIP_GLOBALS();
 
     PROCESSOR_NUMBER ProcNum;
@@ -643 +650 @@
 {
     RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
+    RTMPWIN_UPDATE_GIP_GLOBALS();
+
 #ifdef IPRT_WITH_RTCPUID_AS_GROUP_AND_NUMBER
     return RTMPCPUID_FROM_GROUP_AND_NUMBER(g_cRtMpWinMaxCpuGroups - 1,
@@ -655 +664 @@
 {
     RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
-    RTMPWIN_UPDATE_GIP_GLOBAL();
+    RTMPWIN_UPDATE_GIP_GLOBALS();
 
     /* Any CPU between 0 and g_cRtMpWinMaxCpus are possible. */
@@ -675 +684 @@
 {
     RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
+    RTMPWIN_UPDATE_GIP_GLOBALS();
 
     return g_cRtMpWinMaxCpus;
@@ -683 +693 @@
 {
     RTOnce(&g_MpInitOnce, rtMpWinInitOnce, NULL);
+    RTMPWIN_UPDATE_GIP_GLOBALS();
 
     return g_cRtMpWinMaxCpuCores;