Changeset 64306 in vbox for trunk/src

Timestamp:

Oct 17, 2016 5:13:48 PM (8 years ago)

Author:

vboxsync

Message:

vgdrvNtCleanup: Added @todo about nasty misbehavior if the driver is restarted like when CPUs are hotplugged.

Location:

trunk/src/VBox/Additions

Files:

• WINNT/Installer/VBoxDrvInst.cpp (modified) (1 diff)
• common/VBoxGuest/VBoxGuest-win.cpp (modified) (7 diffs)

trunk/src/VBox/Additions/WINNT/Installer/VBoxDrvInst.cpp

@@ -383 +383 @@
             if (SUCCEEDED(hr))
             {
-                _tprintf(_T("Driver was installed successfully!\n"));
+                _tprintf(_T("Driver was %sinstalled successfully!\n"), fInstall ? _T("") : _T("un"));
                 if (fReboot)
-                    _tprintf(_T("A reboot is needed to complete the driver (un)installation!\n"));
+                    _tprintf(_T("A reboot is needed to complete the driver %sinstallation!\n"), fInstall ? _T("") : _T("un"));
             }
         }

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp

@@ -274 +274 @@
                  * so continue to init our own things.
                  */
-#ifdef VBOX_WITH_GUEST_BUGCHECK_DETECTION
+# ifdef VBOX_WITH_GUEST_BUGCHECK_DETECTION
                 vgdrvNtBugCheckCallback(pDevExt); /* Ignore failure! */
-#endif
+# endif
                 if (NT_SUCCESS(rc))
                 {
@@ -309 +309 @@
     return rc;
 }
-#endif /* TARGET_NT4 */
+#endif /* !TARGET_NT4 */
 
 
@@ -383 +383 @@
 #ifndef TARGET_NT4
     PIO_STACK_LOCATION  pStack  = IoGetCurrentIrpStackLocation(pIrp);
-#endif
-
-    LogFlowFuncEnter();
+    LogFlowFunc(("ENTER: pDevObj=%p pIrp=%p\n", pDevObj, pIrp));
+#else
+    LogFlowFunc(("ENTER: pDrvObj=%p pDevObj=%p pRegPath=%p\n", pDrvObj, pDevObj, pRegPath));
+#endif
 
     NTSTATUS rcNt;
@@ -464 +465 @@
          * Register DPC and ISR.
          */
-        LogFlowFunc(("Initializing DPC/ISR ...\n"));
+        LogFlowFunc(("Initializing DPC/ISR (pDevObj=%p)...\n", pDevExt->pDeviceObject));
 
         IoInitializeDpcRequest(pDevExt->pDeviceObject, vgdrvNtDpcHandler);
@@ -493 +494 @@
         if (pDevExt->interruptVector)
         {
-            LogFlowFunc(("Connecting interrupt ...\n"));
+#ifdef TARGET_NT4
+            LogFlowFunc(("Connecting interrupt (IntVector=%#u), IrqLevel=%u) ...\n", uInterruptVector, irqLevel));
+#else
+            LogFlowFunc(("Connecting interrupt (IntVector=%#u), IrqLevel=%u) ...\n", pDevExt->interruptVector, pDevExt->interruptLevel));
+#endif
 
             rcNt = IoConnectInterrupt(&pDevExt->pInterruptObject,                 /* Out: interrupt object. */
@@ -513 +518 @@
                                       FALSE);                                     /* Don't save FPU stack. */
             if (NT_ERROR(rcNt))
-                LogFunc(("Could not connect interrupt, rcNt=%#x\n", rcNt));
+                LogFunc(("Could not connect interrupt: rcNt=%#x!\n", rcNt));
         }
         else
@@ -559 +564 @@
  * Cleans up hardware resources.
  * Do not delete DevExt here.
+ *
+ * @todo r=bird: HC SVNT DRACONES!
+ *
+ *       This code leaves clients hung when vgdrvNtInit is called afterwards.
+ *       This happens when for instance hotplugging a CPU.  Problem is
+ *       vgdrvNtInit doing a full VGDrvCommonInitDevExt, orphaning all pDevExt
+ *       members, like session lists and stuff.
  *
  * @param   pDevObj     Device object.