Changeset 64352 in vbox for trunk/src/VBox

Timestamp:

Oct 21, 2016 12:04:16 PM (8 years ago)

Author:

vboxsync

Message:

Audio/DevIchHdaCodec.cpp: Association group fixes for recording on Windows guests.

File:

• trunk/src/VBox/Devices/Audio/HDACodec.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Audio/HDACodec.cpp

@@ -512 +512 @@
 #define CODEC_F1C_ASSOCIATION_GROUP_6                      0x7
 #define CODEC_F1C_ASSOCIATION_GROUP_7                      0x8
+/* Note: Windows OSes will treat group 15 (0xF) as single PIN devices.
+ *       The sequence number associated with that group then will be ignored. */
 #define CODEC_F1C_ASSOCIATION_GROUP_15                     0xF
 
@@ -1155 +1157 @@
                                                           CODEC_F1C_COLOR_PINK,
                                                           CODEC_F1C_MISC_NONE,
-                                                          CODEC_F1C_ASSOCIATION_GROUP_4, 0x0 /* Seq */);
+                                                          CODEC_F1C_ASSOCIATION_GROUP_15, 0x0 /* Ignored */);
             /* Fall through is intentional. */
 
@@ -1180 +1182 @@
              * not care either way, although Linux does.
              */
-            pNode->port.u32F09_param = CODEC_MAKE_F09_ANALOG(0, 0);
+            pNode->port.u32F09_param = CODEC_MAKE_F09_ANALOG(0 /* fPresent */, 0);
 
             pNode->port.node.au32F00_param[0x9] = CODEC_MAKE_F00_09(CODEC_F00_09_TYPE_PIN_COMPLEX, 0, 0)
-                                                | CODEC_F00_09_CAP_UNSOL
                                                 | CODEC_F00_09_CAP_STEREO;
 
@@ -1204 +1205 @@
             pNode->port.u32F07_param = CODEC_F07_IN_ENABLE | CODEC_F07_OUT_ENABLE;
             pNode->port.u32F08_param = 0;
-            pNode->port.u32F09_param = CODEC_MAKE_F09_ANALOG(true /* fPresent */, CODEC_F09_ANALOG_NA);
+            pNode->port.u32F09_param = CODEC_MAKE_F09_ANALOG(1 /* fPresent */, CODEC_F09_ANALOG_NA);
 
             pNode->port.node.au32F00_param[0x9] = CODEC_MAKE_F00_09(CODEC_F00_09_TYPE_PIN_COMPLEX, 0, 0)
@@ -1437 +1438 @@
                                                               CODEC_F1C_COLOR_UNKNOWN,
                                                               CODEC_F1C_MISC_NONE,
-                                                              CODEC_F1C_ASSOCIATION_GROUP_15, 0xB /* Seq */);
+                                                              CODEC_F1C_ASSOCIATION_GROUP_15, 0x0 /* Ignored */);
             break;
         }