Changeset 64379 in vbox

Timestamp:

Oct 24, 2016 12:20:54 PM (8 years ago)

Author:

vboxsync

Message:

Audio/DrvAudio.cpp: Don't create internal stream objects if backend failed to initialize.

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -552 +552 @@
 
     PDMAUDIOSTREAMCFG CfgHostAcq;
-    int rc = drvAudioStreamCreateInternalBackend(pThis,pHstStream, pCfgHost, &CfgHostAcq);
+    int rc = drvAudioStreamCreateInternalBackend(pThis, pHstStream, pCfgHost, &CfgHostAcq);
     if (RT_FAILURE(rc))
         return rc;
@@ -1871 +1871 @@
         rc = drvAudioStreamInitInternal(pThis, pHstStrm, pCfgHost, pCfgGuest);
         if (RT_FAILURE(rc))
-        {
-            LogFlowFunc(("Stream not available (yet)\n"));
-            rc = VINF_SUCCESS;
-        }
+            break;
 
 #ifdef VBOX_WITH_STATISTICS
@@ -1907 +1904 @@
                                       szStatName, STAMUNIT_COUNT, "Total samples played.");
         }
+        else
+            AssertFailed();
 #endif
 
@@ -2209 +2208 @@
                     PDMDrvHlpSTAMDeregister(pThis->pDrvIns, &pHstStream->Out.StatSamplesPlayed);
                 }
+                else
+                    AssertFailed();
 #endif
                 RTListNodeRemove(&pHstStream->Node);
@@ -2238 +2239 @@
                     PDMDrvHlpSTAMDeregister(pThis->pDrvIns, &pGstStream->Out.StatSamplesPlayed);
                 }
+                else
+                    AssertFailed();
 #endif
                 RTListNodeRemove(&pGstStream->Node);